ProcessExecutor::extractResult() - Code Metrics - Inspection of "Added process-executor which uses a process to exe..." - php-task/TaskBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#40)

by Wachter

created 2017-08-09 13:47 UTC

ProcessExecutor::extractResult() A

↳ Parent: ProcessExecutor

Complexity

Conditions	2
Paths	2

Size

Total Lines	18
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	2.0023

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	18
ccs	11
cts	12
cp	0.9167
rs	9.4285
cc	2
eloc	11
nc	2
nop	1
crap	2.0023

<?php

/*
 * This file is part of php-task library.
 *
 * (c) php-task
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Task\TaskBundle\Executor;

use Symfony\Component\Process\ProcessBuilder;
use Task\Execution\TaskExecutionInterface;
use Task\Runner\ExecutorInterface;
use Task\TaskBundle\Command\ExecuteCommand;

/**
 * Uses a process to start the executions via console-command.
 */
class ProcessExecutor implements ExecutorInterface
{
    /**
     * @var string
     */
    private $consoleFile;

    /**
     * @param string $consoleFile
     */
    public function __construct($consoleFile)
    {
        $this->consoleFile = $consoleFile;
    }

    /**
     * {@inheritdoc}
     */
    public function execute(TaskExecutionInterface $execution)
    {
        $process = ProcessBuilder::create([$this->consoleFile, 'task:execute', $execution->getUuid()])->getProcess();

        $process->run();

        if (!$process->isSuccessful()) {
            throw new ProcessException($process->getErrorOutput());
        }

        return $this->extractResult($process->getOutput());
    }

    /**
     * Extract the result from output.
     *
     * @param string $output
     *
     * @return string
     */
    private function extractResult($output)
    {
        $match = preg_match(
            sprintf(
                '/%s(?<result>.*)%s/s',
                preg_quote(ExecuteCommand::START_RESULT),
                preg_quote(ExecuteCommand::END_RESULT)
            ),
            $output,
            $matches
        );

        if (!$match) {
            return;
        }

        return $matches['result'];
    }
}


1		<?php
2
3		/*
4		* This file is part of php-task library.
5		*
6		* (c) php-task
7		*
8		* This source file is subject to the MIT license that is bundled
9		* with this source code in the file LICENSE.
10		*/
11
12		namespace Task\TaskBundle\Executor;
13
14		use Symfony\Component\Process\ProcessBuilder;
15		use Task\Execution\TaskExecutionInterface;
16		use Task\Runner\ExecutorInterface;
17		use Task\TaskBundle\Command\ExecuteCommand;
18
19		/**
20		* Uses a process to start the executions via console-command.
21		*/
22		class ProcessExecutor implements ExecutorInterface
23		{
24		/**
25		* @var string
26		*/
27		private $consoleFile;
28
29		/**
30		* @param string $consoleFile
31		*/
32	13	public function __construct($consoleFile)
33		{
34	13	$this->consoleFile = $consoleFile;
35	13	}
36
37		/**
38		* {@inheritdoc}
39		*/
40	2	public function execute(TaskExecutionInterface $execution)
41		{
42	2	$process = ProcessBuilder::create([$this->consoleFile, 'task:execute', $execution->getUuid()])->getProcess();
43
44	2	$process->run();
45
46	2	if (!$process->isSuccessful()) {
47	1	throw new ProcessException($process->getErrorOutput());
48		}
49
50	1	return $this->extractResult($process->getOutput());
51		}
52
53		/**
54		* Extract the result from output.
55		*
56		* @param string $output
57		*
58		* @return string
59		*/
60	1	private function extractResult($output)
61		{
62	1	$match = preg_match(
63	1	sprintf(
64	1	'/%s(?<result>.*)%s/s',
65	1	preg_quote(ExecuteCommand::START_RESULT),
66	1	preg_quote(ExecuteCommand::END_RESULT)
67	1	),
68	1	$output,
69		$matches
70	1	);
71
72	1	if (!$match) {
73		return;
74		}
75
76	1	return $matches['result'];
77		}
78		}
79

php-task / TaskBundle

Pull Request — master (#40)

ProcessExecutor::extractResult() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like