for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
namespace Task\TaskBundle\Executor;
use Symfony\Component\Process\Process;
use Symfony\Component\Process\ProcessBuilder;
/**
* Factory for execution-process.
*/
class ExecutionProcessFactory
{
* @var string
private $consolePath;
private $environment;
* @var float|null
private $processTimeout;
* @param string $consolePath
* @param float|null $processTimeout
* @param string $environment
public function __construct($consolePath, $processTimeout, $environment)
$this->consolePath = $consolePath;
$this->processTimeout = $processTimeout;
$this->environment = $environment;
}
* Create process for given execution-uuid.
*
* @param string $uuid
* @return Process
public function create($uuid)
return $process = ProcessBuilder::create(
$process
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
$myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; }
Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.
$myVar
$higher
[$this->consolePath, 'task:execute', $uuid, '--env=' . $this->environment]
)
->setTimeout($this->processTimeout)
->getProcess();
php-task /
TaskBundle
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.