Task\TaskBundle\Command\RunHandlerCommand

Complexity

Total Complexity

5

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	5

Test Coverage

Coverage

0%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	configure()	0	13	1
A	execute()	0	15	3

<?php

/*
 * This file is part of php-task library.
 *
 * (c) php-task
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Task\TaskBundle\Command;

use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Task\Handler\TaskHandlerFactoryInterface;

/**
 * Run pending tasks.
 */
class RunHandlerCommand extends Command
{
    /**
     * @var TaskHandlerFactoryInterface
     */
    private $handlerFactory;

    /**
     * @param string $name
     * @param TaskHandlerFactoryInterface $handlerFactory
     */
    public function __construct($name, TaskHandlerFactoryInterface $handlerFactory)
    {
        parent::__construct($name);

        $this->handlerFactory = $handlerFactory;
    }

    /**
     * {@inheritdoc}
     */
    protected function configure()
    {
        $this
            ->setDescription('Run handler')
            ->setHelp(<<<'EOT'
The <info>%command.name%</info> command run given handler.

    $ %command.full_name% AppBundle\\Handler\\ImageHandler ./img/test-image.jpg
EOT
            )
        ->addArgument('handlerClass', InputArgument::REQUIRED, 'Handler which will be called')
        ->addArgument('workload', InputArgument::OPTIONAL, 'This will be passed to the handler');
    }

    /**
     * {@inheritdoc}
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $handlerClass = $input->getArgument('handlerClass');
        $workload = $input->getArgument('workload');

        if ($output->getVerbosity() >= OutputInterface::VERBOSITY_VERBOSE) {
            $output->writeln(sprintf('Run command "%s" with workload "%s"', $handlerClass, $workload));
        }

        $result = $this->handlerFactory->create($handlerClass)->handle($workload);

It seems like $handlerClass defined by $input->getArgument('handlerClass') on line 63 can also be of type array<integer,string> or null; however, Task\Handler\TaskHandlerFactoryInterface::create() does only seem to accept string, maybe add an additional type check?

It seems like $workload defined by $input->getArgument('workload') on line 64 can also be of type array<integer,string> or null; however, Task\Handler\TaskHandlerInterface::handle() does only seem to accept string|object<Serializable>, maybe add an additional type check?

        if ($output->getVerbosity() >= OutputInterface::VERBOSITY_VERBOSE) {
            $output->writeln(sprintf('Result: %s', json_encode($result)));
        }
    }
}