ExecutionProcessFactory::create() - Code Metrics - Inspection of "Update branch alias" - php-task/TaskBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 381036...d6bde4 )

by Alexander

created 2020-06-16 13:23 UTC

ExecutionProcessFactory::create() A

↳ Parent: ExecutionProcessFactory

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2.0185

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	5
cts	6
cp	0.8333
rs	9.8666
c	0
b	0
f	0
cc	2
nc	2
nop	1
crap	2.0185

<?php

namespace Task\TaskBundle\Executor;

use Symfony\Component\Process\Process;

/**
 * Factory for execution-process.
 */
class ExecutionProcessFactory
{
    /**
     * @var string
     */
    private $consolePath;

    /**
     * @var string
     */
    private $environment;

    /**
     * @var float|null
     */
    private $processTimeout;

    /**
     * @param string $consolePath
     * @param float|null $processTimeout
     * @param string $environment
     */
    public function __construct($consolePath, $processTimeout, $environment)
    {
        $this->consolePath = $consolePath;
        $this->processTimeout = $processTimeout;
        $this->environment = $environment;
    }

    /**
     * Create process for given execution-uuid.
     *
     * @param string $uuid
     *
     * @return Process
     */
    public function create($uuid)
    {
        $command = implode(' ', [$this->consolePath, 'task:execute', $uuid, '--env=' . $this->environment]);

        if (method_exists(Process::class, 'fromShellCommandline')) {
            $process = Process::fromShellCommandline($command);
        } else {
            $process = new Process($command);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        return $process->setTimeout($this->processTimeout);
    }
}


1		<?php
2
3		namespace Task\TaskBundle\Executor;
4
5		use Symfony\Component\Process\Process;
6
7		/**
8		* Factory for execution-process.
9		*/
10		class ExecutionProcessFactory
11		{
12		/**
13		* @var string
14		*/
15		private $consolePath;
16
17		/**
18		* @var string
19		*/
20		private $environment;
21
22		/**
23		* @var float\|null
24		*/
25		private $processTimeout;
26
27		/**
28		* @param string $consolePath
29		* @param float\|null $processTimeout
30		* @param string $environment
31		*/
32	13	public function __construct($consolePath, $processTimeout, $environment)
33		{
34	13	$this->consolePath = $consolePath;
35	13	$this->processTimeout = $processTimeout;
36	13	$this->environment = $environment;
37	13	}
38
39		/**
40		* Create process for given execution-uuid.
41		*
42		* @param string $uuid
43		*
44		* @return Process
45		*/
46	2	public function create($uuid)
47		{
48	2	$command = implode(' ', [$this->consolePath, 'task:execute', $uuid, '--env=' . $this->environment]);
49
50	2	if (method_exists(Process::class, 'fromShellCommandline')) {
51	2	$process = Process::fromShellCommandline($command);
52		} else {
53		$process = new Process($command);
		0 ignored issues – show Documentation introduced 2020-06-16 13:42 UTC by Report Bug Copy Issue Report `$command` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
54		}
55
56	2	return $process->setTimeout($this->processTimeout);
57		}
58		}
59

php-task / TaskBundle

Push — master ( 381036...d6bde4 )

ExecutionProcessFactory::create() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like