Task\TaskBundle\Command\ExecuteCommand

Complexity

Total Complexity

7

Size/Duplication

Total Lines	73
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	9

Test Coverage

Coverage

0%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	isHidden()	0	4	1
A	__construct()	0	10	1
A	configure()	0	4	1
A	execute()	0	25	4

<?php

/*
 * This file is part of php-task library.
 *
 * (c) php-task
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Task\TaskBundle\Command;

use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\ConsoleOutputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Task\Executor\FailedException;
use Task\Handler\TaskHandlerFactoryInterface;
use Task\Storage\TaskExecutionRepositoryInterface;

/**
 * Executes given execution identified by uuid.
 */
class ExecuteCommand extends Command
{
    /**
     * @var TaskHandlerFactoryInterface
     */
    private $handlerFactory;

    /**
     * @var TaskExecutionRepositoryInterface
     */
    private $executionRepository;

    /**
     * @param string $name
     * @param TaskHandlerFactoryInterface $handlerFactory
     * @param TaskExecutionRepositoryInterface $executionRepository
     */
    public function __construct(
        $name,
        TaskHandlerFactoryInterface $handlerFactory,
        TaskExecutionRepositoryInterface $executionRepository
    ) {
        parent::__construct($name);

        $this->handlerFactory = $handlerFactory;
        $this->executionRepository = $executionRepository;
    }

    /**
     * {@inheritdoc}
     */
    protected function configure()
    {
        $this->addArgument('uuid', InputArgument::REQUIRED);
    }

    /**
     * {@inheritdoc}
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $errorOutput = $output instanceof ConsoleOutputInterface ? $output->getErrorOutput() : $output;

        $execution = $this->executionRepository->findByUuid($input->getArgument('uuid'));

It seems like $input->getArgument('uuid') targeting Symfony\Component\Console\Input\InputInterface::getArgument() can also be of type array<integer,string> or null; however, Task\Storage\TaskExecutionRepositoryInterface::findByUuid() does only seem to accept string, maybe add an additional type check?

        $handler = $this->handlerFactory->create($execution->getHandlerClass());

        try {
            $result = $handler->handle($execution->getWorkload());
        } catch (\Exception $exception) {
            if ($exception instanceof FailedException) {
                $errorOutput->writeln(FailedException::class);
                $exception = $exception->getPrevious();
            }

            $errorOutput->writeln($exception->__toString());

            // Process exit-code: 0 = OK, >1 = FAIL
            return 1;
        }

        $output->write($result);

It seems like $result defined by $handler->handle($execution->getWorkload()) on line 73 can also be of type object<Serializable>; however, Symfony\Component\Console\Output\OutputInterface::write() does only seem to accept string|object<Symfony\Component\Console\Output\iterable>, maybe add an additional type check?

        return 0;
    }

    /**
     * {@inheritdoc}
     */
    public function isHidden()
    {
        return true;
    }
}