Task\TaskBundle\Entity\TaskRepository

Complexity

Total Complexity

8

Size/Duplication

Total Lines	80
Duplicated Lines	15 %

Coupling/Cohesion

Components	2
Dependencies	5

Test Coverage

Coverage

72.41%

Importance

Changes	2
Bugs	0	Features	2

7 Methods

Rating	Name	Duplication	Size	Complexity
A	create()	0	4	1
A	findByUuid()	0	4	1
A	save()	0	7	1
A	remove()	0	7	1
A	findAll()	12	12	2
A	findEndBeforeNow()	0	4	1
A	findEndBefore()	0	8	1

<?php

/*
 * This file is part of php-task library.
 *
 * (c) php-task
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Task\TaskBundle\Entity;

use Doctrine\ORM\EntityRepository;
use Task\Storage\TaskRepositoryInterface;
use Task\TaskInterface;

/**
 * Repository for task.
 */
class TaskRepository extends EntityRepository implements TaskRepositoryInterface

There is at least one abstract method in this class. Maybe declare it as abstract, or implement the remaining methods: flush, persist

{
    /**
     * {@inheritdoc}
     */
    public function create($handlerClass, $workload = null)
    {
        return new Task($handlerClass, $workload);
    }

    /**
     * {@inheritdoc}
     */
    public function findByUuid($uuid)
    {
        return $this->find($uuid);
    }

    /**
     * {@inheritdoc}
     */
    public function save(TaskInterface $task)
    {
        $this->_em->persist($task);
        $this->_em->flush($task);

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function remove(TaskInterface $task)
    {
        $this->_em->remove($task);
        $this->_em->flush($task);

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function findAll($page = 1, $pageSize = null)

This method seems to be duplicated in your project.

    {
        $query = $this->createQueryBuilder('t')
            ->getQuery();

        if ($pageSize) {

The expression $pageSize of type integer|null is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

            $query->setMaxResults($pageSize);
            $query->setFirstResult(($page - 1) * $pageSize);
        }

        return $query->getResult();
    }

    /**
     * {@inheritdoc}
     */
    public function findEndBeforeNow()
    {
        return $this->findEndBefore(new \DateTime());
    }

    /**
     * Returns task where last-execution is before given date-time.
     *
     * @param \DateTime $dateTime
     *
     * @return TaskInterface[]
     */
    public function findEndBefore(\DateTime $dateTime)
    {
        return $this->createQueryBuilder('t')
            ->where('t.lastExecution IS NULL OR t.lastExecution > :dateTime')
            ->setParameter('dateTime', $dateTime)
            ->getQuery()
            ->getResult();
    }
}