Unit\Storage\DoctrineStorageTest

Complexity

Total Complexity

5

Size/Duplication

Total Lines	93
Duplicated Lines	15.05 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	4
Bugs	2	Features	3

3 Methods

Rating	Name	Duplication	Size	Complexity
A	storeDataProvider()	0	13	1
B	testStore()	7	32	2
B	testStoreTaskForKeyExists()	7	37	2

<?php

namespace Unit\Storage;

use Doctrine\ORM\EntityManagerInterface;
use Prophecy\Argument;
use Task\TaskBundle\Entity\Task as TaskEntity;
use Task\TaskBundle\Entity\TaskRepository;
use Task\TaskBundle\Storage\DoctrineStorage;
use Task\TaskInterface;

class DoctrineStorageTest extends \PHPUnit_Framework_TestCase
{
    public function storeDataProvider()
    {
        return [
            [new \DateTime(), true, '123-123-123'],
            [new \DateTime(), true, '123-123-123', 'test-key'],
            [new \DateTime(), true, '321-321-321'],
            [new \DateTime(), true, '321-321-321', 'test-key'],
            [new \DateTime('1 day ago'), true, '321-321-321'],
            [new \DateTime('1 day ago'), true, '321-321-321', 'test-key'],
            [new \DateTime(), false, '123-123-123'],
            [new \DateTime(), false, '123-123-123', 'test-key'],
        ];
    }

    /**
     * @dataProvider storeDataProvider
     */
    public function testStore($date, $completed, $uuid, $key = null)
    {
        $entityManager = $this->prophesize(EntityManagerInterface::class);
        $repository = $this->prophesize(TaskRepository::class);

        $storage = new DoctrineStorage($entityManager->reveal(), $repository->reveal());

        $task = $this->prophesize(TaskInterface::class);
        $task->getUuid()->willReturn($uuid);
        $task->getKey()->willReturn($key);
        $task->isCompleted()->willReturn($completed);
        $task->getExecutionDate()->willReturn($date);

        if ($key) {
            $repository->findOneBy(['key' => $key, 'completed' => false])->willReturn(null)->shouldBeCalledTimes(1);
        }

        $storage->store($task->reveal());

        $entityManager->persist(
            Argument::that(
                function (TaskEntity $entity) use ($date, $completed, $uuid) {

This code seems to be duplicated across your project.

                    $this->assertEquals($uuid, $entity->getUuid());
                    $this->assertEquals($completed, $entity->isCompleted());
                    $this->assertEquals($date, $entity->getExecutionDate());

                    return true;
                }
            )
        )->shouldBeCalledTimes(1);
        $entityManager->flush()->shouldBeCalledTimes(1);
    }

    /**
     * @dataProvider storeDataProvider
     */
    public function testStoreTaskForKeyExists($date, $completed, $uuid, $key = null)
    {
        $entityManager = $this->prophesize(EntityManagerInterface::class);
        $repository = $this->prophesize(TaskRepository::class);

        $storage = new DoctrineStorage($entityManager->reveal(), $repository->reveal());

        $task = $this->prophesize(TaskInterface::class);
        $task->getUuid()->willReturn($uuid);
        $task->getKey()->willReturn($key);
        $task->isCompleted()->willReturn($completed);
        $task->getExecutionDate()->willReturn($date);

        if ($key) {
            $oldTask = $this->prophesize(TaskInterface::class);

            $repository->findOneBy(['key' => $key, 'completed' => false])->willReturn($oldTask)->shouldBeCalledTimes(1);

            $entityManager->persist(Argument::any())->shouldNotBeCalled();
            $entityManager->flush()->shouldNotBeCalled();
        } else {
            $entityManager->persist(
                Argument::that(
                    function (TaskEntity $entity) use ($date, $completed, $uuid) {

This code seems to be duplicated across your project.

                        $this->assertEquals($uuid, $entity->getUuid());
                        $this->assertEquals($completed, $entity->isCompleted());
                        $this->assertEquals($date, $entity->getExecutionDate());

                        return true;
                    }
                )
            )->shouldBeCalledTimes(1);
            $entityManager->flush()->shouldBeCalledTimes(1);
        }

        $storage->store($task->reveal());
    }
}