TaskExecutionRepositoryTest::testSave() - Code Metrics - Inspection of "Fixed query to find pending executions" - php-task/TaskBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#36)

by Wachter

created 2017-02-27 12:28 UTC

TaskExecutionRepositoryTest::testSave() A

↳ Parent: TaskExecutionRepositoryTest

Complexity

Conditions	3
Paths	4

Size

Total Lines	23
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
c	1
b	1
f	0
dl	0
loc	23
rs	9.0856
cc	3
eloc	14
nc	4
nop	3

<?php

namespace Task\TaskBundle\Tests\Functional\Command;

use Doctrine\Common\DataFixtures\Executor\ORMExecutor;
use Doctrine\Common\DataFixtures\ProxyReferenceRepository;
use Doctrine\Common\DataFixtures\Purger\ORMPurger;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Task\Storage\TaskExecutionRepositoryInterface;
use Task\TaskBundle\Entity\Task;
use Task\TaskBundle\Entity\TaskExecution;
use Task\TaskBundle\Tests\Functional\TestHandler;
use Task\TaskStatus;

/**
 * Tests for TaskExecutionRepository.
 */
class TaskExecutionRepositoryTest extends KernelTestCase
{
    /**
     * @var TaskExecutionRepositoryInterface
     */
    protected $taskExecutionRepository;

    /**
     * @var TaskExecutionRepositoryInterface
     */
    protected $taskRepository;

    public function setUp()
    {
        self::bootKernel();

        $this->purgeDatabase();

        $this->taskExecutionRepository = self::$kernel->getContainer()->get('task.storage.task_execution');
        $this->taskRepository = self::$kernel->getContainer()->get('task.storage.task');
    }

    public function testSave(Task $task = null, \DateTime $scheduleTime = null, $status = TaskStatus::PLANNED)
    {
        if (!$scheduleTime) {
            $scheduleTime = new \DateTime();
        }

        if (!$task) {
            $task = $this->createTask();
            $this->taskRepository->save($task);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        $execution = $this->createTaskExecution($task, $scheduleTime, $status);
        $this->taskExecutionRepository->save($execution);

        $result = $this->taskExecutionRepository->findByUuid($execution->getUuid());

        $this->assertEquals($execution->getUuid(), $result->getUuid());
        $this->assertEquals($scheduleTime, $result->getScheduleTime());
        $this->assertEquals($status, $result->getStatus());
        $this->assertEquals($task->getUuid(), $result->getTask()->getUuid());

        return $execution;
    }

    public function testRemove()
    {
        $execution = $this->testSave();

        $this->taskExecutionRepository->remove($execution);

        $this->assertNull($this->taskExecutionRepository->findByUuid($execution->getUuid()));
    }

    public function testFindAll()
    {
        $task = $this->createTask();
        $this->taskRepository->save($task);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $executions = [];
        for ($i = 0; $i < 3; ++$i) {

            $execution = $this->testSave($task);
            $executions[$execution->getUuid()] = $execution;
        }

        $result = $this->taskExecutionRepository->findAll();

        $this->assertCount(3, $result);
        foreach ($result as $item) {
            $this->assertArrayHasKey($item->getUuid(), $executions);
            unset($executions[$item->getUuid()]);
        }
    }

    public function testFindAllPaginated()
    {
        $task = $this->createTask();
        $this->taskRepository->save($task);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $executions = [];
        for ($i = 0; $i < 3; ++$i) {

            $execution = $this->testSave($task);
            $executions[$execution->getUuid()] = $execution;
        }

        $result = $this->taskExecutionRepository->findAll(1, 2);

        $this->assertCount(2, $result);
        foreach ($result as $item) {
            $this->assertArrayHasKey($item->getUuid(), $executions);
            unset($executions[$item->getUuid()]);
        }

        $result = $this->taskExecutionRepository->findAll(2, 2);

        $this->assertCount(1, $result);
        foreach ($result as $item) {
            $this->assertArrayHasKey($item->getUuid(), $executions);
            unset($executions[$item->getUuid()]);
        }

        $this->assertEmpty($executions);
    }

    public function testFindPending()
    {
        $execution = $this->testSave();
        $this->assertNotNull($this->taskExecutionRepository->findPending($execution->getTask()));

        $execution = $this->testSave(null, null, TaskStatus::RUNNING);
        $this->assertNotNull($this->taskExecutionRepository->findPending($execution->getTask()));

        $execution = $this->testSave(null, null, TaskStatus::COMPLETED);
        $this->assertNull($this->taskExecutionRepository->findPending($execution->getTask()));

        $execution = $this->testSave(null, null, TaskStatus::FAILED);
        $this->assertNull($this->taskExecutionRepository->findPending($execution->getTask()));
    }

    public function testFindByUuid()
    {
        $execution = $this->testSave();

        $result = $this->taskExecutionRepository->findByUuid($execution->getUuid());
        $this->assertEquals($execution->getUuid(), $result->getUuid());
    }

    public function testFindByTask()

    {
        $execution = $this->testSave();

        $result = $this->taskExecutionRepository->findByTask($execution->getTask());

        $this->assertCount(1, $result);
        $this->assertEquals($execution->getTask()->getUuid(), $result[0]->getTask()->getUuid());
    }

    public function testFindByTaskUuid()

    {
        $execution = $this->testSave();

        $result = $this->taskExecutionRepository->findByTaskUuid($execution->getTask()->getUuid());

        $this->assertCount(1, $result);
        $this->assertEquals($execution->getTask()->getUuid(), $result[0]->getTask()->getUuid());
    }

    public function testFindScheduledPast()
    {
        $task = $this->createTask();
        $this->taskRepository->save($task);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $execution = $this->testSave($task, new \DateTime('-1 hour'));

        $result = $this->taskExecutionRepository->findScheduled();

        $this->assertCount(1, $result);
        $this->assertEquals($execution->getUuid(), $result[0]->getUuid());
    }

    public function testFindScheduledFuture()
    {
        $task = $this->createTask();
        $this->taskRepository->save($task);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $this->testSave($task, new \DateTime('+1 hour'));

        $this->assertEmpty($this->taskExecutionRepository->findScheduled());
    }

    private function createTask($handlerClass = TestHandler::class)
    {
        return new Task($handlerClass);
    }

    private function createTaskExecution(Task $task, \DateTime $scheduleTime, $status = TaskStatus::PLANNED)
    {
        $execution = new TaskExecution($task, $task->getHandlerClass(), $scheduleTime);
        $execution->setStatus($status);

        return $execution;
    }

    protected function purgeDatabase()

    {
        $manager = self::$kernel->getContainer()->get('doctrine.orm.entity_manager');
        $connection = $manager->getConnection();

        if ($connection->getDriver() instanceof \Doctrine\DBAL\Driver\PDOMySql\Driver) {
            $connection->executeUpdate('SET foreign_key_checks = 0;');
        }

        $purger = new ORMPurger();
        $executor = new ORMExecutor($manager, $purger);
        $referenceRepository = new ProxyReferenceRepository($manager);
        $executor->setReferenceRepository($referenceRepository);
        $executor->purge();

        if ($connection->getDriver() instanceof \Doctrine\DBAL\Driver\PDOMySql\Driver) {
            $connection->executeUpdate('SET foreign_key_checks = 1;');
        }
    }
}


1		<?php
2
3		namespace Task\TaskBundle\Tests\Functional\Command;
4
5		use Doctrine\Common\DataFixtures\Executor\ORMExecutor;
6		use Doctrine\Common\DataFixtures\ProxyReferenceRepository;
7		use Doctrine\Common\DataFixtures\Purger\ORMPurger;
8		use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
9		use Task\Storage\TaskExecutionRepositoryInterface;
10		use Task\TaskBundle\Entity\Task;
11		use Task\TaskBundle\Entity\TaskExecution;
12		use Task\TaskBundle\Tests\Functional\TestHandler;
13		use Task\TaskStatus;
14
15		/**
16		* Tests for TaskExecutionRepository.
17		*/
18		class TaskExecutionRepositoryTest extends KernelTestCase
19		{
20		/**
21		* @var TaskExecutionRepositoryInterface
22		*/
23		protected $taskExecutionRepository;
24
25		/**
26		* @var TaskExecutionRepositoryInterface
27		*/
28		protected $taskRepository;
29
30		public function setUp()
31		{
32		self::bootKernel();
33
34		$this->purgeDatabase();
35
36		$this->taskExecutionRepository = self::$kernel->getContainer()->get('task.storage.task_execution');
37		$this->taskRepository = self::$kernel->getContainer()->get('task.storage.task');
38		}
39
40		public function testSave(Task $task = null, \DateTime $scheduleTime = null, $status = TaskStatus::PLANNED)
41		{
42		if (!$scheduleTime) {
43		$scheduleTime = new \DateTime();
44		}
45
46		if (!$task) {
47		$task = $this->createTask();
48		$this->taskRepository->save($task);
		0 ignored issues – show Documentation introduced 2017-02-27 12:32 UTC by Report Bug Copy Issue Report `$task` is of type `object<Task\TaskBundle\Entity\Task>`, but the function expects a `object<Task\Execution\TaskExecutionInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
49		}
50
51		$execution = $this->createTaskExecution($task, $scheduleTime, $status);
52		$this->taskExecutionRepository->save($execution);
53
54		$result = $this->taskExecutionRepository->findByUuid($execution->getUuid());
55
56		$this->assertEquals($execution->getUuid(), $result->getUuid());
57		$this->assertEquals($scheduleTime, $result->getScheduleTime());
58		$this->assertEquals($status, $result->getStatus());
59		$this->assertEquals($task->getUuid(), $result->getTask()->getUuid());
60
61		return $execution;
62		}
63
64		public function testRemove()
65		{
66		$execution = $this->testSave();
67
68		$this->taskExecutionRepository->remove($execution);
69
70		$this->assertNull($this->taskExecutionRepository->findByUuid($execution->getUuid()));
71		}
72
73		public function testFindAll()
74		{
75		$task = $this->createTask();
76		$this->taskRepository->save($task);
		0 ignored issues – show Documentation introduced 2017-02-27 12:32 UTC by Report Bug Copy Issue Report `$task` is of type `object<Task\TaskBundle\Entity\Task>`, but the function expects a `object<Task\Execution\TaskExecutionInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
77
78		$executions = [];
79	View Code Duplication	for ($i = 0; $i < 3; ++$i) {
		0 ignored issues – show Duplication introduced 2017-02-27 12:32 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
80		$execution = $this->testSave($task);
81		$executions[$execution->getUuid()] = $execution;
82		}
83
84		$result = $this->taskExecutionRepository->findAll();
85
86		$this->assertCount(3, $result);
87		foreach ($result as $item) {
88		$this->assertArrayHasKey($item->getUuid(), $executions);
89		unset($executions[$item->getUuid()]);
90		}
91		}
92
93		public function testFindAllPaginated()
94		{
95		$task = $this->createTask();
96		$this->taskRepository->save($task);
		0 ignored issues – show Documentation introduced 2017-02-27 12:32 UTC by Report Bug Copy Issue Report `$task` is of type `object<Task\TaskBundle\Entity\Task>`, but the function expects a `object<Task\Execution\TaskExecutionInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
97
98		$executions = [];
99	View Code Duplication	for ($i = 0; $i < 3; ++$i) {
		0 ignored issues – show Duplication introduced 2017-02-27 12:32 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
100		$execution = $this->testSave($task);
101		$executions[$execution->getUuid()] = $execution;
102		}
103
104		$result = $this->taskExecutionRepository->findAll(1, 2);
105
106		$this->assertCount(2, $result);
107		foreach ($result as $item) {
108		$this->assertArrayHasKey($item->getUuid(), $executions);
109		unset($executions[$item->getUuid()]);
110		}
111
112		$result = $this->taskExecutionRepository->findAll(2, 2);
113
114		$this->assertCount(1, $result);
115		foreach ($result as $item) {
116		$this->assertArrayHasKey($item->getUuid(), $executions);
117		unset($executions[$item->getUuid()]);
118		}
119
120		$this->assertEmpty($executions);
121		}
122
123		public function testFindPending()
124		{
125		$execution = $this->testSave();
126		$this->assertNotNull($this->taskExecutionRepository->findPending($execution->getTask()));
127
128		$execution = $this->testSave(null, null, TaskStatus::RUNNING);
129		$this->assertNotNull($this->taskExecutionRepository->findPending($execution->getTask()));
130
131		$execution = $this->testSave(null, null, TaskStatus::COMPLETED);
132		$this->assertNull($this->taskExecutionRepository->findPending($execution->getTask()));
133
134		$execution = $this->testSave(null, null, TaskStatus::FAILED);
135		$this->assertNull($this->taskExecutionRepository->findPending($execution->getTask()));
136		}
137
138		public function testFindByUuid()
139		{
140		$execution = $this->testSave();
141
142		$result = $this->taskExecutionRepository->findByUuid($execution->getUuid());
143		$this->assertEquals($execution->getUuid(), $result->getUuid());
144		}
145
146	View Code Duplication	public function testFindByTask()
		0 ignored issues – show Duplication introduced 2017-02-27 09:41 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
147		{
148		$execution = $this->testSave();
149
150		$result = $this->taskExecutionRepository->findByTask($execution->getTask());
151
152		$this->assertCount(1, $result);
153		$this->assertEquals($execution->getTask()->getUuid(), $result[0]->getTask()->getUuid());
154		}
155
156	View Code Duplication	public function testFindByTaskUuid()
		0 ignored issues – show Duplication introduced 2017-02-27 09:41 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
157		{
158		$execution = $this->testSave();
159
160		$result = $this->taskExecutionRepository->findByTaskUuid($execution->getTask()->getUuid());
161
162		$this->assertCount(1, $result);
163		$this->assertEquals($execution->getTask()->getUuid(), $result[0]->getTask()->getUuid());
164		}
165
166		public function testFindScheduledPast()
167		{
168		$task = $this->createTask();
169		$this->taskRepository->save($task);
		0 ignored issues – show Documentation introduced 2017-02-27 12:32 UTC by Report Bug Copy Issue Report `$task` is of type `object<Task\TaskBundle\Entity\Task>`, but the function expects a `object<Task\Execution\TaskExecutionInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
170
171		$execution = $this->testSave($task, new \DateTime('-1 hour'));
172
173		$result = $this->taskExecutionRepository->findScheduled();
174
175		$this->assertCount(1, $result);
176		$this->assertEquals($execution->getUuid(), $result[0]->getUuid());
177		}
178
179		public function testFindScheduledFuture()
180		{
181		$task = $this->createTask();
182		$this->taskRepository->save($task);
		0 ignored issues – show Documentation introduced 2017-02-27 12:32 UTC by Report Bug Copy Issue Report `$task` is of type `object<Task\TaskBundle\Entity\Task>`, but the function expects a `object<Task\Execution\TaskExecutionInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
183
184		$this->testSave($task, new \DateTime('+1 hour'));
185
186		$this->assertEmpty($this->taskExecutionRepository->findScheduled());
187		}
188
189		private function createTask($handlerClass = TestHandler::class)
190		{
191		return new Task($handlerClass);
192		}
193
194		private function createTaskExecution(Task $task, \DateTime $scheduleTime, $status = TaskStatus::PLANNED)
195		{
196		$execution = new TaskExecution($task, $task->getHandlerClass(), $scheduleTime);
197		$execution->setStatus($status);
198
199		return $execution;
200		}
201
202	View Code Duplication	protected function purgeDatabase()
		0 ignored issues – show Duplication introduced 2017-02-27 12:32 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
203		{
204		$manager = self::$kernel->getContainer()->get('doctrine.orm.entity_manager');
205		$connection = $manager->getConnection();
206
207		if ($connection->getDriver() instanceof \Doctrine\DBAL\Driver\PDOMySql\Driver) {
208		$connection->executeUpdate('SET foreign_key_checks = 0;');
209		}
210
211		$purger = new ORMPurger();
212		$executor = new ORMExecutor($manager, $purger);
213		$referenceRepository = new ProxyReferenceRepository($manager);
214		$executor->setReferenceRepository($referenceRepository);
215		$executor->purge();
216
217		if ($connection->getDriver() instanceof \Doctrine\DBAL\Driver\PDOMySql\Driver) {
218		$connection->executeUpdate('SET foreign_key_checks = 1;');
219		}
220		}
221		}
222

php-task / TaskBundle

Pull Request — master (#36)

TaskExecutionRepositoryTest::testSave() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like