Task - Code Metrics - Inspection of "Improved architecture of bundle" - php-task/TaskBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#15)

by Wachter

created 2016-08-29 17:36 UTC

Task A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

50%

Importance

Changes	6
Bugs	2	Features	4

Metric	Value
wmc	6
c	6
b	2
f	4
lcom	1
cbo	2
dl	0
loc	47
ccs	2
cts	4
cp	0.5
rs	10

4 Methods

Rating	Name	Size	Complexity
A	getId()	4	1
A	getIntervalExpression()	4	1
A	getInterval()	8	3
A	setInterval()	6	1

<?php

namespace Task\TaskBundle\Entity;

use Cron\CronExpression;
use Task\Task as BaseTask;

class Task extends BaseTask
{
    /**
     * @var int
     */
    private $id;

    /**
     * @var string
     */
    private $intervalExpression;

    /**
     * @return int
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * @return mixed
     */
    public function getIntervalExpression()
    {
        return $this->intervalExpression;
    }

    public function getInterval()
    {
        if (null === $this->interval && null !== $this->intervalExpression) {

            $this->interval = CronExpression::factory($this->intervalExpression);

        }

        return parent::getInterval();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    /**
     * {@inheritdoc}
     */
    public function setInterval(CronExpression $interval, \DateTime $firstExecution = null, \DateTime $lastExecution = null)
    {
        parent::setInterval($interval, $firstExecution, $lastExecution);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        $this->intervalExpression = $interval->getExpression();
    }
}


1		<?php
2
3		namespace Task\TaskBundle\Entity;
4
5		use Cron\CronExpression;
6		use Task\Task as BaseTask;
7
8		class Task extends BaseTask
9		{
10		/**
11		* @var int
12		*/
13		private $id;
14
15		/**
16		* @var string
17		*/
18		private $intervalExpression;
19
20		/**
21		* @return int
22		*/
23		public function getId()
24		{
25		return $this->id;
26		}
27
28		/**
29		* @return mixed
30		*/
31		public function getIntervalExpression()
32		{
33		return $this->intervalExpression;
34		}
35
36		public function getInterval()
37		{
38		if (null === $this->interval && null !== $this->intervalExpression) {
		0 ignored issues – show Bug introduced 2016-08-29 17:50 UTC by Report Bug Copy Issue Report The property `interval` does not seem to exist. Did you mean `intervalExpression`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
39		$this->interval = CronExpression::factory($this->intervalExpression);
		0 ignored issues – show Bug introduced 2016-08-29 17:50 UTC by Report Bug Copy Issue Report The property `interval` does not seem to exist. Did you mean `intervalExpression`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
40		}
41
42		return parent::getInterval();
		0 ignored issues – show Bug introduced 2016-08-29 17:50 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Task\Task` as the method `getInterval()` does only exist in the following sub-classes of `Task\Task`: `Task\TaskBundle\Entity\Task`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
43		}
44
45		/**
46		* {@inheritdoc}
47		*/
48		public function setInterval(CronExpression $interval, \DateTime $firstExecution = null, \DateTime $lastExecution = null)
49		{
50	72	parent::setInterval($interval, $firstExecution, $lastExecution);
		0 ignored issues – show Bug introduced 2016-02-28 09:40 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Task\Task` as the method `setInterval()` does only exist in the following sub-classes of `Task\Task`: `Task\TaskBundle\Entity\Task`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
51
52	72	$this->intervalExpression = $interval->getExpression();
53		}
54		}
55

php-task / TaskBundle

Pull Request — master (#15)

Task A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like