TaskExecutionRepository::findByTask() - Code Metrics - Inspection of "added find-by-task-uuid function (#30)" - php-task/TaskBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( aa6f67...8d8046 )

by Wachter

created 2016-11-29 10:50 UTC

TaskExecutionRepository::findByTask() A

↳ Parent: TaskExecutionRepository

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
cc	1
eloc	2
nc	1
nop	1
crap	1

<?php

/*
 * This file is part of php-task library.
 *
 * (c) php-task
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Task\TaskBundle\Entity;

use Doctrine\ORM\EntityRepository;
use Doctrine\ORM\NoResultException;
use Task\Execution\TaskExecutionInterface;
use Task\Storage\TaskExecutionRepositoryInterface;
use Task\TaskInterface;
use Task\TaskStatus;

/**
 * Repository for task-execution.
 */
class TaskExecutionRepository extends EntityRepository implements TaskExecutionRepositoryInterface

{
    /**
     * {@inheritdoc}
     */
    public function create(TaskInterface $task, \DateTime $scheduleTime)
    {
        return new TaskExecution($task, $task->getHandlerClass(), $scheduleTime, $task->getWorkload());
    }

    /**
     * {@inheritdoc}
     */
    public function save(TaskExecutionInterface $execution)
    {
        $this->_em->persist($execution);
        $this->_em->flush($execution);

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function remove(TaskExecutionInterface $execution)
    {
        $this->_em->remove($execution);
        $this->_em->flush($execution);

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function findAll($page = 1, $pageSize = null)

    {
        $query = $this->createQueryBuilder('e')
            ->innerJoin('e.task', 't')
            ->getQuery();

        if ($pageSize) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            $query->setMaxResults($pageSize);
            $query->setFirstResult(($page - 1) * $pageSize);
        }

        return $query->getResult();
    }

    /**
     * {@inheritdoc}
     */
    public function findPending(TaskInterface $task)
    {
        try {
            return $this->createQueryBuilder('e')
                ->innerJoin('e.task', 't')
                ->where('t.uuid = :uuid')
                ->andWhere('e.status in (:status)')
                ->setParameter('uuid', $task->getUuid())
                ->setParameter('status', [TaskStatus::PLANNED, TaskStatus::RUNNING])
                ->getQuery()
                ->getSingleResult();
        } catch (NoResultException $e) {
            return;
        }
    }

    /**
     * {@inheritdoc}
     */
    public function findByTask(TaskInterface $task)
    {
        return $this->findByTaskUuid($task->getUuid());
    }

    /**
     * {@inheritdoc}
     */
    public function findByTaskUuid($taskUuid)
    {
        return $this->createQueryBuilder('e')
            ->innerJoin('e.task', 't')
            ->where('t.uuid = :uuid')
            ->setParameter('uuid', $taskUuid)
            ->getQuery()
            ->getResult();
    }

    /**
     * {@inheritdoc}
     */
    public function findScheduled(\DateTime $dateTime = null)
    {
        if ($dateTime === null) {
            $dateTime = new \DateTime();
        }

        return $this->createQueryBuilder('e')
            ->innerJoin('e.task', 't')
            ->where('e.status = :status AND e.scheduleTime < :dateTime')
            ->setParameter('status', TaskStatus::PLANNED)
            ->setParameter('dateTime', $dateTime)
            ->getQuery()
            ->getResult();
    }
}


1			<?php
2
3			/*
4			* This file is part of php-task library.
5			*
6			* (c) php-task
7			*
8			* This source file is subject to the MIT license that is bundled
9			* with this source code in the file LICENSE.
10			*/
11
12			namespace Task\TaskBundle\Entity;
13
14			use Doctrine\ORM\EntityRepository;
15			use Doctrine\ORM\NoResultException;
16			use Task\Execution\TaskExecutionInterface;
17			use Task\Storage\TaskExecutionRepositoryInterface;
18			use Task\TaskInterface;
19			use Task\TaskStatus;
20
21			/**
22			* Repository for task-execution.
23			*/
24			class TaskExecutionRepository extends EntityRepository implements TaskExecutionRepositoryInterface
			0 ignored issues – show Bug introduced 2016-11-24 18:07 UTC by Report Bug Copy Issue Report There is at least one abstract method in this class. Maybe declare it as abstract, or implement the remaining methods: findByStartTime, flush, persist Loading history...
25			{
26			/**
27			* {@inheritdoc}
28			*/
29	9		public function create(TaskInterface $task, \DateTime $scheduleTime)
30			{
31	9		return new TaskExecution($task, $task->getHandlerClass(), $scheduleTime, $task->getWorkload());
32			}
33
34			/**
35			* {@inheritdoc}
36			*/
37	9		public function save(TaskExecutionInterface $execution)
38			{
39	9		$this->_em->persist($execution);
40	9		$this->_em->flush($execution);
41
42	9		return $this;
43			}
44
45			/**
46			* {@inheritdoc}
47			*/
48			public function remove(TaskExecutionInterface $execution)
49			{
50			$this->_em->remove($execution);
51			$this->_em->flush($execution);
52
53			return $this;
54			}
55
56			/**
57			* {@inheritdoc}
58			*/
59	6	View Code Duplication	public function findAll($page = 1, $pageSize = null)
			0 ignored issues – show Duplication introduced 2016-10-09 08:47 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
60			{
61	6		$query = $this->createQueryBuilder('e')
62	6		->innerJoin('e.task', 't')
63	6		->getQuery();
64
65	6		if ($pageSize) {
			0 ignored issues – show Bug Best Practice introduced 2016-10-10 18:11 UTC by Report Bug Copy Issue Report The expression `$pageSize` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be zero. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
66	3		$query->setMaxResults($pageSize);
67	3		$query->setFirstResult(($page - 1) * $pageSize);
68	3		}
69
70	6		return $query->getResult();
71			}
72
73			/**
74			* {@inheritdoc}
75			*/
76	7		public function findPending(TaskInterface $task)
77			{
78			try {
79	7		return $this->createQueryBuilder('e')
80	7		->innerJoin('e.task', 't')
81	7		->where('t.uuid = :uuid')
82	7		->andWhere('e.status in (:status)')
83	7		->setParameter('uuid', $task->getUuid())
84	7		->setParameter('status', [TaskStatus::PLANNED, TaskStatus::RUNNING])
85	7		->getQuery()
86	7		->getSingleResult();
87	7		} catch (NoResultException $e) {
88	7		return;
89			}
90			}
91
92			/**
93			* {@inheritdoc}
94			*/
95	3		public function findByTask(TaskInterface $task)
96			{
97	3		return $this->findByTaskUuid($task->getUuid());
98			}
99
100			/**
101			* {@inheritdoc}
102			*/
103	3		public function findByTaskUuid($taskUuid)
104			{
105	3		return $this->createQueryBuilder('e')
106	3		->innerJoin('e.task', 't')
107	3		->where('t.uuid = :uuid')
108	3		->setParameter('uuid', $taskUuid)
109	3		->getQuery()
110	3		->getResult();
111			}
112
113			/**
114			* {@inheritdoc}
115			*/
116	2		public function findScheduled(\DateTime $dateTime = null)
117			{
118	2		if ($dateTime === null) {
119	2		$dateTime = new \DateTime();
120	2		}
121
122	2		return $this->createQueryBuilder('e')
123	2		->innerJoin('e.task', 't')
124	2		->where('e.status = :status AND e.scheduleTime < :dateTime')
125	2		->setParameter('status', TaskStatus::PLANNED)
126	2		->setParameter('dateTime', $dateTime)
127	2		->getQuery()
128	2		->getResult();
129			}
130			}
131

php-task / TaskBundle

Push — master ( aa6f67...8d8046 )

TaskExecutionRepository::findByTask() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like