TaskHandlerFactory - Code Metrics - Inspection of "improved architecture of bundle (#15)" - php-task/TaskBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2c1a94...065363 )

by Wachter

created 2016-08-30 16:53 UTC

TaskHandlerFactory A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	3
c	1
b	0
f	0
lcom	1
cbo	1
dl	0
loc	27
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	create()	0	8	2

<?php

/*
 * This file is part of php-task library.
 *
 * (c) php-task
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Task\TaskBundle\Handler;

use Symfony\Component\CssSelector\Parser\Handler\HandlerInterface;
use Task\Handler\TaskHandlerFactoryInterface;
use Task\Handler\TaskHandlerNotExistsException;

/**
 * Uses symfony container for collecting handler.
 */
class TaskHandlerFactory implements TaskHandlerFactoryInterface
{
    /**
     * @var HandlerInterface[]
     */
    private $handler = [];

    /**
     * @param array $handler
     */
    public function __construct(array $handler)
    {
        $this->handler = $handler;
    }

    /**
     * {@inheritdoc}
     */
    public function create($className)
    {
        if (!array_key_exists($className, $this->handler)) {
            throw new TaskHandlerNotExistsException($className);
        }

        return $this->handler[$className];
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
}


1			<?php
2
3			/*
4			* This file is part of php-task library.
5			*
6			* (c) php-task
7			*
8			* This source file is subject to the MIT license that is bundled
9			* with this source code in the file LICENSE.
10			*/
11
12			namespace Task\TaskBundle\Handler;
13
14			use Symfony\Component\CssSelector\Parser\Handler\HandlerInterface;
15			use Task\Handler\TaskHandlerFactoryInterface;
16			use Task\Handler\TaskHandlerNotExistsException;
17
18			/**
19			* Uses symfony container for collecting handler.
20			*/
21			class TaskHandlerFactory implements TaskHandlerFactoryInterface
22			{
23			/**
24			* @var HandlerInterface[]
25			*/
26			private $handler = [];
27
28			/**
29			* @param array $handler
30			*/
31			public function __construct(array $handler)
32			{
33			$this->handler = $handler;
34			}
35
36			/**
37			* {@inheritdoc}
38			*/
39			public function create($className)
40			{
41			if (!array_key_exists($className, $this->handler)) {
42			throw new TaskHandlerNotExistsException($className);
43			}
44
45			return $this->handler[$className];
			0 ignored issues – show Bug Best Practice introduced 2016-08-29 19:20 UTC by Report Bug Copy Issue Report The return type of `return $this->handler[$className];` (`Symfony\Component\CssSel...andler\HandlerInterface`) is incompatible with the return type declared by the interface `Task\Handler\TaskHandlerFactoryInterface::create` of type `Task\Handler\TaskHandlerInterface`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
46			}
47			}
48

php-task / TaskBundle

Push — master ( 2c1a94...065363 )

TaskHandlerFactory A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like