Task\TaskBundle\Factory

Complexity

Total Complexity

2

Size/Duplication

Total Lines	18
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	createTask()	0	4	1
A	createTaskExecution()	0	4	1

<?php

/*
 * This file is part of php-task library.
 *
 * (c) php-task
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Task\TaskBundle;

use Task\TaskBundle\Entity\Task;
use Task\TaskBundle\Entity\TaskExecution;
use Task\TaskInterface;

/**
 * Factory which returns doctrine entities for tasks and task-execution.
 */
class Factory extends \Task\Factory
{
    /**
     * {@inheritdoc}
     */
    public function createTask($handlerClass, $workload)
    {
        return new Task($handlerClass, $workload);

It seems like $workload defined by parameter $workload on line 26 can also be of type object<Serializable>; however, Task\Task::__construct() does only seem to accept string|null, maybe add an additional type check?

    }

    /**
     * {@inheritdoc}
     */
    public function createTaskExecution(TaskInterface $task, \DateTime $scheduleTime)
    {
        return new TaskExecution($task, $task->getHandlerClass(), $scheduleTime, $task->getWorkload());

It seems like $task->getWorkload() targeting Task\TaskInterface::getWorkload() can also be of type object<Serializable>; however, Task\Execution\TaskExecution::__construct() does only seem to accept string|null, maybe add an additional type check?

    }
}