Task\TaskBundle\Entity\TaskExecutionRepository

Complexity

Total Complexity

10

Size/Duplication

Total Lines	97
Duplicated Lines	13.4 %

Coupling/Cohesion

Components	2
Dependencies	5

Test Coverage

Coverage

76.19%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	create()	0	4	1
A	remove()	0	6	1
A	save()	0	6	1
A	findAll()	13	13	2
A	findByStartTime()	0	15	2
A	findByTask()	0	9	1
A	findScheduled()	0	14	2

<?php

/*
 * This file is part of php-task library.
 *
 * (c) php-task
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Task\TaskBundle\Entity;

use Doctrine\ORM\EntityRepository;
use Doctrine\ORM\NoResultException;
use Task\Execution\TaskExecutionInterface;
use Task\Storage\TaskExecutionRepositoryInterface;
use Task\TaskInterface;
use Task\TaskStatus;

/**
 * Repository for task-execution.
 */
class TaskExecutionRepository extends EntityRepository implements TaskExecutionRepositoryInterface

There is at least one abstract method in this class. Maybe declare it as abstract, or implement the remaining methods: flush, persist

{
    /**
     * {@inheritdoc}
     */
    public function create(TaskInterface $task, \DateTime $scheduleTime)
    {
        return new TaskExecution($task, $task->getHandlerClass(), $scheduleTime, $task->getWorkload());
    }

    /**
     * {@inheritdoc}
     */
    public function save(TaskExecutionInterface $execution)
    {
        $this->_em->persist($execution);

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function remove(TaskExecutionInterface $execution)
    {
        $this->_em->remove($execution);

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function findAll($page = 1, $pageSize = null)

This method seems to be duplicated in your project.

    {
        $query = $this->createQueryBuilder('e')
            ->innerJoin('e.task', 't')
            ->getQuery();

        if ($pageSize) {

The expression $pageSize of type integer|null is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

            $query->setMaxResults($pageSize);
            $query->setFirstResult(($page - 1) * $pageSize);
        }

        return $query->getResult();
    }

    /**
     * {@inheritdoc}
     */
    public function findByStartTime(TaskInterface $task, \DateTime $scheduleTime)
    {
        try {
            return $this->createQueryBuilder('e')
                ->innerJoin('e.task', 't')
                ->where('t.uuid = :uuid')
                ->andWhere('e.scheduleTime = :scheduleTime')
                ->setParameter('uuid', $task->getUuid())
                ->setParameter('scheduleTime', $scheduleTime)
                ->getQuery()
                ->getSingleResult();
        } catch (NoResultException $e) {
            return;
        }
    }

    /**
     * {@inheritdoc}
     */
    public function findByTask(TaskInterface $task)
    {
        return $this->createQueryBuilder('e')
            ->innerJoin('e.task', 't')
            ->where('t.uuid = :uuid')
            ->setParameter('uuid', $task->getUuid())
            ->getQuery()
            ->getResult();
    }

    /**
     * {@inheritdoc}
     */
    public function findScheduled(\DateTime $dateTime = null)
    {
        if ($dateTime === null) {
            $dateTime = new \DateTime();
        }

        return $this->createQueryBuilder('e')
            ->innerJoin('e.task', 't')
            ->where('e.status = :status AND e.scheduleTime < :dateTime')
            ->setParameter('status', TaskStatus::PLANNED)
            ->setParameter('dateTime', $dateTime)
            ->getQuery()
            ->getResult();
    }
}