ResourceInputStream::read() - Code Metrics - Inspection of "Move the blocking check to the read method." - php-school/terminal - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#17)

unknown

created 2023-01-16 15:52 UTC

ResourceInputStream::read() A

↳ Parent: ResourceInputStream

Complexity

Conditions	5
Paths	4

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
eloc	7
c	3
b	0
f	0
dl	0
loc	12
rs	9.6111
cc	5
nc	4
nop	2

<?php

namespace PhpSchool\Terminal\IO;

use function is_resource;
use function get_resource_type;
use function stream_get_meta_data;
use function strpos;

/**
 * @author Aydin Hassan <[email protected]>
 */
class ResourceInputStream implements InputStream
{
    /**
     * @var resource
     */
    private $stream;

    public function __construct($stream = \STDIN)
    {
        if (!is_resource($stream) || get_resource_type($stream) !== 'stream') {
            throw new \InvalidArgumentException('Expected a valid stream');
        }

        $meta = stream_get_meta_data($stream);
        if (strpos($meta['mode'], 'r') === false && strpos($meta['mode'], '+') === false) {
            throw new \InvalidArgumentException('Expected a readable stream');
        }

        $this->stream = $stream;
    }

    public function read(int $numBytes, callable $callback) : void
    {
        $meta = stream_get_meta_data($this->stream);
        if ($meta['blocked'] && ($meta['unread_bytes'] > 0)) {
            stream_set_blocking($this->stream, false);
        }
        $buffer = fread($this->stream, $numBytes);
        if ($meta['blocked'] && ($meta['unread_bytes'] > 0)) {
            stream_set_blocking($this->stream, true);
        }

        $callback($buffer);
    }

    /**
     * Whether the stream is connected to an interactive terminal
     */
    public function isInteractive() : bool
    {
        return posix_isatty($this->stream);
    }
}


1			<?php
2
3			namespace PhpSchool\Terminal\IO;
4
5			use function is_resource;
6			use function get_resource_type;
7			use function stream_get_meta_data;
8			use function strpos;
9
10			/**
11			* @author Aydin Hassan <[email protected]>
12			*/
13			class ResourceInputStream implements InputStream
14			{
15			/**
16			* @var resource
17			*/
18			private $stream;
19
20			public function __construct($stream = \STDIN)
21			{
22			if (!is_resource($stream) \|\| get_resource_type($stream) !== 'stream') {
23			throw new \InvalidArgumentException('Expected a valid stream');
24			}
25
26			$meta = stream_get_meta_data($stream);
27			if (strpos($meta['mode'], 'r') === false && strpos($meta['mode'], '+') === false) {
28			throw new \InvalidArgumentException('Expected a readable stream');
29			}
30
31			$this->stream = $stream;
32			}
33
34			public function read(int $numBytes, callable $callback) : void
35			{
36			$meta = stream_get_meta_data($this->stream);
37			if ($meta['blocked'] && ($meta['unread_bytes'] > 0)) {
38			stream_set_blocking($this->stream, false);
39			}
40			$buffer = fread($this->stream, $numBytes);
41			if ($meta['blocked'] && ($meta['unread_bytes'] > 0)) {
42			stream_set_blocking($this->stream, true);
43			}
44
45			$callback($buffer);
46			}
47
48			/**
49			* Whether the stream is connected to an interactive terminal
50			*/
51			public function isInteractive() : bool
52			{
53			return posix_isatty($this->stream);
54			}
55			}
56

php-school / terminal

Pull Request — master (#17)

ResourceInputStream::read() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like