Issues in Dialogue.php - All Issues - Inspection of "CS" - php-school/cli-menu - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( df8184...e3b994 )

by Aydin

created 2018-05-15 07:40 UTC

src/Dialogue/Dialogue.php (2 issues)

Showing only issues like (Show All)

Checks property assignments for possibly missing type casts

Bug Documentation Minor

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace PhpSchool\CliMenu\Dialogue;

use PhpSchool\CliMenu\CliMenu;
use PhpSchool\CliMenu\Exception\MenuNotOpenException;
use PhpSchool\CliMenu\MenuStyle;
use PhpSchool\Terminal\Terminal;

/**
 * @author Aydin Hassan <[email protected]>
 */
abstract class Dialogue
{
    /**
     * @var MenuStyle
     */
    protected $style;

    /**
     * @var CliMenu
     */
    protected $parentMenu;

    /**
     * @var Terminal
     */
    protected $terminal;

    /**
     * @var string $text
     */
    protected $text;

    /**
     * @var int
     */
    protected $x;

    /**
     * @var int
     */
    protected $y;

    public function __construct(CliMenu $parentMenu, MenuStyle $menuStyle, Terminal $terminal, string $text)
    {
        $this->style        = $menuStyle;
        $this->terminal     = $terminal;
        $this->text         = $text;
        $this->parentMenu   = $parentMenu;

        $this->calculateCoordinates();
    }

    /**
     * @throws MenuNotOpenException
     */
    protected function assertMenuOpen() : void
    {
        if (!$this->parentMenu->isOpen()) {
            throw new MenuNotOpenException;
        }
    }

    /**
     * Calculate the co-ordinates to write the messages
     */
    protected function calculateCoordinates() : void
    {
        //y
        $textLines          = count(explode("\n", $this->text)) + 2;
        $this->y            = ceil($this->parentMenu->getCurrentFrame()->count() / 2) - ceil($textLines / 2) + 1;
$answer = 42;

$correct = false;

$correct = (bool) $answer;

        //x
        $parentStyle        = $this->parentMenu->getStyle();
        $dialogueHalfLength = (mb_strlen($this->text) + ($this->style->getPaddingLeftRight() * 2)) / 2;
        $widthHalfLength    = ceil($parentStyle->getWidth() / 2 + $parentStyle->getMargin());
        $this->x            = $widthHalfLength - $dialogueHalfLength;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
    }

    /**
     * Write an empty row
     */
    protected function emptyRow() : void
    {
        $this->write(
            sprintf(
                "%s%s%s%s%s\n",
                $this->style->getColoursSetCode(),
                str_repeat(' ', $this->style->getPaddingLeftRight()),
                str_repeat(' ', mb_strlen($this->text)),
                str_repeat(' ', $this->style->getPaddingLeftRight()),
                $this->style->getColoursResetCode()
            )
        );
    }

    /**
     * Write some text at a particular column
     */
    protected function write(string $text, int $column = null) : void
    {
        $this->terminal->moveCursorToColumn($column ?: $this->x);
        $this->terminal->write($text);
    }

    public function getStyle() : MenuStyle
    {
        return $this->style;
    }
}


1			<?php
2
3			namespace PhpSchool\CliMenu\Dialogue;
4
5			use PhpSchool\CliMenu\CliMenu;
6			use PhpSchool\CliMenu\Exception\MenuNotOpenException;
7			use PhpSchool\CliMenu\MenuStyle;
8			use PhpSchool\Terminal\Terminal;
9
10			/**
11			* @author Aydin Hassan <[email protected]>
12			*/
13			abstract class Dialogue
14			{
15			/**
16			* @var MenuStyle
17			*/
18			protected $style;
19
20			/**
21			* @var CliMenu
22			*/
23			protected $parentMenu;
24
25			/**
26			* @var Terminal
27			*/
28			protected $terminal;
29
30			/**
31			* @var string $text
32			*/
33			protected $text;
34
35			/**
36			* @var int
37			*/
38			protected $x;
39
40			/**
41			* @var int
42			*/
43			protected $y;
44
45			public function __construct(CliMenu $parentMenu, MenuStyle $menuStyle, Terminal $terminal, string $text)
46			{
47			$this->style = $menuStyle;
48			$this->terminal = $terminal;
49			$this->text = $text;
50			$this->parentMenu = $parentMenu;
51
52			$this->calculateCoordinates();
53			}
54
55			/**
56			* @throws MenuNotOpenException
57			*/
58			protected function assertMenuOpen() : void
59			{
60			if (!$this->parentMenu->isOpen()) {
61			throw new MenuNotOpenException;
62			}
63			}
64
65			/**
66			* Calculate the co-ordinates to write the messages
67			*/
68			protected function calculateCoordinates() : void
69			{
70			//y
71			$textLines = count(explode("\n", $this->text)) + 2;
72			$this->y = ceil($this->parentMenu->getCurrentFrame()->count() / 2) - ceil($textLines / 2) + 1;
			0 ignored issues – show Documentation Bug introduced 2016-10-27 21:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$y` was declared of type `integer`, but `ceil($this->parentMenu->...eil($textLines / 2) + 1` is of type `double`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
73
74			//x
75			$parentStyle = $this->parentMenu->getStyle();
76			$dialogueHalfLength = (mb_strlen($this->text) + ($this->style->getPaddingLeftRight() * 2)) / 2;
77			$widthHalfLength = ceil($parentStyle->getWidth() / 2 + $parentStyle->getMargin());
78			$this->x = $widthHalfLength - $dialogueHalfLength;
			0 ignored issues – show Documentation Bug introduced 2016-10-27 21:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$x` was declared of type `integer`, but `$widthHalfLength - $dialogueHalfLength` is of type `double`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
79			}
80
81			/**
82			* Write an empty row
83			*/
84			protected function emptyRow() : void
85			{
86			$this->write(
87			sprintf(
88			"%s%s%s%s%s\n",
89			$this->style->getColoursSetCode(),
90			str_repeat(' ', $this->style->getPaddingLeftRight()),
91			str_repeat(' ', mb_strlen($this->text)),
92			str_repeat(' ', $this->style->getPaddingLeftRight()),
93			$this->style->getColoursResetCode()
94			)
95			);
96			}
97
98			/**
99			* Write some text at a particular column
100			*/
101			protected function write(string $text, int $column = null) : void
102			{
103			$this->terminal->moveCursorToColumn($column ?: $this->x);
104			$this->terminal->write($text);
105			}
106
107			public function getStyle() : MenuStyle
108			{
109			return $this->style;
110			}
111			}
112

php-school / cli-menu

Push — master ( df8184...e3b994 )

src/Dialogue/Dialogue.php (2 issues)

Showing only issues like (Show All)

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like