Completed
Pull Request — master (#25)
by Vincent
04:45 queued 01:05
created
src/CliMenuBuilder.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -361,7 +361,7 @@
 block discarded – undo
361 361
     }
362 362
 
363 363
     /**
364
-     * @return array
364
+     * @return SelectableItem[]
365 365
      */
366 366
     private function getDefaultItems()
367 367
     {
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -391,7 +391,7 @@  discard block
 block discarded – undo
391 391
      */
392 392
     private function itemsHaveExtra(array $items)
393 393
     {
394
-        return !empty(array_filter($items, function (MenuItemInterface $item) {
394
+        return !empty(array_filter($items, function(MenuItemInterface $item) {
395 395
             return $item->showsItemExtra();
396 396
         }));
397 397
     }
@@ -404,7 +404,7 @@  discard block
 block discarded – undo
404 404
      */
405 405
     private function getMenuStyle()
406 406
     {
407
-        $diff = array_udiff_assoc($this->style, $this->getStyleClassDefaults(), function ($current, $default) {
407
+        $diff = array_udiff_assoc($this->style, $this->getStyleClassDefaults(), function($current, $default) {
408 408
             if ($current instanceof TerminalInterface) {
409 409
                 return 0;
410 410
             }
@@ -454,7 +454,7 @@  discard block
 block discarded – undo
454 454
      */
455 455
     private function buildSubMenus(array $items)
456 456
     {
457
-        return array_map(function ($item) {
457
+        return array_map(function($item) {
458 458
             if (!is_string($item)) {
459 459
                 return $item;
460 460
             }
Please login to merge, or discard this patch.
src/Terminal/WindowsTerminal.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
     /**
54 54
      * Check if TTY is in raw mode
55 55
      *
56
-     * @return bool
56
+     * @return boolean|null
57 57
      */
58 58
     public function isRaw()
59 59
     {
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
     /**
64 64
      * Test whether terminal is valid TTY
65 65
      *
66
-     * @return bool
66
+     * @return boolean|null
67 67
      */
68 68
     public function isTTY()
69 69
     {
Please login to merge, or discard this patch.
examples/remove-defaults.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,9 +3,9 @@  discard block
 block discarded – undo
3 3
 use PhpSchool\CliMenu\CliMenu;
4 4
 use PhpSchool\CliMenu\CliMenuBuilder;
5 5
 
6
-require_once(__DIR__ . '/../vendor/autoload.php');
6
+require_once(__DIR__.'/../vendor/autoload.php');
7 7
 
8
-$itemCallable = function (CliMenu $menu) {
8
+$itemCallable = function(CliMenu $menu) {
9 9
     echo $menu->getSelectedItem()->getText();
10 10
 };
11 11
 
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
     ->addItem('Second Item', $itemCallable)
16 16
     ->addItem('Third Item', $itemCallable)
17 17
     ->disableDefaultItems()
18
-    ->addItem('CUSTOM CLOSE', function (CliMenu $menu) {
18
+    ->addItem('CUSTOM CLOSE', function(CliMenu $menu) {
19 19
         $menu->close();
20 20
     })
21 21
     ->build();
Please login to merge, or discard this patch.
examples/submenu.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,9 +3,9 @@  discard block
 block discarded – undo
3 3
 use PhpSchool\CliMenu\CliMenu;
4 4
 use PhpSchool\CliMenu\CliMenuBuilder;
5 5
 
6
-require_once(__DIR__ . '/../vendor/autoload.php');
6
+require_once(__DIR__.'/../vendor/autoload.php');
7 7
 
8
-$itemCallable = function (CliMenu $menu) {
8
+$itemCallable = function(CliMenu $menu) {
9 9
     echo $menu->getSelectedItem()->getText();
10 10
 };
11 11
 
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
     ->addLineBreak('-')
17 17
     ->addSubMenu('Options')
18 18
         ->setTitle('CLI Menu > Options')
19
-        ->addItem('First option', function (CliMenu $menu) {
19
+        ->addItem('First option', function(CliMenu $menu) {
20 20
             echo sprintf('Executing option: %s', $menu->getSelectedItem()->getText());
21 21
         })
22 22
         ->addLineBreak('-')
Please login to merge, or discard this patch.
examples/useful-separation.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,9 @@
 block discarded – undo
4 4
 use PhpSchool\CliMenu\CliMenuBuilder;
5 5
 use PhpSchool\CliMenu\MenuItem\MenuItem;
6 6
 
7
-require_once(__DIR__ . '/../vendor/autoload.php');
7
+require_once(__DIR__.'/../vendor/autoload.php');
8 8
 
9
-$itemCallable = function (CliMenu $menu) {
9
+$itemCallable = function(CliMenu $menu) {
10 10
     echo $menu->getSelectedItem()->getText();
11 11
 };
12 12
 
Please login to merge, or discard this patch.
src/CliMenu.php 3 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
                 : $this->selectedItem++;
217 217
 
218 218
             if (!array_key_exists($this->selectedItem, $this->items)) {
219
-                $this->selectedItem  = $direction === 'up'
219
+                $this->selectedItem = $direction === 'up'
220 220
                     ? end($itemKeys)
221 221
                     : reset($itemKeys);
222 222
             } elseif ($this->getSelectedItem()->canSelect()) {
@@ -263,7 +263,7 @@  discard block
 block discarded – undo
263 263
             $this->drawMenuItem(new LineBreakItem($this->style->getTitleSeparator()));
264 264
         }
265 265
 
266
-        array_map(function ($item, $index) {
266
+        array_map(function($item, $index) {
267 267
             $this->drawMenuItem($item, $index === $this->selectedItem);
268 268
         }, $this->items, array_keys($this->items));
269 269
 
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -202,7 +202,7 @@
 block discarded – undo
202 202
     /**
203 203
      * Move the selection in a given direction, up / down
204 204
      *
205
-     * @param $direction
205
+     * @param string $direction
206 206
      */
207 207
     protected function moveSelection($direction)
208 208
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 use PhpSchool\CliMenu\Exception\InvalidInstantiationException;
6 6
 use PhpSchool\CliMenu\Exception\InvalidTerminalException;
7 7
 use PhpSchool\CliMenu\MenuItem\LineBreakItem;
8
-use PhpSchool\CliMenu\MenuItem\MenuItem;
9 8
 use PhpSchool\CliMenu\MenuItem\MenuItemInterface;
10 9
 use PhpSchool\CliMenu\MenuItem\StaticItem;
11 10
 use PhpSchool\CliMenu\Terminal\TerminalFactory;
Please login to merge, or discard this patch.
src/MenuItem/AsciiArtItem.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
      */
54 54
     public function getRows(MenuStyle $style, $selected = false)
55 55
     {
56
-        return array_map(function ($row) use ($style) {
56
+        return array_map(function($row) use ($style) {
57 57
             $length = mb_strlen($row);
58 58
 
59 59
             $padding = $style->getContentWidth() - $length;
Please login to merge, or discard this patch.
src/MenuItem/SelectableTrait.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
             )
48 48
         );
49 49
 
50
-        return array_map(function ($row, $key) use ($style, $marker, $length) {
50
+        return array_map(function($row, $key) use ($style, $marker, $length) {
51 51
             if ($key === 0) {
52 52
                 return $this->showItemExtra
53 53
                     ? sprintf('%s%s  %s', $row, str_repeat(' ', $length - mb_strlen($row)), $style->getItemExtra())
Please login to merge, or discard this patch.
src/MenuStyle.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -305,7 +305,7 @@
 block discarded – undo
305 305
      */
306 306
     public function setWidth($width)
307 307
     {
308
-        $availableWidth = $this->terminal->getWidth() - ($this->margin * 2) - ($this->padding * 2);
308
+        $availableWidth = $this->terminal->getWidth() - ($this->margin*2) - ($this->padding*2);
309 309
 
310 310
         if ($width >= $availableWidth) {
311 311
             $width = $availableWidth;
Please login to merge, or discard this patch.