for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
namespace ScayTrase\Api\Cruds\Adaptors\JmsSerializer;
use JMS\Serializer\ArrayTransformerInterface as JmsDenormalizerInterface;
use JMS\Serializer\Serializer;
use ScayTrase\Api\Cruds\EntityProcessorInterface;
final class JmsSerializerProcessor implements EntityProcessorInterface
{
/** @var JmsDenormalizerInterface */
private $denormalizer;
/**
* JmsSerializerProcessor constructor.
*
* @param JmsDenormalizerInterface $denormailzer
*/
public function __construct(JmsDenormalizerInterface $denormailzer)
$this->denormalizer = $denormailzer;
}
/** {@inheritdoc} */
public function updateEntity($entity, $data)
$newObject =$this->denormalizer->fromArray(
$newObject
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
$myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; }
Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.
$myVar
$higher
$data,
get_class($entity),
JmsContextFactory::deserialization(['object_to_populate' => $entity])
);
return $entity;
php-rpc /
cruds
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.