ScayTrase\Api\Cruds\Adaptors\JmsSerializer\JmsDoctrineHandler

Complexity

Total Complexity

8

Size/Duplication

Total Lines	50
Duplicated Lines	26 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

84.21%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	serializeRelation()	0	12	3
A	deserializeRelation()	0	5	1
A	convertEntityToIds()	13	13	3

<?php

namespace ScayTrase\Api\Cruds\Adaptors\JmsSerializer;

use Doctrine\Common\Persistence\ManagerRegistry;
use Doctrine\ORM\Mapping\ClassMetadata;
use JMS\Serializer\Context;
use JMS\Serializer\VisitorInterface;

final class JmsDoctrineHandler
{
    const TYPE = 'DoctrineAssociation';

    /** @var  ManagerRegistry */
    private $registry;

    /**
     * JmsDoctrineHandler constructor.
     *
     * @param ManagerRegistry $registry
     */
    public function __construct(ManagerRegistry $registry)
    {
        $this->registry = $registry;
    }

    public function serializeRelation(VisitorInterface $visitor, $relation, array $type, Context $context)

The parameter $visitor is not used and could be removed.

The parameter $type is not used and could be removed.

The parameter $context is not used and could be removed.

    {
        if ($relation instanceof \Traversable) {
            $relation = iterator_to_array($relation);
        }

        if (is_array($relation)) {
            return array_map([$this, 'convertEntityToIds'], $relation);
        }

        return $this->convertEntityToIds($relation);
    }

    public function deserializeRelation(VisitorInterface $visitor, $data, array $type, Context $context)

The parameter $visitor is not used and could be removed.

The parameter $data is not used and could be removed.

The parameter $type is not used and could be removed.

The parameter $context is not used and could be removed.

    {
        // fixme
        throw new \BadMethodCallException('Not supported at the moment');
    }

    private function convertEntityToIds($entity)

This method seems to be duplicated in your project.

    {
        $class    = get_class($entity);
        $metadata = $this->registry->getManagerForClass($class)->getClassMetadata($class);

        $ids = $metadata->getIdentifierValues($entity);

        if (!$metadata instanceof ClassMetadata || $metadata->isIdentifierComposite) {
            return $ids;
        }

        return array_shift($ids);
    }
}