JmsSerializerAdapter::denormalize() - Code Metrics - Inspection of "denormalizer as EntityProcessor" - php-rpc/cruds - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e93435...670f0c )

by Pavel

created 2016-09-15 13:57 UTC

JmsSerializerAdapter::denormalize() A

↳ Parent: JmsSerializerAdapter

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	0
cts	5
cp	0
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	4
crap	6

<?php

namespace ScayTrase\Api\Cruds\Adaptors\JmsSerializer;

use JMS\Serializer\Serializer;
use JMS\Serializer\SerializerInterface as JmsSerializer;
use Symfony\Component\Serializer\Normalizer\DenormalizerInterface;
use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
use Symfony\Component\Serializer\SerializerInterface;

final class JmsSerializerAdapter implements SerializerInterface, NormalizerInterface, DenormalizerInterface
{
    /** @var  JmsSerializer */
    private $serializer;

    /**
     * JmsSerializerAdapter constructor.
     *
     * @param JmsSerializer $serializer
     */
    public function __construct(JmsSerializer $serializer)
    {
        $this->serializer = $serializer;
    }

    /** {@inheritdoc} */
    public function serialize($data, $format, array $context = [])
    {
        return $this->serializer->serialize($data, $format, JmsContextFactory::serialization($context));
    }

    /** {@inheritdoc} */
    public function deserialize($data, $type, $format, array $context = [])
    {
        $this->serializer->deserialize($data, $type, $format, JmsContextFactory::deserialization($context));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /** {@inheritdoc} */
    public function normalize($object, $format = null, array $context = [])
    {
        $jmsContext = JmsContextFactory::serialization($context);

        if ($this->serializer instanceof Serializer) {
            return $this->serializer->toArray($object, $jmsContext);
        }

        return json_decode($this->serializer->serialize($object, 'json', $jmsContext), true);
    }

    /** {@inheritdoc} */
    public function supportsNormalization($data, $format = null)
    {
        return true;
    }

    /** {@inheritdoc} */
    public function denormalize($data, $class, $format = null, array $context = [])
    {
        $jmsContext = JmsContextFactory::deserialization($context);

        if ($this->serializer instanceof Serializer) {
            return $this->serializer->fromArray($data, $class, $jmsContext);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        return $this->serializer->deserialize(json_encode($data), 'json', $jmsContext);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /** {@inheritdoc} */
    public function supportsDenormalization($data, $type, $format = null)
    {
        return true;
    }
}


1		<?php
2
3		namespace ScayTrase\Api\Cruds\Adaptors\JmsSerializer;
4
5		use JMS\Serializer\Serializer;
6		use JMS\Serializer\SerializerInterface as JmsSerializer;
7		use Symfony\Component\Serializer\Normalizer\DenormalizerInterface;
8		use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
9		use Symfony\Component\Serializer\SerializerInterface;
10
11		final class JmsSerializerAdapter implements SerializerInterface, NormalizerInterface, DenormalizerInterface
12		{
13		/** @var JmsSerializer */
14		private $serializer;
15
16		/**
17		* JmsSerializerAdapter constructor.
18		*
19		* @param JmsSerializer $serializer
20		*/
21	6	public function __construct(JmsSerializer $serializer)
22		{
23	6	$this->serializer = $serializer;
24	6	}
25
26		/** {@inheritdoc} */
27	6	public function serialize($data, $format, array $context = [])
28		{
29	6	return $this->serializer->serialize($data, $format, JmsContextFactory::serialization($context));
30		}
31
32		/** {@inheritdoc} */
33		public function deserialize($data, $type, $format, array $context = [])
34		{
35		$this->serializer->deserialize($data, $type, $format, JmsContextFactory::deserialization($context));
		0 ignored issues – show Documentation introduced 2016-09-09 19:25 UTC by Report Bug Copy Issue Report `\ScayTrase\Api\Cruds\Ada...serialization($context)` is of type `object<JMS\Serializer\Context>`, but the function expects a `null\|object<JMS\Serializ...DeserializationContext>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
36		}
37
38		/** {@inheritdoc} */
39	5	public function normalize($object, $format = null, array $context = [])
40		{
41	5	$jmsContext = JmsContextFactory::serialization($context);
42
43	5	if ($this->serializer instanceof Serializer) {
44	5	return $this->serializer->toArray($object, $jmsContext);
45		}
46
47		return json_decode($this->serializer->serialize($object, 'json', $jmsContext), true);
48		}
49
50		/** {@inheritdoc} */
51		public function supportsNormalization($data, $format = null)
52		{
53		return true;
54		}
55
56		/** {@inheritdoc} */
57		public function denormalize($data, $class, $format = null, array $context = [])
58		{
59		$jmsContext = JmsContextFactory::deserialization($context);
60
61		if ($this->serializer instanceof Serializer) {
62		return $this->serializer->fromArray($data, $class, $jmsContext);
		0 ignored issues – show Documentation introduced 2016-09-15 14:06 UTC by Report Bug Copy Issue Report `$jmsContext` is of type `object<JMS\Serializer\Context>`, but the function expects a `null\|object<JMS\Serializ...DeserializationContext>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
63		}
64
65		return $this->serializer->deserialize(json_encode($data), 'json', $jmsContext);
		0 ignored issues – show Documentation introduced 2016-09-15 14:06 UTC by Report Bug Copy Issue Report `$jmsContext` is of type `object<JMS\Serializer\Context>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Bug Best Practice introduced 2016-09-15 14:06 UTC by Report Bug Copy Issue Report The return type of `return $this->serializer..., 'json', $jmsContext);` (`object\|array\|integer\|double\|string\|boolean`) is incompatible with the return type declared by the interface `Symfony\Component\Serial...rInterface::denormalize` of type `object`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
66		}
67
68		/** {@inheritdoc} */
69		public function supportsDenormalization($data, $type, $format = null)
70		{
71		return true;
72		}
73		}
74

php-rpc / cruds

Push — master ( e93435...670f0c )

JmsSerializerAdapter::denormalize() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like