FormProcessor::updateEntity() - Code Metrics - Inspection of "allow dev twig for ~3.2@dev" - php-rpc/cruds - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — feature/form-processor (8ff1f0)

by Pavel

created 2016-10-01 16:51 UTC

FormProcessor::updateEntity() A

↳ Parent: FormProcessor

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	6
cts	6
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	2
crap	2

<?php

namespace ScayTrase\Api\Cruds\Adaptors\Symfony;

use ScayTrase\Api\Cruds\EntityProcessorInterface;
use ScayTrase\Api\Cruds\Exception\EntityProcessingException;
use Symfony\Component\Form\FormFactoryInterface;
use Symfony\Component\Form\FormTypeInterface;

final class FormProcessor implements EntityProcessorInterface
{
    /** @var  FormFactoryInterface */
    private $factory;
    /** @var  string|FormTypeInterface */
    private $form;
    /** @var  array */
    private $options = [];

    /**
     * FormProcessor constructor.
     *
     * @param FormFactoryInterface     $factory
     * @param string|FormTypeInterface $form
     * @param array                    $options
     */
    public function __construct(FormFactoryInterface $factory, $form, array $options = [])
    {
        $this->factory = $factory;
        $this->form    = $form;
        $this->options = $options;
    }

    /** {@inheritdoc} */
    public function updateEntity($entity, $data)
    {
        $form = $this->factory->create($this->form, $entity, $this->options);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $form->submit($data, false);

        if (!$form->isValid()) {
            throw EntityProcessingException::invalidDataSubmitted((string)$form->getErrors(true), $data);
        }

        return $form->getData();
    }
}


1		<?php
2
3		namespace ScayTrase\Api\Cruds\Adaptors\Symfony;
4
5		use ScayTrase\Api\Cruds\EntityProcessorInterface;
6		use ScayTrase\Api\Cruds\Exception\EntityProcessingException;
7		use Symfony\Component\Form\FormFactoryInterface;
8		use Symfony\Component\Form\FormTypeInterface;
9
10		final class FormProcessor implements EntityProcessorInterface
11		{
12		/** @var FormFactoryInterface */
13		private $factory;
14		/** @var string\|FormTypeInterface */
15		private $form;
16		/** @var array */
17		private $options = [];
18
19		/**
20		* FormProcessor constructor.
21		*
22		* @param FormFactoryInterface $factory
23		* @param string\|FormTypeInterface $form
24		* @param array $options
25		*/
26	1	public function __construct(FormFactoryInterface $factory, $form, array $options = [])
27		{
28	1	$this->factory = $factory;
29	1	$this->form = $form;
30	1	$this->options = $options;
31	1	}
32
33		/** {@inheritdoc} */
34	1	public function updateEntity($entity, $data)
35		{
36	1	$form = $this->factory->create($this->form, $entity, $this->options);
		0 ignored issues – show Bug introduced 2016-08-29 13:06 UTC by Report Bug Copy Issue Report It seems like `$this->form` can also be of type `object<Symfony\Component\Form\FormTypeInterface>`; however, `Symfony\Component\Form\F...toryInterface::create()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
37
38	1	$form->submit($data, false);
39
40	1	if (!$form->isValid()) {
41	1	throw EntityProcessingException::invalidDataSubmitted((string)$form->getErrors(true), $data);
42		}
43
44	1	return $form->getData();
45		}
46		}
47

php-rpc / cruds

Branch — feature/form-processor (8ff1f0)

FormProcessor::updateEntity() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like