JmsTestKernel - Code Metrics - php-rpc/cruds - Measure and Improve Code Quality continuously with Scrutinizer

JmsTestKernel A
last analyzed 2017-12-02 09:25 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	3
c	1
b	0
f	0
lcom	0
cbo	5
dl	0
loc	28
rs	10

3 Methods

Rating	Name	Size	Complexity
A	registerContainerConfiguration()	6	1
A	registerBundles()	7	1
A	buildContainer()	7	1

<?php

namespace ScayTrase\Api\Cruds\Tests\Fixtures\JmsSerializer;

use JMS\SerializerBundle\JMSSerializerBundle;
use ScayTrase\Api\Cruds\Tests\Fixtures\Common\CrudsTestKernel;
use Symfony\Component\Config\Loader\LoaderInterface;
use Symfony\Component\Config\Resource\FileResource;

final class JmsTestKernel extends CrudsTestKernel
{
    /** {@inheritdoc} */
    public function registerContainerConfiguration(LoaderInterface $loader)
    {
        parent::registerContainerConfiguration($loader);

        return $loader->load(__DIR__ . '/config.yml');
    }

    /** {@inheritdoc} */
    public function registerBundles()
    {
        $bundles   = parent::registerBundles();
        $bundles[] = new JMSSerializerBundle();

        return $bundles;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /** {@inheritdoc} */
    protected function buildContainer()
    {
        $container = parent::buildContainer();
        $container->addResource(new FileResource(__DIR__ . '/config.yml'));

        return $container;
    }
}


1			<?php
2
3			namespace ScayTrase\Api\Cruds\Tests\Fixtures\JmsSerializer;
4
5			use JMS\SerializerBundle\JMSSerializerBundle;
6			use ScayTrase\Api\Cruds\Tests\Fixtures\Common\CrudsTestKernel;
7			use Symfony\Component\Config\Loader\LoaderInterface;
8			use Symfony\Component\Config\Resource\FileResource;
9
10			final class JmsTestKernel extends CrudsTestKernel
11			{
12			/** {@inheritdoc} */
13			public function registerContainerConfiguration(LoaderInterface $loader)
14			{
15			parent::registerContainerConfiguration($loader);
16
17			return $loader->load(__DIR__ . '/config.yml');
18			}
19
20			/** {@inheritdoc} */
21			public function registerBundles()
22			{
23			$bundles = parent::registerBundles();
24			$bundles[] = new JMSSerializerBundle();
25
26			return $bundles;
			0 ignored issues – show Best Practice introduced 2017-12-01 09:54 UTC by Report Bug Copy Issue Report The expression `return $bundles;` seems to be an `array`, but some of its elements' types (`JMS\SerializerBundle\JMSSerializerBundle`) are incompatible with the return type of the parent method `ScayTrase\Api\Cruds\Test...Kernel::registerBundles` of type `array<ScayTrase\Api\Crud...ipFunctionalTestBundle>`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return new Author('Johannes'); } } class BlogPost extends Post { public function getAuthor() { return 'Johannes'; } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
27			}
28
29			/** {@inheritdoc} */
30			protected function buildContainer()
31			{
32			$container = parent::buildContainer();
33			$container->addResource(new FileResource(__DIR__ . '/config.yml'));
34
35			return $container;
36			}
37			}
38

php-rpc / cruds

JmsTestKernel A last analyzed 2017-12-02 09:25 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like

JmsTestKernel A
last analyzed 2017-12-02 09:25 UTC