QuerySyntax::dropColumn() - Code Metrics - Inspection of "database migration drop column fix" - php-resta/resta-core - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( 7d63a7...ae062b )

by Php Easy Api

created 2019-07-19 12:09 UTC

QuerySyntax::dropColumn() A

↳ Parent: QuerySyntax

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	9
c	0
b	0
f	0
nc	2
nop	1
dl	0
loc	15
rs	9.9666

<?php

namespace Migratio\GrammarStructure\Mysql;

class QuerySyntax extends QuerySyntaxHelper
{
    /**
     * @var array $data
     */
    protected $data = array();
    
    /**
     * @var array $syntax
     */
    protected $syntax = array();

    /**
     * @var null|string
     */
    protected $group;

    /**
     * @var array 
     */
    protected $alterExtras = array();

    /**
     * add column
     * 
     * @param $alterType
     * @return array
     */
    private function addColumn($alterType)
    {
        if(isset($alterType['place'])){


            foreach ($alterType['place'] as $placeKey=>$placeValue){
                $placeList=$placeKey .' '.$placeValue.'';
            }

            $syntax = implode("",$this->syntax);

            $alterSytanx = 'ALTER TABLE '.$this->table.' ADD COLUMN '.$syntax.' '.$placeList;


            $query=$this->schema->getConnection()->setQueryBasic($alterSytanx);

            if(count($this->alterExtras)){
                foreach($this->alterExtras as $extra){

                    $extraSyntax = 'ALTER TABLE '.$this->table.' '.$extra.'';

                    $query=$this->schema->getConnection()->setQueryBasic($extraSyntax);
                }
            }

            $this->alterExtras = [];

            return [
                'syntax'=>$syntax,
                'type'=>'addColumn',
                'result'=>$query['result'],
                'message'=>$query['message'],
            ];
        }

    }

    /**
     * change column
     * 
     * @param $alterType
     * @return array
     */
    private function change($alterType)
    {
        if(isset($alterType['place'])){

            foreach ($alterType['place'] as $placeKey=>$placeValue){
                $placeList=$placeKey .' '.$placeValue.'';
            }

            $syntax = implode("",$this->syntax);

            $columns = $this->schema->getConnection()->showColumnsFrom($this->table);

            foreach ($columns as $columnKey=>$columnData){
                if($columnData['Field']==$placeValue){

                    $changeAbleField = $columns[$columnKey+1]['Field'];
                }
            }

            $syntaxList = explode(' ',$syntax);

            if(current($syntaxList)!==$changeAbleField){

                $alterSytanx = 'ALTER TABLE '.$this->table.' change '.$changeAbleField.' '.current($syntaxList).'  '.implode(' ',array_splice($syntaxList,1)).' '.$placeList;

            }
            else{
                $alterSytanx = 'ALTER TABLE '.$this->table.' modify '.$syntax.' '.$placeList;
            }


            $query=$this->schema->getConnection()->setQueryBasic($alterSytanx);

            if(count($this->alterExtras)){
                foreach($this->alterExtras as $extra){

                    $extraSyntax = 'ALTER TABLE '.$this->table.' '.$extra.'';

                    $query=$this->schema->getConnection()->setQueryBasic($extraSyntax);
                }
            }

            $this->alterExtras = [];

            return [
                'syntax'=>$syntax,
                'type'=>'create',
                'result'=>$query['result'],
                'message'=>$query['message'],
            ];
        }
    }

    /**
     * drop column
     *
     * @param $alterType
     */
    private function dropColumn($alterType)
    {
        if(isset($this->syntax[0])){

            $column = rtrim($this->syntax[0]);

            $alterSytanx = 'alter table '.$this->table.' drop column '.$column;

            $query=$this->schema->getConnection()->setQueryBasic($alterSytanx);

            return [
                'syntax'=>$this->syntax,
                'type'=>'alter',
                'result'=>$query['result'],
                'message'=>$query['message'],
            ];


        }

    }

    /**
     * @return array
     */
    public function syntaxCreate()
    {
        $this->getWizardObjects($this->object);
        
        $existTables = $this->schema->getConnection()->showTables();

        $this->getCreateTableSyntax();

        $this->getDefaultSyntaxGroup();

        $this->syntax[]=')';

        //get table collation
        if(isset($this->data['tableCollation']['table'])){
            $this->syntax[]=' DEFAULT CHARACTER SET '.$this->data['tableCollation']['table'];
        }
        else{
            $this->syntax[]=' DEFAULT CHARACTER SET utf8';
        }

        //get engine
        if($this->data['engine']!==null)
        {
            $this->syntax[]=' ENGINE='.$this->data['engine'].' ';
        }
        else{
            $this->syntax[]=' ENGINE=InnoDB ';
        }

        $syntax = implode("",$this->syntax);

        if(in_array($this->table,$existTables)){
            return false;

        }
        else{
            $query=$this->schema->getConnection()->setQueryBasic($syntax);

            return [
                'syntax'=>$syntax,
                'type'=>'create',
                'result'=>$query['result'],
                'message'=>$query['message'],
            ];
        }
        
    }

    /**
     * @param null $group

     */
    private function getDefaultSyntaxGroup($group=null)
    {
        $this->syntax[]=implode(",",$this->getCreateDefaultList());
        
        //get unique values
        if(isset($this->data['uniqueValueList']) && count($this->data['uniqueValueList'])){
            
            if($group=='create'){
                $this->syntax[]=','.implode(',',$this->data['uniqueValueList']);
            }
            else{
                $this->alterExtras[]='ADD '.implode(',',$this->data['uniqueValueList']);
            }
            
        }

        //get index values
        if(isset($this->data['indexValueList']) && count($this->data['indexValueList'])){

            if($group=='create'){
                $this->syntax[]=','.implode(',',$this->data['indexValueList']);
            }
            else{
                $this->alterExtras[]='ADD '.implode(',',$this->data['indexValueList']); 
            }
            
        }

        //get index values for key
        if(count($this->getKeyList())){
            $this->syntax[]=','.implode(',',$this->getKeyList());
        }

        if(count($this->data['references'])){
            $this->syntax[]=$this->getReferenceSyntax($this->data['references']);
        }
    }


    /**
     * @return mixed|void
     */
    public function syntaxAlter()
    {
        $this->getWizardObjects($this->object);

        $alterType = $this->object->getAlterType();

        $group = $alterType['group'];
        
        $this->getDefaultSyntaxGroup($group);
        
        return $this->{$group}($alterType);

    }
    
}



1			<?php
2
3			namespace Migratio\GrammarStructure\Mysql;
4
5			class QuerySyntax extends QuerySyntaxHelper
6			{
7			/**
8			* @var array $data
9			*/
10			protected $data = array();
11
12			/**
13			* @var array $syntax
14			*/
15			protected $syntax = array();
16
17			/**
18			* @var null\|string
19			*/
20			protected $group;
21
22			/**
23			* @var array
24			*/
25			protected $alterExtras = array();
26
27			/**
28			* add column
29			*
30			* @param $alterType
31			* @return array
32			*/
33			private function addColumn($alterType)
34			{
35			if(isset($alterType['place'])){
36
37
38			foreach ($alterType['place'] as $placeKey=>$placeValue){
39			$placeList=$placeKey .' '.$placeValue.'';
40			}
41
42			$syntax = implode("",$this->syntax);
43
44			$alterSytanx = 'ALTER TABLE '.$this->table.' ADD COLUMN '.$syntax.' '.$placeList;
			0 ignored issues – show Comprehensibility Best Practice introduced 2019-06-27 08:32 UTC by Report Bug Copy Issue Report The variable `$placeList` seems to be defined by a `foreach` iteration on line `38`. Are you sure the iterator is never empty, otherwise this variable is not defined? Loading history...
45
46			$query=$this->schema->getConnection()->setQueryBasic($alterSytanx);
47
48			if(count($this->alterExtras)){
49			foreach($this->alterExtras as $extra){
50
51			$extraSyntax = 'ALTER TABLE '.$this->table.' '.$extra.'';
52
53			$query=$this->schema->getConnection()->setQueryBasic($extraSyntax);
54			}
55			}
56
57			$this->alterExtras = [];
58
59			return [
60			'syntax'=>$syntax,
61			'type'=>'addColumn',
62			'result'=>$query['result'],
63			'message'=>$query['message'],
64			];
65			}
66
67			}
68
69			/**
70			* change column
71			*
72			* @param $alterType
73			* @return array
74			*/
75			private function change($alterType)
76			{
77			if(isset($alterType['place'])){
78
79			foreach ($alterType['place'] as $placeKey=>$placeValue){
80			$placeList=$placeKey .' '.$placeValue.'';
81			}
82
83			$syntax = implode("",$this->syntax);
84
85			$columns = $this->schema->getConnection()->showColumnsFrom($this->table);
86
87			foreach ($columns as $columnKey=>$columnData){
88			if($columnData['Field']==$placeValue){
			0 ignored issues – show Comprehensibility Best Practice introduced 2019-07-16 15:53 UTC by Report Bug Copy Issue Report The variable `$placeValue` seems to be defined by a `foreach` iteration on line `79`. Are you sure the iterator is never empty, otherwise this variable is not defined? Loading history...
89			$changeAbleField = $columns[$columnKey+1]['Field'];
90			}
91			}
92
93			$syntaxList = explode(' ',$syntax);
94
95			if(current($syntaxList)!==$changeAbleField){
			0 ignored issues – show Comprehensibility Best Practice introduced 2019-07-16 15:53 UTC by Report Bug Copy Issue Report The variable `$changeAbleField` does not seem to be defined for all execution paths leading up to this point. Loading history...
96			$alterSytanx = 'ALTER TABLE '.$this->table.' change '.$changeAbleField.' '.current($syntaxList).' '.implode(' ',array_splice($syntaxList,1)).' '.$placeList;
			0 ignored issues – show Comprehensibility Best Practice introduced 2019-07-16 15:53 UTC by Report Bug Copy Issue Report The variable `$placeList` seems to be defined by a `foreach` iteration on line `79`. Are you sure the iterator is never empty, otherwise this variable is not defined? Loading history...
97			}
98			else{
99			$alterSytanx = 'ALTER TABLE '.$this->table.' modify '.$syntax.' '.$placeList;
100			}
101
102
103			$query=$this->schema->getConnection()->setQueryBasic($alterSytanx);
104
105			if(count($this->alterExtras)){
106			foreach($this->alterExtras as $extra){
107
108			$extraSyntax = 'ALTER TABLE '.$this->table.' '.$extra.'';
109
110			$query=$this->schema->getConnection()->setQueryBasic($extraSyntax);
111			}
112			}
113
114			$this->alterExtras = [];
115
116			return [
117			'syntax'=>$syntax,
118			'type'=>'create',
119			'result'=>$query['result'],
120			'message'=>$query['message'],
121			];
122			}
123			}
124
125			/**
126			* drop column
127			*
128			* @param $alterType
129			*/
130			private function dropColumn($alterType)
131			{
132			if(isset($this->syntax[0])){
133
134			$column = rtrim($this->syntax[0]);
135
136			$alterSytanx = 'alter table '.$this->table.' drop column '.$column;
137
138			$query=$this->schema->getConnection()->setQueryBasic($alterSytanx);
139
140			return [
141			'syntax'=>$this->syntax,
142			'type'=>'alter',
143			'result'=>$query['result'],
144			'message'=>$query['message'],
145			];
146
147
148			}
149
150			}
151
152			/**
153			* @return array
154			*/
155			public function syntaxCreate()
156			{
157			$this->getWizardObjects($this->object);
158
159			$existTables = $this->schema->getConnection()->showTables();
160
161			$this->getCreateTableSyntax();
162
163			$this->getDefaultSyntaxGroup();
164
165			$this->syntax[]=')';
166
167			//get table collation
168			if(isset($this->data['tableCollation']['table'])){
169			$this->syntax[]=' DEFAULT CHARACTER SET '.$this->data['tableCollation']['table'];
170			}
171			else{
172			$this->syntax[]=' DEFAULT CHARACTER SET utf8';
173			}
174
175			//get engine
176			if($this->data['engine']!==null)
177			{
178			$this->syntax[]=' ENGINE='.$this->data['engine'].' ';
179			}
180			else{
181			$this->syntax[]=' ENGINE=InnoDB ';
182			}
183
184			$syntax = implode("",$this->syntax);
185
186			if(in_array($this->table,$existTables)){
187			return false;
			0 ignored issues – show Bug Best Practice introduced 2019-07-19 08:05 UTC by Report Bug Copy Issue Report The expression `return false` returns the type `false` which is incompatible with the documented return type `array`. Loading history...
188			}
189			else{
190			$query=$this->schema->getConnection()->setQueryBasic($syntax);
191
192			return [
193			'syntax'=>$syntax,
194			'type'=>'create',
195			'result'=>$query['result'],
196			'message'=>$query['message'],
197			];
198			}
199
200			}
201
202			/**
203			* @param null $group
			0 ignored issues – show Documentation Bug introduced 2019-07-19 12:13 UTC by Report Bug Copy Issue Report Are you sure the doc-type for parameter `$group` is correct as it would always require `null` to be passed? Loading history...
204			*/
205			private function getDefaultSyntaxGroup($group=null)
206			{
207			$this->syntax[]=implode(",",$this->getCreateDefaultList());
208
209			//get unique values
210			if(isset($this->data['uniqueValueList']) && count($this->data['uniqueValueList'])){
211
212			if($group=='create'){
213			$this->syntax[]=','.implode(',',$this->data['uniqueValueList']);
214			}
215			else{
216			$this->alterExtras[]='ADD '.implode(',',$this->data['uniqueValueList']);
217			}
218
219			}
220
221			//get index values
222			if(isset($this->data['indexValueList']) && count($this->data['indexValueList'])){
223
224			if($group=='create'){
225			$this->syntax[]=','.implode(',',$this->data['indexValueList']);
226			}
227			else{
228			$this->alterExtras[]='ADD '.implode(',',$this->data['indexValueList']);
229			}
230
231			}
232
233			//get index values for key
234			if(count($this->getKeyList())){
235			$this->syntax[]=','.implode(',',$this->getKeyList());
236			}
237
238			if(count($this->data['references'])){
239			$this->syntax[]=$this->getReferenceSyntax($this->data['references']);
240			}
241			}
242
243
244			/**
245			* @return mixed\|void
246			*/
247			public function syntaxAlter()
248			{
249			$this->getWizardObjects($this->object);
250
251			$alterType = $this->object->getAlterType();
252
253			$group = $alterType['group'];
254
255			$this->getDefaultSyntaxGroup($group);
256
257			return $this->{$group}($alterType);
258
259			}
260
261			}
262
263

php-resta / resta-core

Push — master ( 7d63a7...ae062b )

QuerySyntax::dropColumn() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like