Resta\Console\Source\Track\Track::log()

Complexity

Conditions	5
Paths	8

Size

Total Lines	22
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php

    public function log()

    {

        $logger = app()->path()->appLog().''.DIRECTORY_SEPARATOR.''.date('Y').''.DIRECTORY_SEPARATOR.''.date('m').''.DIRECTORY_SEPARATOR.''.date('d').'-access.log';


        $tailCommand = 'tail -n 1 -f '.escapeshellarg($logger).'';


        while (@ ob_end_flush()); // end all output buffers if any


        $proc = popen($tailCommand, 'r');

        while (!feof($proc))

It seems like $proc can also be of type false; however, parameter $handle of feof() does only seem to accept resource, maybe add an additional type check?

        {

            $result = fread($proc, 4096);

It seems like $proc can also be of type false; however, parameter $handle of fread() does only seem to accept resource, maybe add an additional type check?

            if(preg_match('@\{(.*)\}@',$result,$output)){

                $outputArray = json_decode($output[0],1);

                

                if(app()->has('track.log')){


                    $track = app()->get('track.log');

                    echo $track($outputArray);

                }

            }

            @ flush();

It seems like you do not handle an error condition for flush(). This can introduce security issues, and is generally not recommended.

Are you sure the usage of flush() is correct as it seems to always return null.

        }

}