Migratio\Resource\PushManager\PushingProcess

Complexity

Total Complexity

8

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	processHandler()	0	28	4
A	errorHandler()	0	13	4

<?php

namespace Migratio\Resource\PushManager;

use Migratio\GrammarStructure\Mysql\QueryBuilder;

trait PushingProcess
{
    /**
     * @return void
     */
    public function processHandler()
    {
        $results = [];

The assignment to $results is dead and can be removed.

        return $this->errorHandler(function(){

The expression return $this->errorHandler(function(...) { /* ... */ }) also could return the type string which is incompatible with the documented return type void.

            
            foreach ($this->list as $table =>$datas){

                foreach ($datas as $data){

                    $queryBuilder = $this->schema->getGrammarPath().'\QueryBuilder';

                    $query = (new $queryBuilder($this->schema,$table,$data))->handle();

                    $status =($query['result']!==false) ? true : false;

                    $results[]= [
                        'success'=>$status,
                        'file'=>$data->getFile(),
                        'table'=>$table,
                        'type'=>$query['type'],
                        'syntax'=>$query['syntax'],
                        'message'=>$query['message']
                    ];
                }
            }

            return $results;

The variable $results does not seem to be defined for all execution paths leading up to this point.

        });
    }

    /**
     * @param callable $callback
     */
    public function errorHandler(callable $callback)
    {
        foreach ($this->list as $table => $objects)
        {
            foreach ($objects as $object)
            {
                if(count($object->getError())){
                    return 'error : '.$object->getFile().' -> '.$object->getError()[0].'';
                }
            }
        }

        return call_user_func($callback);
    }
}