Complex classes like Parameter often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Parameter, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 34 | class Parameter |
||
| 35 | { |
||
| 36 | use HydratorStrategyTrait; |
||
| 37 | |||
| 38 | const DEFAULT_LOCATION = 'json'; |
||
| 39 | |||
| 40 | /** |
||
| 41 | * The human-friendly name of the parameter. This is what the user will input. |
||
| 42 | * |
||
| 43 | * @var string |
||
| 44 | */ |
||
| 45 | private $name; |
||
| 46 | |||
| 47 | /** |
||
| 48 | * The alias for this parameter. Although the user will always interact with the human-friendly $name property, |
||
| 49 | * the $sentAs is what's used over the wire. |
||
| 50 | * |
||
| 51 | * @var string |
||
| 52 | */ |
||
| 53 | private $sentAs; |
||
| 54 | |||
| 55 | /** |
||
| 56 | * For array parameters (for example, an array of security group names when creating a server), each array element |
||
| 57 | * will need to adhere to a common schema. For the aforementioned example, each element will need to be a string. |
||
| 58 | * For more complicated parameters, you might be validated an array of complicated objects. |
||
| 59 | * |
||
| 60 | * @var Parameter |
||
| 61 | */ |
||
| 62 | private $itemSchema; |
||
| 63 | |||
| 64 | /** |
||
| 65 | * For object parameters, each property will need to adhere to a specific schema. For every property in the |
||
| 66 | * object, it has its own schema - meaning that this property is a hash of name/schema pairs. |
||
| 67 | * |
||
| 68 | * The *only* exception to this rule is for metadata parameters, which are arbitrary key/value pairs. Since it does |
||
| 69 | * not make sense to have a schema for each metadata key, a common schema is use for every one. So instead of this |
||
| 70 | * property being a hash of schemas, it is a single Parameter object instead. This single Parameter schema will |
||
| 71 | * then be applied to each metadata key provided. |
||
| 72 | * |
||
| 73 | * @var []Parameter|Parameter |
||
| 74 | */ |
||
| 75 | private $properties; |
||
| 76 | |||
| 77 | /** |
||
| 78 | * The value's PHP type which this parameter represents; either "string", "bool", "object", "array", "NULL". |
||
| 79 | * |
||
| 80 | * @var string |
||
| 81 | */ |
||
| 82 | private $type; |
||
| 83 | |||
| 84 | /** |
||
| 85 | * Indicates whether this parameter requires a value from the user. |
||
| 86 | * |
||
| 87 | * @var bool |
||
| 88 | */ |
||
| 89 | private $required; |
||
| 90 | |||
| 91 | /** |
||
| 92 | * The location in the HTTP request where this parameter will populate; either "header", "url", "query", "raw" or |
||
| 93 | * "json". |
||
| 94 | * |
||
| 95 | * @var string |
||
| 96 | */ |
||
| 97 | private $location; |
||
| 98 | |||
| 99 | /** |
||
| 100 | * Relevant to "json" location parameters only. This property allows for deep nesting through the use of |
||
| 101 | * {@see OpenStack\Common\JsonPath}. |
||
| 102 | * |
||
| 103 | * @var string |
||
| 104 | */ |
||
| 105 | private $path; |
||
| 106 | |||
| 107 | /** |
||
| 108 | * Allows for the prefixing of parameter names. |
||
| 109 | * |
||
| 110 | * @var string |
||
| 111 | */ |
||
| 112 | private $prefix; |
||
| 113 | |||
| 114 | /** |
||
| 115 | * @param array $data |
||
| 116 | */ |
||
| 117 | 195 | public function __construct(array $data) |
|
| 131 | |||
| 132 | 195 | private function stockItemSchema(array $data) |
|
| 138 | |||
| 139 | 195 | private function stockProperties(array $data) |
|
| 151 | |||
| 152 | /** |
||
| 153 | * Retrieve the name that will be used over the wire. |
||
| 154 | * |
||
| 155 | * @return string |
||
| 156 | */ |
||
| 157 | 88 | public function getName() |
|
| 161 | |||
| 162 | /** |
||
| 163 | * Indicates whether the user must provide a value for this parameter. |
||
| 164 | * |
||
| 165 | * @return bool |
||
| 166 | */ |
||
| 167 | 4 | public function isRequired() |
|
| 171 | |||
| 172 | /** |
||
| 173 | * Validates a given user value and checks whether it passes basic sanity checking, such as types. |
||
| 174 | * |
||
| 175 | * @param $userValues The value provided by the user |
||
| 176 | * |
||
| 177 | * @return bool TRUE if the validation passes |
||
| 178 | * @throws \Exception If validation fails |
||
| 179 | */ |
||
| 180 | 9 | public function validate($userValues) |
|
| 192 | |||
| 193 | 9 | private function validateType($userValues) |
|
| 202 | |||
| 203 | 2 | private function validateArray($userValues) |
|
| 209 | |||
| 210 | 3 | private function validateObject($userValues) |
|
| 217 | |||
| 218 | /** |
||
| 219 | * Internal method which retrieves a nested property for object parameters. |
||
| 220 | * |
||
| 221 | * @param $key The name of the child parameter |
||
| 222 | * |
||
| 223 | * @returns Parameter |
||
| 224 | * @throws \Exception |
||
| 225 | */ |
||
| 226 | 3 | private function getNestedProperty($key) |
|
| 236 | |||
| 237 | /** |
||
| 238 | * Internal method which indicates whether the user value is of the same type as the one expected |
||
| 239 | * by this parameter. |
||
| 240 | * |
||
| 241 | * @param $userValue The value being checked |
||
| 242 | * |
||
| 243 | * @return bool |
||
| 244 | */ |
||
| 245 | private function hasCorrectType($userValue) |
||
| 260 | |||
| 261 | /** |
||
| 262 | * Indicates whether this parameter represents an array type |
||
| 263 | * |
||
| 264 | * @return bool |
||
| 265 | */ |
||
| 266 | 69 | public function isArray() |
|
| 270 | |||
| 271 | /** |
||
| 272 | * Indicates whether this parameter represents an object type |
||
| 273 | * |
||
| 274 | * @return bool |
||
| 275 | */ |
||
| 276 | 68 | public function isObject() |
|
| 280 | |||
| 281 | 162 | public function getLocation() |
|
| 285 | |||
| 286 | /** |
||
| 287 | * Verifies whether the given location matches the parameter's location. |
||
| 288 | * |
||
| 289 | * @param $value |
||
| 290 | * |
||
| 291 | * @return bool |
||
| 292 | */ |
||
| 293 | 1 | public function hasLocation($value) |
|
| 297 | |||
| 298 | /** |
||
| 299 | * Retrieves the parameter's path. |
||
| 300 | * |
||
| 301 | * @return string|null |
||
| 302 | */ |
||
| 303 | 62 | public function getPath() |
|
| 307 | |||
| 308 | /** |
||
| 309 | * Retrieves the common schema that an array parameter applies to all its child elements. |
||
| 310 | * |
||
| 311 | * @return Parameter |
||
| 312 | */ |
||
| 313 | 18 | public function getItemSchema() |
|
| 317 | |||
| 318 | /** |
||
| 319 | * Sets the name of the parameter to a new value |
||
| 320 | * |
||
| 321 | * @param string $name |
||
| 322 | */ |
||
| 323 | 13 | public function setName($name) |
|
| 327 | |||
| 328 | /** |
||
| 329 | * Retrieves the child parameter for an object parameter. |
||
| 330 | * |
||
| 331 | * @param string $name The name of the child property |
||
| 332 | * |
||
| 333 | * @return null|Parameter |
||
| 334 | */ |
||
| 335 | 21 | public function getProperty($name) |
|
| 344 | |||
| 345 | /** |
||
| 346 | * Retrieves the prefix for a parameter, if any. |
||
| 347 | * |
||
| 348 | * @return string|null |
||
| 349 | */ |
||
| 350 | 15 | public function getPrefix() |
|
| 354 | } |