Service - Code Metrics - Inspection of "Add Sahara data processing support" - php-opencloud/openstack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#157)

unknown

created 2017-09-30 14:46 UTC

Service B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	239
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

Metric	Value
wmc	42
c	0
b	0
f	0
lcom	1
cbo	6
dl	0
loc	239
rs	8.295

35 Methods

Rating	Name	Size	Complexity
A	listClusters()	4	1
A	getCluster()	7	1
A	createCluster()	4	1
B	createMultipleClusters()	18	5
A	scaleCluster()	4	1
A	createDataSource()	4	1
A	getDataSource()	7	1
A	listDataSources()	4	1
A	createClusterTemplate()	4	1
A	getClusterTemplate()	7	1
A	listClusterTemplates()	4	1
A	getNodeGroupTemplate()	7	1
A	listNodeGroupTemplates()	4	1
A	createNodeGroupTemplate()	4	1
A	listJobBinaries()	4	1
A	getJobBinary()	7	1
A	createJobBinary()	4	1
A	getJobBinaryInternal()	7	1
A	listJobBinaryInternals()	4	1
A	createJobBinaryInternal()	9	1
A	createJob()	4	1
A	getJob()	7	1
A	listJobs()	4	1
A	getJobExecution()	7	1
A	listJobExecutions()	4	1
A	runJob()	4	1
A	getPlugin()	7	1
A	listPlugins()	4	1
A	getImage()	7	1
A	listImages()	4	1
A	listJobTypes()	4	1
A	listNodeGroups()	4	1
A	getNodeGroup()	14	4
A	listJobConfigs()	4	1
A	getJobConfig()	7	1

How to fix Complexity

<?php

namespace OpenStack\DataProcessing\v1;

use OpenStack\Common\Service\AbstractService;
use OpenStack\Common\Transport\Utils;
use OpenStack\DataProcessing\v1\Models\Cluster;
use OpenStack\DataProcessing\v1\Models\ClusterTemplate;
use OpenStack\DataProcessing\v1\Models\DataSource;
use OpenStack\DataProcessing\v1\Models\Image;
use OpenStack\DataProcessing\v1\Models\Job;
use OpenStack\DataProcessing\v1\Models\JobBinary;
use OpenStack\DataProcessing\v1\Models\JobBinaryInternal;
use OpenStack\DataProcessing\v1\Models\JobConfig;
use OpenStack\DataProcessing\v1\Models\JobExecution;
use OpenStack\DataProcessing\v1\Models\NodeGroup;
use OpenStack\DataProcessing\v1\Models\NodeGroupTemplate;
use OpenStack\DataProcessing\v1\Models\Plugin;
use Psr\Http\Message\StreamInterface;

class Service extends AbstractService
{
    public function listClusters(array $options = [], callable $mapFn = null): \Generator
    {
        return $this->model(Cluster::class)->enumerate($this->api->getClusters(), $options, $mapFn);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function getCluster(array $options = []): Cluster
    {
        $cluster = $this->model(Cluster::class);
        $cluster->populateFromArray($options);

        return $cluster;
    }

    public function createCluster(array $options = []): Cluster
    {
        return $this->model(Cluster::class)->create($options);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function createMultipleClusters(array $options = [])
    {
        if (!array_key_exists("count", $options)) {
            throw new \RuntimeException("Require 'count'");
        }

        $response = $this->execute($this->api->postClusters(), $options);

        # For multiple clusters, the current API returns only cluster IDs.
        $ids = Utils::flattenJson(Utils::jsonDecode($response), 'clusters');
        if ($response->getStatusCode() === 204 || empty($ids)) {
            return;
        }
        foreach ($ids as $id) {
            $cluster = $this->model(Cluster::class);
            $cluster->id = $id;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            yield $cluster;
        }
    }

    public function scaleCluster(array $options = []): Cluster
    {
        return $this->model(Cluster::class)->scale($options);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function createDataSource(array $options = []): Datasource
    {
        return $this->model(DataSource::class)->create($options);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function getDataSource(array $options = []): Datasource
    {
        $source = $this->model(DataSource::class);
        $source->populateFromArray($options);

        return $source;
    }

    public function listDataSources(array $options = [], callable $mapFn = null): \Generator
    {
        return $this->model(DataSource::class)->enumerate($this->api->getDataSources(), $options, $mapFn);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function createClusterTemplate(array $options = []): ClusterTemplate
    {
        return $this->model(ClusterTemplate::class)->create($options);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function getClusterTemplate(array $options = []): ClusterTemplate
    {
        $clusterTemplate = $this->model(ClusterTemplate::class);
        $clusterTemplate->populateFromArray($options);

        return $clusterTemplate;
    }

    public function listClusterTemplates(array $options = [], callable $mapFn = null): \Generator
    {
        return $this->model(ClusterTemplate::class)->enumerate($this->api->getClusterTemplates(), $options, $mapFn);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function getNodeGroupTemplate(array $options = []): NodeGroupTemplate
    {
        $nodeGroupTemplate = $this->model(NodeGroupTemplate::class);
        $nodeGroupTemplate->populateFromArray($options);

        return $nodeGroupTemplate;
    }

    public function listNodeGroupTemplates(array $options = [], callable $mapFn = null): \Generator
    {
        return $this->model(NodeGroupTemplate::class)->enumerate($this->api->getNodeGroupTemplates(), $options, $mapFn);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function createNodeGroupTemplate(array $options = []): NodeGroupTemplate
    {
        return $this->model(NodeGroupTemplate::class)->create($options);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function listJobBinaries(array $options = [], callable $mapFn = null): \Generator
    {
        return $this->model(JobBinary::class)->enumerate($this->api->getJobBinaries(), $options, $mapFn);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function getJobBinary(array $options = []): JobBinary
    {
        $binary = $this->model(JobBinary::class);
        $binary->populateFromArray($options);

        return $binary;
    }

    public function createJobBinary(array $options = []): JobBinary
    {
        return $this->model(JobBinary::class)->create($options);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function getJobBinaryInternal(array $options = []): JobBinaryInternal
    {
        $jobBinaryInternal = $this->model(JobBinaryInternal::class);
        $jobBinaryInternal->populateFromArray($options);

        return $jobBinaryInternal;
    }

    public function listJobBinaryInternals(array $options = [], callable $mapFn = null): \Generator
    {
        return $this->model(JobBinaryInternal::class)->enumerate($this->api->getJobBinaryInternals(), $options, $mapFn);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function createJobBinaryInternal(StreamInterface $stream): JobBinaryInternal
    {
        $options = [
            'name' => $stream->getMetadata('uri'),
            'data' => $stream,
        ];

        return $this->model(JobBinaryInternal::class)->create($options);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function createJob(array $options = []): Job
    {
        return $this->model(Job::class)->create($options);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function getJob(array $options = []): Job
    {
        $Job = $this->model(Job::class);
        $Job->populateFromArray($options);

        return $Job;
    }

    public function listJobs(array $options = [], callable $mapFn = null): \Generator
    {
        return $this->model(Job::class)->enumerate($this->api->getJobs(), $options, $mapFn);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function getJobExecution(array $options = []): JobExecution
    {
        $JobExecution = $this->model(JobExecution::class);
        $JobExecution->populateFromArray($options);

        return $JobExecution;
    }

    public function listJobExecutions(array $options = [], callable $mapFn = null): \Generator
    {
        return $this->model(JobExecution::class)->enumerate($this->api->getJobExecutions(), $options, $mapFn);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function runJob(array $options = []): JobExecution
    {
        return $this->getJob($options)->executeJob($options);
    }

    public function getPlugin(array $options = []): Plugin
    {
        $plugin = $this->model(Plugin::class);
        $plugin->populateFromArray($options);

        return $plugin;
    }

    public function listPlugins(array $options = [], callable $mapFn = null): \Generator
    {
        return $this->model(Plugin::class)->enumerate($this->api->getPlugins(), $options, $mapFn);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function getImage(array $options = []): Image
    {
        $image = $this->model(Image::class);
        $image->populateFromArray($options);

        return $image;
    }

    public function listImages(array $options = [], callable $mapFn = null): \Generator
    {
        return $this->model(Image::class)->enumerate($this->api->getImages(), $options, $mapFn);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function listJobTypes(array $options = [], callable $mapFn = null): array

    {
        return $this->model(Job::class)->getJobTypes($options);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function listNodeGroups(array $options = [], callable $mapFn = null): \Generator
    {
        return $this->model(NodeGroup::class)->enumerate($this->api->getNodeGroups(), $options, $mapFn);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function getNodeGroup(array $options = [], callable $mapFn = null): array
    {
        $nodeGroups = $this->model(NodeGroup::class)->enumerate($this->api->getNodeGroup(), $options, $mapFn);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        foreach ($nodeGroups as $nodeGroup) {
            $nodegroups = $nodeGroup->nodeGroups;
            foreach ($nodegroups as $nodegroup) {
                if ($nodegroup['id'] === $options['id']) {
                    return $nodegroup;
                }
            }
        }

        return [];
    }

    public function listJobConfigs(array $options = [], callable $mapFn = null): \Generator
    {
        return $this->model(JobConfig::class)->enumerate($this->api->getJobConfigs(), $options, $mapFn);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function getJobConfig(array $options = []): JobConfig
    {
        $jobConfig = $this->model(JobConfig::class);
        $jobConfig->populateFromArray($options);

        return $jobConfig;
    }
}


GitHub Access Token became invalid

Pull Request — master (#157)

Service B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

35 Methods

How to fix Complexity

Complex Class

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace OpenStack\DataProcessing\v1;
4
5			use OpenStack\Common\Service\AbstractService;
6			use OpenStack\Common\Transport\Utils;
7			use OpenStack\DataProcessing\v1\Models\Cluster;
8			use OpenStack\DataProcessing\v1\Models\ClusterTemplate;
9			use OpenStack\DataProcessing\v1\Models\DataSource;
10			use OpenStack\DataProcessing\v1\Models\Image;
11			use OpenStack\DataProcessing\v1\Models\Job;
12			use OpenStack\DataProcessing\v1\Models\JobBinary;
13			use OpenStack\DataProcessing\v1\Models\JobBinaryInternal;
14			use OpenStack\DataProcessing\v1\Models\JobConfig;
15			use OpenStack\DataProcessing\v1\Models\JobExecution;
16			use OpenStack\DataProcessing\v1\Models\NodeGroup;
17			use OpenStack\DataProcessing\v1\Models\NodeGroupTemplate;
18			use OpenStack\DataProcessing\v1\Models\Plugin;
19			use Psr\Http\Message\StreamInterface;
20
21			class Service extends AbstractService
22			{
23			public function listClusters(array $options = [], callable $mapFn = null): \Generator
24			{
25			return $this->model(Cluster::class)->enumerate($this->api->getClusters(), $options, $mapFn);
			0 ignored issues – show Bug introduced 2017-09-30 14:47 UTC by Report Bug Copy Issue Report The method `getClusters()` does not seem to exist on `object<OpenStack\Common\Api\ApiInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history... Bug introduced 2017-09-30 14:47 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `OpenStack\Common\Resource\ResourceInterface` as the method `enumerate()` does only exist in the following implementations of said interface: `OpenStack\BlockStorage\v2\Models\QuotaSet`, `OpenStack\BlockStorage\v2\Models\Snapshot`, `OpenStack\BlockStorage\v2\Models\Volume`, `OpenStack\BlockStorage\v2\Models\VolumeAttachment`, `OpenStack\BlockStorage\v2\Models\VolumeType`, `OpenStack\Common\Resource\OperatorResource`, `OpenStack\Compute\v2\Models\AvailabilityZone`, `OpenStack\Compute\v2\Models\Flavor`, `OpenStack\Compute\v2\Models\Host`, `OpenStack\Compute\v2\Models\Hypervisor`, `OpenStack\Compute\v2\Models\HypervisorStatistic`, `OpenStack\Compute\v2\Models\Image`, `OpenStack\Compute\v2\Models\Keypair`, `OpenStack\Compute\v2\Models\QuotaSet`, `OpenStack\Compute\v2\Models\Server`, `OpenStack\DataProcessing\v1\Models\Cluster`, `OpenStack\DataProcessing\v1\Models\ClusterTemplate`, `OpenStack\DataProcessing\v1\Models\DataSource`, `OpenStack\DataProcessing\v1\Models\Image`, `OpenStack\DataProcessing\v1\Models\Job`, `OpenStack\DataProcessing\v1\Models\JobBinary`, `OpenStack\DataProcessing...odels\JobBinaryInternal`, `OpenStack\DataProcessing\v1\Models\JobConfig`, `OpenStack\DataProcessing\v1\Models\JobExecution`, `OpenStack\DataProcessing\v1\Models\NodeGroup`, `OpenStack\DataProcessing...odels\NodeGroupTemplate`, `OpenStack\DataProcessing\v1\Models\Plugin`, `OpenStack\Identity\v2\Models\Catalog`, `OpenStack\Identity\v2\Models\Endpoint`, `OpenStack\Identity\v2\Models\Entry`, `OpenStack\Identity\v2\Models\Tenant`, `OpenStack\Identity\v2\Models\Token`, `OpenStack\Identity\v3\Models\Assignment`, `OpenStack\Identity\v3\Models\Catalog`, `OpenStack\Identity\v3\Models\Credential`, `OpenStack\Identity\v3\Models\Domain`, `OpenStack\Identity\v3\Models\Endpoint`, `OpenStack\Identity\v3\Models\Group`, `OpenStack\Identity\v3\Models\Policy`, `OpenStack\Identity\v3\Models\Project`, `OpenStack\Identity\v3\Models\Role`, `OpenStack\Identity\v3\Models\Service`, `OpenStack\Identity\v3\Models\Token`, `OpenStack\Identity\v3\Models\User`, `OpenStack\Images\v2\Models\Image`, `OpenStack\Images\v2\Models\Member`, `OpenStack\Metric\v1\Gnocchi\Models\Metric`, `OpenStack\Metric\v1\Gnocchi\Models\Resource`, `OpenStack\Metric\v1\Gnocchi\Models\ResourceType`, `OpenStack\Networking\v2\...ayer3\Models\FloatingIp`, `OpenStack\Networking\v2\...ns\Layer3\Models\Router`, `OpenStack\Networking\v2\...ps\Models\SecurityGroup`, `OpenStack\Networking\v2\...odels\SecurityGroupRule`, `OpenStack\Networking\v2\Models\InterfaceAttachment`, `OpenStack\Networking\v2\Models\LoadBalancer`, `OpenStack\Networking\v2\...adBalancerHealthMonitor`, `OpenStack\Networking\v2\...ls\LoadBalancerListener`, `OpenStack\Networking\v2\Models\LoadBalancerMember`, `OpenStack\Networking\v2\Models\LoadBalancerPool`, `OpenStack\Networking\v2\Models\LoadBalancerStat`, `OpenStack\Networking\v2\Models\LoadBalancerStatus`, `OpenStack\Networking\v2\Models\Network`, `OpenStack\Networking\v2\Models\Port`, `OpenStack\Networking\v2\Models\Quota`, `OpenStack\Networking\v2\Models\Subnet`, `OpenStack\ObjectStore\v1\Models\Account`, `OpenStack\ObjectStore\v1\Models\Container`, `OpenStack\ObjectStore\v1\Models\Object`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
26			}
27
28			public function getCluster(array $options = []): Cluster
29			{
30			$cluster = $this->model(Cluster::class);
31			$cluster->populateFromArray($options);
32
33			return $cluster;
34			}
35
36			public function createCluster(array $options = []): Cluster
37			{
38			return $this->model(Cluster::class)->create($options);
			0 ignored issues – show Bug introduced 2017-09-30 14:47 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `OpenStack\Common\Resource\ResourceInterface` as the method `create()` does only exist in the following implementations of said interface: `OpenStack\BlockStorage\v2\Models\Snapshot`, `OpenStack\BlockStorage\v2\Models\Volume`, `OpenStack\BlockStorage\v2\Models\VolumeType`, `OpenStack\Compute\v2\Models\Flavor`, `OpenStack\Compute\v2\Models\Keypair`, `OpenStack\Compute\v2\Models\Server`, `OpenStack\DataProcessing\v1\Models\Cluster`, `OpenStack\DataProcessing\v1\Models\ClusterTemplate`, `OpenStack\DataProcessing\v1\Models\DataSource`, `OpenStack\DataProcessing\v1\Models\Job`, `OpenStack\DataProcessing\v1\Models\JobBinary`, `OpenStack\DataProcessing...odels\JobBinaryInternal`, `OpenStack\DataProcessing...odels\NodeGroupTemplate`, `OpenStack\Identity\v3\Models\Credential`, `OpenStack\Identity\v3\Models\Domain`, `OpenStack\Identity\v3\Models\Endpoint`, `OpenStack\Identity\v3\Models\Group`, `OpenStack\Identity\v3\Models\Policy`, `OpenStack\Identity\v3\Models\Project`, `OpenStack\Identity\v3\Models\Role`, `OpenStack\Identity\v3\Models\Service`, `OpenStack\Identity\v3\Models\Token`, `OpenStack\Identity\v3\Models\User`, `OpenStack\Images\v2\Models\Image`, `OpenStack\Images\v2\Models\Member`, `OpenStack\Networking\v2\...ayer3\Models\FloatingIp`, `OpenStack\Networking\v2\...ns\Layer3\Models\Router`, `OpenStack\Networking\v2\...ps\Models\SecurityGroup`, `OpenStack\Networking\v2\...odels\SecurityGroupRule`, `OpenStack\Networking\v2\Models\LoadBalancer`, `OpenStack\Networking\v2\...adBalancerHealthMonitor`, `OpenStack\Networking\v2\...ls\LoadBalancerListener`, `OpenStack\Networking\v2\Models\LoadBalancerMember`, `OpenStack\Networking\v2\Models\LoadBalancerPool`, `OpenStack\Networking\v2\Models\Network`, `OpenStack\Networking\v2\Models\Port`, `OpenStack\Networking\v2\Models\Subnet`, `OpenStack\ObjectStore\v1\Models\Container`, `OpenStack\ObjectStore\v1\Models\Object`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...

php-opencloud / openstack

GitHub Access Token became invalid

Pull Request — master (#157)

Service B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

35 Methods

How to fix Complexity

Complex Class

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like