Catalog::getServiceUrl() - Code Metrics - Inspection of "bump test coverage" - php-opencloud/openstack - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 307cce...27531d )

by Jamie

created 2015-11-26 10:42 UTC

Catalog::getServiceUrl() A

↳ Parent: Catalog

Complexity

Conditions	4
Paths	3

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	13
ccs	9
cts	9
cp	1
rs	9.2
cc	4
eloc	7
nc	3
nop	4
crap	4

<?php

namespace OpenStack\Identity\v2\Models;

use OpenStack\Common\Resource\AbstractResource;
use OpenStack\Common\Transport\Utils;
use Psr\Http\Message\ResponseInterface;

/**
 * Represents an Identity v2 service catalog.
 *
 * @package OpenStack\Identity\v2\Models
 */
class Catalog extends AbstractResource implements \OpenStack\Common\Auth\Catalog
{
    const DEFAULT_URL_TYPE = 'publicURL';

    /**
     * The catalog entries
     *
     * @var []Entry
     */
    public $entries = [];

    /**
     * {@inheritDoc}
     */
    public function populateFromResponse(ResponseInterface $response)
    {
        $entries = Utils::jsonDecode($response)['access']['serviceCatalog'];

        foreach ($entries as $entry) {
            $this->entries[] = $this->model(Entry::class, $entry);
        }
    }

    public function getServiceUrl($serviceName, $serviceType, $region, $urlType = self::DEFAULT_URL_TYPE)
    {
        foreach ($this->entries as $entry) {
            if ($entry->matches($serviceName, $serviceType) && ($url = $entry->getEndpointUrl($region, $urlType))) {
                return $url;
            }
        }

        throw new \RuntimeException(sprintf(
            "Endpoint URL could not be found in the catalog for this service.\nName: %s\nType: %s\nRegion: %s\nURL type: %s",
            $serviceName, $serviceType, $region, $urlType
        ));
    }
}


1		<?php
2
3		namespace OpenStack\Identity\v2\Models;
4
5		use OpenStack\Common\Resource\AbstractResource;
6		use OpenStack\Common\Transport\Utils;
7		use Psr\Http\Message\ResponseInterface;
8
9		/**
10		* Represents an Identity v2 service catalog.
11		*
12		* @package OpenStack\Identity\v2\Models
13		*/
14		class Catalog extends AbstractResource implements \OpenStack\Common\Auth\Catalog
15		{
16		const DEFAULT_URL_TYPE = 'publicURL';
17
18		/**
19		* The catalog entries
20		*
21		* @var []Entry
22		*/
23		public $entries = [];
24
25		/**
26		* {@inheritDoc}
27		*/
28	1	public function populateFromResponse(ResponseInterface $response)
29		{
30	1	$entries = Utils::jsonDecode($response)['access']['serviceCatalog'];
31
32	1	foreach ($entries as $entry) {
33	1	$this->entries[] = $this->model(Entry::class, $entry);
34	1	}
35	1	}
36
37	2	public function getServiceUrl($serviceName, $serviceType, $region, $urlType = self::DEFAULT_URL_TYPE)
38		{
39	2	foreach ($this->entries as $entry) {
40	1	if ($entry->matches($serviceName, $serviceType) && ($url = $entry->getEndpointUrl($region, $urlType))) {
41	1	return $url;
42		}
43	1	}
44
45	1	throw new \RuntimeException(sprintf(
46	1	"Endpoint URL could not be found in the catalog for this service.\nName: %s\nType: %s\nRegion: %s\nURL type: %s",
47	1	$serviceName, $serviceType, $region, $urlType
48	1	));
49		}
50		}
51

php-opencloud / openstack

GitHub Access Token became invalid

Push — master ( 307cce...27531d )

Catalog::getServiceUrl() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like