Service - Code Metrics - Inspection of "bump test coverage" - php-opencloud/openstack - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 307cce...27531d )

by Jamie

created 2015-11-26 10:42 UTC

Service A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes	3
Bugs	0	Features	1

Metric	Value
wmc	2
c	3
b	0
f	1
lcom	1
cbo	1
dl	0
loc	33
ccs	14
cts	14
cp	1
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	generateToken()	0	5	1
A	authenticate()	0	17	1

<?php

namespace OpenStack\Identity\v2;

use OpenStack\Common\Auth\IdentityService;
use OpenStack\Common\Service\AbstractService;
use OpenStack\Identity\v2\Models\Catalog;
use OpenStack\Identity\v2\Models\Token;

/**
 * Represents the OpenStack Identity v2 service.
 *
 * @property \OpenStack\Identity\v2\Api $api
 */
class Service extends AbstractService implements IdentityService
{
    public function authenticate(array $options = [])
    {
        $definition = $this->api->postToken();

        $response = $this->execute($definition, array_intersect_key($options, $definition['params']));

        $token = $this->model(Token::class, $response);

        $serviceUrl = $this->model(Catalog::class, $response)->getServiceUrl(
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $options['catalogName'],
            $options['catalogType'],
            $options['region'],
            $options['urlType']
        );

        return [$token, $serviceUrl];
    }

    /**
     * Generates a new authentication token
     *
     * @param array $options {@see \OpenStack\Identity\v2\Api::postToken}
     *
     * @return Models\Token
     */
    public function generateToken(array $options = [])
    {
        $response = $this->execute($this->api->postToken(), $options);
        return $this->model(Token::class, $response);
    }
}


GitHub Access Token became invalid

Push — master ( 307cce...27531d )

Service A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Available Fixes

1		<?php
2
3		namespace OpenStack\Identity\v2;
4
5		use OpenStack\Common\Auth\IdentityService;
6		use OpenStack\Common\Service\AbstractService;
7		use OpenStack\Identity\v2\Models\Catalog;
8		use OpenStack\Identity\v2\Models\Token;
9
10		/**
11		* Represents the OpenStack Identity v2 service.
12		*
13		* @property \OpenStack\Identity\v2\Api $api
14		*/
15		class Service extends AbstractService implements IdentityService
16		{
17	1	public function authenticate(array $options = [])
18		{
19	1	$definition = $this->api->postToken();
20
21	1	$response = $this->execute($definition, array_intersect_key($options, $definition['params']));
22
23	1	$token = $this->model(Token::class, $response);
24
25	1	$serviceUrl = $this->model(Catalog::class, $response)->getServiceUrl(
		0 ignored issues – show Bug introduced 2015-11-23 10:33 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `OpenStack\Common\Resource\ResourceInterface` as the method `getServiceUrl()` does only exist in the following implementations of said interface: `OpenStack\Identity\v2\Models\Catalog`, `OpenStack\Identity\v3\Models\Catalog`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
26	1	$options['catalogName'],
27	1	$options['catalogType'],
28	1	$options['region'],
29	1	$options['urlType']
30	1	);
31
32	1	return [$token, $serviceUrl];
33		}
34
35		/**
36		* Generates a new authentication token
37		*
38		* @param array $options {@see \OpenStack\Identity\v2\Api::postToken}
39		*
40		* @return Models\Token
41		*/
42	1	public function generateToken(array $options = [])
43		{
44	1	$response = $this->execute($this->api->postToken(), $options);
45	1	return $this->model(Token::class, $response);
46		}
47		}
48

php-opencloud / openstack

GitHub Access Token became invalid

Push — master ( 307cce...27531d )

Service A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like