OpenStack\Common\Resource\Alias

Complexity

Total Complexity

11

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	3
A	getName()	0	4	1
B	getValue()	0	18	7

<?php declare(strict_types=1);

namespace OpenStack\Common\Resource;

/**
 * @package OpenStack\Common\Resource
 */
class Alias
{
    /**
     * @var bool
     */
    private $_isList;

    /**
     * @var string
     */
    private $_className;

    /**
     * @var string
     */
    private $_propertyName;

    /**
     * Alias constructor.
     *
     * @param string      $propertyName
     * @param string|null $className
     * @param bool        $list
     */
    public function __construct(string $propertyName, string $className = null, bool $list = false)
    {
        $this->_isList = $list;
        $this->_propertyName = $propertyName;
        $this->_className = (($className && class_exists($className)) ? $className : null);

The expression $className of type null|string is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

    }

    /**
     * @return string
     */
    public function getName()
    {
        return $this->_propertyName;
    }

    /**
     * @param ResourceInterface $resource
     * @param mixed             $value
     *
     * @return mixed
     */
    public function getValue(ResourceInterface $resource, $value)
    {
        $class = $this->_className;

        if ($value === null || !$class) {
            return $value;
        } elseif ($this->_isList && is_array($value)) {
            $array = [];
            foreach ($value as $subVal) {
                $array[] = $resource->model($class, $subVal);
            }
            return $array;
        } elseif ($class === \DateTimeImmutable::class) {
            return new \DateTimeImmutable($value);
        }

        return $resource->model($class, $value);
    }
}