Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php declare (strict_types=1); |
||
| 21 | class Server extends OperatorResource implements |
||
|
|
|||
| 22 | Creatable, |
||
| 23 | Updateable, |
||
| 24 | Deletable, |
||
| 25 | Retrievable, |
||
| 26 | Listable |
||
| 27 | { |
||
| 28 | use HasWaiterTrait; |
||
| 29 | |||
| 30 | /** @var string */ |
||
| 31 | public $id; |
||
| 32 | |||
| 33 | /** @var string */ |
||
| 34 | public $ipv4; |
||
| 35 | |||
| 36 | /** @var string */ |
||
| 37 | public $ipv6; |
||
| 38 | |||
| 39 | /** @var array */ |
||
| 40 | public $addresses; |
||
| 41 | |||
| 42 | /** @var \DateTimeImmutable */ |
||
| 43 | public $created; |
||
| 44 | |||
| 45 | /** @var \DateTimeImmutable */ |
||
| 46 | public $updated; |
||
| 47 | |||
| 48 | /** @var Flavor */ |
||
| 49 | public $flavor; |
||
| 50 | |||
| 51 | /** @var string */ |
||
| 52 | public $hostId; |
||
| 53 | |||
| 54 | /** @var Image */ |
||
| 55 | public $image; |
||
| 56 | |||
| 57 | /** @var array */ |
||
| 58 | public $links; |
||
| 59 | |||
| 60 | /** @var array */ |
||
| 61 | public $metadata; |
||
| 62 | |||
| 63 | /** @var string */ |
||
| 64 | public $name; |
||
| 65 | |||
| 66 | /** @var string */ |
||
| 67 | public $progress; |
||
| 68 | |||
| 69 | /** @var string */ |
||
| 70 | public $status; |
||
| 71 | |||
| 72 | /** @var string */ |
||
| 73 | public $tenantId; |
||
| 74 | |||
| 75 | /** @var string */ |
||
| 76 | public $userId; |
||
| 77 | |||
| 78 | /** @var string */ |
||
| 79 | public $adminPass; |
||
| 80 | |||
| 81 | /** @var string */ |
||
| 82 | public $taskState; |
||
| 83 | |||
| 84 | protected $resourceKey = 'server'; |
||
| 85 | protected $resourcesKey = 'servers'; |
||
| 86 | protected $markerKey = 'id'; |
||
| 87 | |||
| 88 | protected $aliases = [ |
||
| 89 | 'block_device_mapping_v2' => 'blockDeviceMapping', |
||
| 90 | 'accessIPv4' => 'ipv4', |
||
| 91 | 'accessIPv6' => 'ipv6', |
||
| 92 | 'tenant_id' => 'tenantId', |
||
| 93 | 'user_id' => 'userId', |
||
| 94 | 'security_groups' => 'securityGroups', |
||
| 95 | 'OS-EXT-STS:task_state' => 'taskState', |
||
| 96 | ]; |
||
| 97 | |||
| 98 | /** |
||
| 99 | * {@inheritDoc} |
||
| 100 | * |
||
| 101 | 2 | * @param array $userOptions {@see \OpenStack\Compute\v2\Api::postServer} |
|
| 102 | */ |
||
| 103 | 2 | public function create(array $userOptions): Creatable |
|
| 104 | 2 | { |
|
| 105 | $response = $this->execute($this->api->postServer(), $userOptions); |
||
| 106 | return $this->populateFromResponse($response); |
||
| 107 | } |
||
| 108 | |||
| 109 | /** |
||
| 110 | 1 | * {@inheritDoc} |
|
| 111 | */ |
||
| 112 | 1 | public function update() |
|
| 113 | { |
||
| 114 | 1 | $response = $this->execute($this->api->putServer(), $this->getAttrs(['id', 'name', 'ipv4', 'ipv6'])); |
|
| 115 | $this->populateFromResponse($response); |
||
| 116 | } |
||
| 117 | |||
| 118 | /** |
||
| 119 | * {@inheritDoc} |
||
| 120 | 1 | */ |
|
| 121 | public function delete() |
||
| 122 | 1 | { |
|
| 123 | 1 | $this->execute($this->api->deleteServer(), $this->getAttrs(['id'])); |
|
| 124 | } |
||
| 125 | |||
| 126 | /** |
||
| 127 | * {@inheritDoc} |
||
| 128 | 1 | */ |
|
| 129 | public function retrieve() |
||
| 130 | 1 | { |
|
| 131 | $response = $this->execute($this->api->getServer(), $this->getAttrs(['id'])); |
||
| 132 | 1 | $this->populateFromResponse($response); |
|
| 133 | } |
||
| 134 | |||
| 135 | /** |
||
| 136 | * Changes the root password for a server. |
||
| 137 | * |
||
| 138 | * @param string $newPassword The new root password |
||
| 139 | */ |
||
| 140 | 1 | public function changePassword(string $newPassword) |
|
| 141 | { |
||
| 142 | 1 | $this->execute($this->api->changeServerPassword(), [ |
|
| 143 | 1 | 'id' => $this->id, |
|
| 144 | 'password' => $newPassword, |
||
| 145 | 1 | ]); |
|
| 146 | 1 | } |
|
| 147 | |||
| 148 | /** |
||
| 149 | * Reboots the server. |
||
| 150 | * |
||
| 151 | * @param string $type The type of reboot that will be performed. Either SOFT or HARD is supported. |
||
| 152 | */ |
||
| 153 | 2 | public function reboot(string $type = Enum::REBOOT_SOFT) |
|
| 154 | { |
||
| 155 | 2 | if (!in_array($type, ['SOFT', 'HARD'])) { |
|
| 156 | 1 | throw new \RuntimeException('Reboot type must either be SOFT or HARD'); |
|
| 157 | } |
||
| 158 | |||
| 159 | 1 | $this->execute($this->api->rebootServer(), [ |
|
| 160 | 1 | 'id' => $this->id, |
|
| 161 | 1 | 'type' => $type, |
|
| 162 | 1 | ]); |
|
| 163 | 1 | } |
|
| 164 | |||
| 165 | /** |
||
| 166 | * Rebuilds the server. |
||
| 167 | * |
||
| 168 | * @param array $options {@see \OpenStack\Compute\v2\Api::rebuildServer} |
||
| 169 | */ |
||
| 170 | 1 | public function rebuild(array $options) |
|
| 171 | { |
||
| 172 | 1 | $options['id'] = $this->id; |
|
| 173 | 1 | $response = $this->execute($this->api->rebuildServer(), $options); |
|
| 174 | |||
| 175 | 1 | $this->populateFromResponse($response); |
|
| 176 | 1 | } |
|
| 177 | |||
| 178 | /** |
||
| 179 | * Resizes the server to a new flavor. Once this operation is complete and server has transitioned |
||
| 180 | * to an active state, you will either need to call {@see confirmResize()} or {@see revertResize()}. |
||
| 181 | * |
||
| 182 | * @param string $flavorId The UUID of the new flavor your server will be based on. |
||
| 183 | */ |
||
| 184 | 1 | public function resize(string $flavorId) |
|
| 185 | { |
||
| 186 | 1 | $response = $this->execute($this->api->resizeServer(), [ |
|
| 187 | 1 | 'id' => $this->id, |
|
| 188 | 1 | 'flavorId' => $flavorId, |
|
| 189 | 1 | ]); |
|
| 190 | |||
| 191 | 1 | $this->populateFromResponse($response); |
|
| 192 | 1 | } |
|
| 193 | |||
| 194 | /** |
||
| 195 | * Confirms a previous resize operation. |
||
| 196 | */ |
||
| 197 | 1 | public function confirmResize() |
|
| 201 | |||
| 202 | /** |
||
| 203 | * Reverts a previous resize operation. |
||
| 204 | */ |
||
| 205 | 1 | public function revertResize() |
|
| 209 | |||
| 210 | /** |
||
| 211 | * Creates an image for the current server. |
||
| 212 | * |
||
| 213 | * @param array $options {@see \OpenStack\Compute\v2\Api::createServerImage} |
||
| 214 | */ |
||
| 215 | 1 | public function createImage(array $options) |
|
| 220 | |||
| 221 | /** |
||
| 222 | * Iterates over all the IP addresses for this server. |
||
| 223 | * |
||
| 224 | * @param array $options {@see \OpenStack\Compute\v2\Api::getAddressesByNetwork} |
||
| 225 | * |
||
| 226 | * @return array An array containing to two keys: "public" and "private" |
||
| 227 | */ |
||
| 228 | 2 | public function listAddresses(array $options = []): array |
|
| 229 | { |
||
| 230 | 2 | $options['id'] = $this->id; |
|
| 231 | |||
| 232 | 2 | $data = (isset($options['networkLabel'])) ? $this->api->getAddressesByNetwork() : $this->api->getAddresses(); |
|
| 233 | 2 | $response = $this->execute($data, $options); |
|
| 234 | 2 | return Utils::jsonDecode($response)['addresses']; |
|
| 235 | } |
||
| 236 | |||
| 237 | /** |
||
| 238 | * Retrieves metadata from the API. |
||
| 239 | * |
||
| 240 | * @return array |
||
| 241 | */ |
||
| 242 | 1 | public function getMetadata(): array |
|
| 247 | |||
| 248 | /** |
||
| 249 | * Resets all the metadata for this server with the values provided. All existing metadata keys |
||
| 250 | * will either be replaced or removed. |
||
| 251 | * |
||
| 252 | * @param array $metadata {@see \OpenStack\Compute\v2\Api::putServerMetadata} |
||
| 253 | */ |
||
| 254 | public function resetMetadata(array $metadata) |
||
| 259 | 1 | ||
| 260 | /** |
||
| 261 | * Merges the existing metadata for the server with the values provided. Any existing keys |
||
| 262 | * referenced in the user options will be replaced with the user's new values. All other |
||
| 263 | * existing keys will remain unaffected. |
||
| 264 | * |
||
| 265 | * @param array $metadata {@see \OpenStack\Compute\v2\Api::postServerMetadata} |
||
| 266 | * |
||
| 267 | * @return array |
||
| 268 | */ |
||
| 269 | public function mergeMetadata(array $metadata) |
||
| 274 | 1 | ||
| 275 | /** |
||
| 276 | * Retrieve the value for a specific metadata key. |
||
| 277 | * |
||
| 278 | * @param string $key {@see \OpenStack\Compute\v2\Api::getServerMetadataKey} |
||
| 279 | * |
||
| 280 | * @return mixed |
||
| 281 | */ |
||
| 282 | View Code Duplication | public function getMetadataItem(string $key) |
|
| 289 | |||
| 290 | /** |
||
| 291 | * Remove a specific metadata key. |
||
| 292 | * |
||
| 293 | * @param string $key {@see \OpenStack\Compute\v2\Api::deleteServerMetadataKey} |
||
| 294 | */ |
||
| 295 | 1 | View Code Duplication | public function deleteMetadataItem(string $key) |
| 303 | |||
| 304 | |||
| 305 | /** |
||
| 306 | * Add security group to a server (addSecurityGroup action) |
||
| 307 | * |
||
| 308 | * @param array $options {@see \OpenStack\Compute\v2\Api::addSecurityGroup} |
||
| 309 | */ |
||
| 310 | public function addSecurityGroup(array $options) |
||
| 315 | |||
| 316 | /** |
||
| 317 | * Add security group to a server (addSecurityGroup action) |
||
| 318 | * |
||
| 319 | * @param array $options {@see \OpenStack\Compute\v2\Api::removeSecurityGroup} |
||
| 320 | */ |
||
| 321 | public function removeSecurityGroup(array $options) |
||
| 326 | |||
| 327 | public function parseMetadata(ResponseInterface $response): array |
||
| 331 | |||
| 332 | /** |
||
| 333 | * Returns Generator for SecurityGroups |
||
| 334 | * |
||
| 335 | * @return \Generator |
||
| 336 | */ |
||
| 337 | public function listSecurityGroups() |
||
| 341 | |||
| 342 | |||
| 343 | /** |
||
| 344 | * Returns Generator for SecurityGroups |
||
| 345 | * |
||
| 346 | * @return \Generator |
||
| 347 | */ |
||
| 348 | public function listVolumeAttachments() |
||
| 352 | |||
| 353 | /** |
||
| 354 | * @param $volumeId |
||
| 355 | * |
||
| 356 | * @return VolumeAttachment |
||
| 357 | */ |
||
| 358 | public function attachVolume($volumeId) |
||
| 364 | |||
| 365 | public function detachVolume($attachmentId) |
||
| 369 | } |
||
| 370 |