GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Completed
Pull Request — master (#129)
by Chris
01:56
created

Server::listPorts()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 7
Code Lines 4

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 0
CRAP Score 2

Importance

Changes 0
Metric Value
dl 0
loc 7
ccs 0
cts 0
cp 0
rs 9.4285
c 0
b 0
f 0
cc 1
eloc 4
nc 1
nop 1
crap 2

1 Method

Rating   Name   Duplication   Size   Complexity  
A Server::listInterfaceAttachments() 0 4 1
1
<?php declare(strict_types=1);
2
3
namespace OpenStack\Compute\v2\Models;
4
5
use OpenStack\Common\Resource\HasWaiterTrait;
6
use OpenStack\Common\Resource\Creatable;
7
use OpenStack\Common\Resource\Deletable;
8
use OpenStack\Common\Resource\Listable;
9
use OpenStack\Common\Resource\Retrievable;
10
use OpenStack\Common\Resource\Updateable;
11
use OpenStack\Common\Resource\OperatorResource;
12
use OpenStack\Common\Transport\Utils;
13
use OpenStack\BlockStorage\v2\Models\VolumeAttachment;
14
use OpenStack\Networking\v2\Models\InterfaceAttachment;
15
use OpenStack\Compute\v2\Enum;
16
use OpenStack\Networking\v2\Extensions\SecurityGroups\Models\SecurityGroup;
17
use Psr\Http\Message\ResponseInterface;
18
19
/**
20
 * @property \OpenStack\Compute\v2\Api $api
21
 */
22
class Server extends OperatorResource implements
23
    Creatable,
24
    Updateable,
25
    Deletable,
26
    Retrievable,
27
    Listable
28
{
29
    use HasWaiterTrait;
30
31
    /** @var string */
32
    public $id;
33
34
    /** @var string */
35
    public $ipv4;
36
37
    /** @var string */
38
    public $ipv6;
39
40
    /** @var array */
41
    public $addresses;
42
43
    /** @var \DateTimeImmutable */
44
    public $created;
45
46
    /** @var \DateTimeImmutable */
47
    public $updated;
48
49
    /** @var Flavor */
50
    public $flavor;
51
52
    /** @var string */
53
    public $hostId;
54
55
    /** @var string */
56
    public $hypervisorHostname;
57
58
    /** @var Image */
59
    public $image;
60
61
    /** @var array */
62
    public $links;
63
64
    /** @var array */
65
    public $metadata;
66
67
    /** @var string */
68
    public $name;
69
70
    /** @var string */
71
    public $progress;
72
73
    /** @var string */
74
    public $status;
75
76
    /** @var string */
77
    public $tenantId;
78
79
    /** @var string */
80
    public $userId;
81
82
    /** @var string */
83
    public $adminPass;
84
85
    /** @var string */
86
    public $taskState;
87
88
    protected $resourceKey = 'server';
89
    protected $resourcesKey = 'servers';
90
    protected $markerKey = 'id';
91
92
    protected $aliases = [
93
        'block_device_mapping_v2'             => 'blockDeviceMapping',
94
        'accessIPv4'                          => 'ipv4',
95
        'accessIPv6'                          => 'ipv6',
96
        'tenant_id'                           => 'tenantId',
97
        'user_id'                             => 'userId',
98
        'security_groups'                     => 'securityGroups',
99
        'OS-EXT-STS:task_state'               => 'taskState',
100
        'OS-EXT-SRV-ATTR:hypervisor_hostname' => 'hypervisorHostname',
101 2
    ];
102
103 2
    /**
104 2
     * {@inheritDoc}
105
     *
106
     * @param array $userOptions {@see \OpenStack\Compute\v2\Api::postServer}
107
     */
108
    public function create(array $userOptions): Creatable
109
    {
110 1
        $response = $this->execute($this->api->postServer(), $userOptions);
111
        return $this->populateFromResponse($response);
112 1
    }
113
114 1
    /**
115
     * {@inheritDoc}
116
     */
117
    public function update()
118
    {
119
        $response = $this->execute($this->api->putServer(), $this->getAttrs(['id', 'name', 'ipv4', 'ipv6']));
120 1
        $this->populateFromResponse($response);
121
    }
122 1
123 1
    /**
124
     * {@inheritDoc}
125
     */
126
    public function delete()
127
    {
128 1
        $this->execute($this->api->deleteServer(), $this->getAttrs(['id']));
129
    }
130 1
131
    /**
132 1
     * {@inheritDoc}
133
     */
134
    public function retrieve()
135
    {
136
        $response = $this->execute($this->api->getServer(), $this->getAttrs(['id']));
137
        $this->populateFromResponse($response);
138
    }
139
140 1
    /**
141
     * Changes the root password for a server.
142 1
     *
143 1
     * @param string $newPassword The new root password
144
     */
145 1
    public function changePassword(string $newPassword)
146 1
    {
147
        $this->execute($this->api->changeServerPassword(), [
148
            'id'       => $this->id,
149
            'password' => $newPassword,
150
        ]);
151
    }
152
153 2
    /**
154
     * Reboots the server.
155 2
     *
156 1
     * @param string $type The type of reboot that will be performed. Either SOFT or HARD is supported.
157
     */
158
    public function reboot(string $type = Enum::REBOOT_SOFT)
159 1
    {
160 1
        if (!in_array($type, ['SOFT', 'HARD'])) {
161 1
            throw new \RuntimeException('Reboot type must either be SOFT or HARD');
162 1
        }
163 1
164
        $this->execute($this->api->rebootServer(), [
165
            'id'   => $this->id,
166
            'type' => $type,
167
        ]);
168
    }
169
170 1
    /**
171
     * Starts server
172 1
     */
173 1
    public function start()
174
    {
175 1
        $this->execute($this->api->startServer(), [
176 1
            'id' => $this->id,
177
            'os-start' => null
178
        ]);
179
    }
180
181
    /**
182
     * Stops server
183
     */
184 1
    public function stop()
185
    {
186 1
        $this->execute($this->api->stopServer(), [
187 1
            'id' => $this->id,
188 1
            'os-stop' => null
189 1
        ]);
190
    }
191 1
192 1
    /**
193
     * Rebuilds the server.
194
     *
195
     * @param array $options {@see \OpenStack\Compute\v2\Api::rebuildServer}
196
     */
197 1
    public function rebuild(array $options)
198
    {
199 1
        $options['id'] = $this->id;
200 1
        $response = $this->execute($this->api->rebuildServer(), $options);
201
202
        $this->populateFromResponse($response);
203
    }
204
205 1
    /**
206
     * Resizes the server to a new flavor. Once this operation is complete and server has transitioned
207 1
     * to an active state, you will either need to call {@see confirmResize()} or {@see revertResize()}.
208 1
     *
209
     * @param string $flavorId The UUID of the new flavor your server will be based on.
210
     */
211
    public function resize(string $flavorId)
212
    {
213
        $response = $this->execute($this->api->resizeServer(), [
214
            'id'       => $this->id,
215 1
            'flavorId' => $flavorId,
216
        ]);
217 1
218 1
        $this->populateFromResponse($response);
219 1
    }
220
221
    /**
222
     * Confirms a previous resize operation.
223
     */
224
    public function confirmResize()
225
    {
226
        $this->execute($this->api->confirmServerResize(), ['confirmResize' => null, 'id' => $this->id]);
227
    }
228 2
229
    /**
230 2
     * Reverts a previous resize operation.
231
     */
232 2
    public function revertResize()
233 2
    {
234 2
        $this->execute($this->api->revertServerResize(), ['revertResize' => null, 'id' => $this->id]);
235
    }
236
237
    /**
238
     * Gets a VNC console for a server.
239
     *
240
     * @param  string $type The type of VNC console: novnc|xvpvnc.
241
     *                      Defaults to novnc.
242 1
     *
243
     * @return array
244 1
     */
245 1
    public function getVncConsole($type = Enum::CONSOLE_NOVNC): array
246
    {
247
        $response = $this->execute($this->api->getVncConsole(), ['id' => $this->id, 'type' => $type]);
248
        return Utils::jsonDecode($response)['console'];
249
    }
250
251
    /**
252
     * Gets a RDP console for a server.
253
     *
254
     * @param  string $type The type of VNC console: rdp-html5 (default).
255
     *
256 1
     * @return array
257
     */
258 1
    public function getRDPConsole($type = Enum::CONSOLE_RDP_HTML5): array
259 1
    {
260
        $response = $this->execute($this->api->getRDPConsole(), ['id' => $this->id, 'type' => $type]);
261
        return Utils::jsonDecode($response)['console'];
262
    }
263
264
    /**
265
     * Gets a Spice console for a server.
266
     *
267
     * @param  string $type The type of VNC console: spice-html5.
268
     *
269
     * @return array
270
     */
271 1
    public function getSpiceConsole($type = Enum::CONSOLE_SPICE_HTML5): array
272
    {
273 1
        $response = $this->execute($this->api->getSpiceConsole(), ['id' => $this->id, 'type' => $type]);
274 1
        return Utils::jsonDecode($response)['console'];
275
    }
276
277
    /**
278
     * Gets a serial console for a server.
279
     *
280
     * @param  string $type The type of VNC console: serial.
281
     *
282
     * @return array
283
     */
284 1
    public function getSerialConsole($type = Enum::CONSOLE_SERIAL): array
285
    {
286 1
        $response = $this->execute($this->api->getSerialConsole(), ['id' => $this->id, 'type' => $type]);
287 1
        return Utils::jsonDecode($response)['console'];
288
    }
289
290
    /**
291
     * Creates an image for the current server.
292
     *
293
     * @param array $options {@see \OpenStack\Compute\v2\Api::createServerImage}
294
     */
295 1
    public function createImage(array $options)
296
    {
297 1
        $options['id'] = $this->id;
298 1
        $this->execute($this->api->createServerImage(), $options);
299
    }
300
301
    /**
302
     * Iterates over all the IP addresses for this server.
303
     *
304
     * @param array $options {@see \OpenStack\Compute\v2\Api::getAddressesByNetwork}
305
     *
306
     * @return array An array containing to two keys: "public" and "private"
307
     */
308
    public function listAddresses(array $options = []): array
309
    {
310
        $options['id'] = $this->id;
311
312
        $data = (isset($options['networkLabel'])) ? $this->api->getAddressesByNetwork() : $this->api->getAddresses();
313
        $response = $this->execute($data, $options);
314
        return Utils::jsonDecode($response)['addresses'];
315
    }
316
317
    /**
318
     * Returns Generator for InterfaceAttachment
319
     *
320
     * @return \Generator
321
     */
322
    public function listInterfaceAttachments(array $options = []): \Generator
0 ignored issues
show
Unused Code introduced by
The parameter $options is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
323
    {
324
        return $this->model(InterfaceAttachment::class)->enumerate($this->api->getInterfaceAttachments(), ['id' => $this->id]);
0 ignored issues
show
Bug introduced by
It seems like you code against a concrete implementation and not the interface OpenStack\Common\Resource\ResourceInterface as the method enumerate() does only exist in the following implementations of said interface: OpenStack\BlockStorage\v2\Models\QuotaSet, OpenStack\BlockStorage\v2\Models\Snapshot, OpenStack\BlockStorage\v2\Models\Volume, OpenStack\BlockStorage\v2\Models\VolumeAttachment, OpenStack\BlockStorage\v2\Models\VolumeType, OpenStack\Common\Resource\OperatorResource, OpenStack\Compute\v2\Models\AvailabilityZone, OpenStack\Compute\v2\Models\Flavor, OpenStack\Compute\v2\Models\Host, OpenStack\Compute\v2\Models\Hypervisor, OpenStack\Compute\v2\Models\HypervisorStatistic, OpenStack\Compute\v2\Models\Image, OpenStack\Compute\v2\Models\Keypair, OpenStack\Compute\v2\Models\QuotaSet, OpenStack\Compute\v2\Models\Server, OpenStack\Identity\v2\Models\Catalog, OpenStack\Identity\v2\Models\Endpoint, OpenStack\Identity\v2\Models\Entry, OpenStack\Identity\v2\Models\Tenant, OpenStack\Identity\v2\Models\Token, OpenStack\Identity\v3\Models\Assignment, OpenStack\Identity\v3\Models\Catalog, OpenStack\Identity\v3\Models\Credential, OpenStack\Identity\v3\Models\Domain, OpenStack\Identity\v3\Models\Endpoint, OpenStack\Identity\v3\Models\Group, OpenStack\Identity\v3\Models\Policy, OpenStack\Identity\v3\Models\Project, OpenStack\Identity\v3\Models\Role, OpenStack\Identity\v3\Models\Service, OpenStack\Identity\v3\Models\Token, OpenStack\Identity\v3\Models\User, OpenStack\Images\v2\Models\Image, OpenStack\Images\v2\Models\Member, OpenStack\Metric\v1\Gnocchi\Models\Metric, OpenStack\Metric\v1\Gnocchi\Models\Resource, OpenStack\Metric\v1\Gnocchi\Models\ResourceType, OpenStack\Networking\v2\...ayer3\Models\FloatingIp, OpenStack\Networking\v2\...ns\Layer3\Models\Router, OpenStack\Networking\v2\...ps\Models\SecurityGroup, OpenStack\Networking\v2\...odels\SecurityGroupRule, OpenStack\Networking\v2\Models\InterfaceAttachment, OpenStack\Networking\v2\Models\Network, OpenStack\Networking\v2\Models\Port, OpenStack\Networking\v2\Models\Quota, OpenStack\Networking\v2\Models\Subnet, OpenStack\ObjectStore\v1\Models\Account, OpenStack\ObjectStore\v1\Models\Container, OpenStack\ObjectStore\v1\Models\Object.

Let’s take a look at an example:

interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the interface:

    interface User
    {
        /** @return string */
        public function getPassword();
    
        /** @return string */
        public function getDisplayName();
    }
    
Loading history...
325
    }
326
327
    /**
328
     * Retrieves metadata from the API.
329
     *
330
     * @return array
331
     */
332
    public function getMetadata(): array
333
    {
334
        $response = $this->execute($this->api->getServerMetadata(), ['id' => $this->id]);
335
        return $this->parseMetadata($response);
336
    }
337
338
    /**
339
     * Resets all the metadata for this server with the values provided. All existing metadata keys
340
     * will either be replaced or removed.
341
     *
342
     * @param array $metadata {@see \OpenStack\Compute\v2\Api::putServerMetadata}
343
     */
344
    public function resetMetadata(array $metadata)
345
    {
346
        $response = $this->execute($this->api->putServerMetadata(), ['id' => $this->id, 'metadata' => $metadata]);
347
        $this->metadata = $this->parseMetadata($response);
348
    }
349
350
    /**
351
     * Merges the existing metadata for the server with the values provided. Any existing keys
352
     * referenced in the user options will be replaced with the user's new values. All other
353
     * existing keys will remain unaffected.
354
     *
355
     * @param array $metadata {@see \OpenStack\Compute\v2\Api::postServerMetadata}
356
     *
357
     * @return array
358
     */
359
    public function mergeMetadata(array $metadata)
360
    {
361
        $response = $this->execute($this->api->postServerMetadata(), ['id' => $this->id, 'metadata' => $metadata]);
362
        $this->metadata = $this->parseMetadata($response);
363
    }
364
365
    /**
366
     * Retrieve the value for a specific metadata key.
367
     *
368
     * @param string $key {@see \OpenStack\Compute\v2\Api::getServerMetadataKey}
369
     *
370
     * @return mixed
371
     */
372 View Code Duplication
    public function getMetadataItem(string $key)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
373
    {
374
        $response = $this->execute($this->api->getServerMetadataKey(), ['id' => $this->id, 'key' => $key]);
375
        $value = $this->parseMetadata($response)[$key];
376
        $this->metadata[$key] = $value;
377
        return $value;
378
    }
379
380
    /**
381
     * Remove a specific metadata key.
382
     *
383
     * @param string $key {@see \OpenStack\Compute\v2\Api::deleteServerMetadataKey}
384
     */
385 View Code Duplication
    public function deleteMetadataItem(string $key)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
386
    {
387
        if (isset($this->metadata[$key])) {
388
            unset($this->metadata[$key]);
389
        }
390
391
        $this->execute($this->api->deleteServerMetadataKey(), ['id' => $this->id, 'key' => $key]);
392
    }
393
394
395
    /**
396
     * Add security group to a server (addSecurityGroup action)
397
     *
398
     * @param array $options {@see \OpenStack\Compute\v2\Api::postSecurityGroup}
399
     *
400
     * @return SecurityGroup
401
     */
402
    public function addSecurityGroup(array $options) : SecurityGroup
403
    {
404
        $options['id'] = $this->id;
405
406
        $response = $this->execute($this->api->postSecurityGroup(), $options);
407
408
        return $this->model(SecurityGroup::class)->populateFromResponse($response);
409
    }
410
411
    /**
412
     * Add security group to a server (addSecurityGroup action)
413
     *
414
     * @param array $options {@see \OpenStack\Compute\v2\Api::deleteSecurityGroup}
415
     */
416
    public function removeSecurityGroup(array $options)
417
    {
418
        $options['id'] = $this->id;
419
        $this->execute($this->api->deleteSecurityGroup(), $options);
420
    }
421
422
    public function parseMetadata(ResponseInterface $response): array
423
    {
424
        return Utils::jsonDecode($response)['metadata'];
425
    }
426
427
    /**
428
     * Returns Generator for SecurityGroups
429
     *
430
     * @return \Generator
431
     */
432
    public function listSecurityGroups(): \Generator
433
    {
434
        return $this->model(SecurityGroup::class)->enumerate($this->api->getSecurityGroups(), ['id' => $this->id]);
0 ignored issues
show
Bug introduced by
It seems like you code against a concrete implementation and not the interface OpenStack\Common\Resource\ResourceInterface as the method enumerate() does only exist in the following implementations of said interface: OpenStack\BlockStorage\v2\Models\QuotaSet, OpenStack\BlockStorage\v2\Models\Snapshot, OpenStack\BlockStorage\v2\Models\Volume, OpenStack\BlockStorage\v2\Models\VolumeAttachment, OpenStack\BlockStorage\v2\Models\VolumeType, OpenStack\Common\Resource\OperatorResource, OpenStack\Compute\v2\Models\AvailabilityZone, OpenStack\Compute\v2\Models\Flavor, OpenStack\Compute\v2\Models\Host, OpenStack\Compute\v2\Models\Hypervisor, OpenStack\Compute\v2\Models\HypervisorStatistic, OpenStack\Compute\v2\Models\Image, OpenStack\Compute\v2\Models\Keypair, OpenStack\Compute\v2\Models\QuotaSet, OpenStack\Compute\v2\Models\Server, OpenStack\Identity\v2\Models\Catalog, OpenStack\Identity\v2\Models\Endpoint, OpenStack\Identity\v2\Models\Entry, OpenStack\Identity\v2\Models\Tenant, OpenStack\Identity\v2\Models\Token, OpenStack\Identity\v3\Models\Assignment, OpenStack\Identity\v3\Models\Catalog, OpenStack\Identity\v3\Models\Credential, OpenStack\Identity\v3\Models\Domain, OpenStack\Identity\v3\Models\Endpoint, OpenStack\Identity\v3\Models\Group, OpenStack\Identity\v3\Models\Policy, OpenStack\Identity\v3\Models\Project, OpenStack\Identity\v3\Models\Role, OpenStack\Identity\v3\Models\Service, OpenStack\Identity\v3\Models\Token, OpenStack\Identity\v3\Models\User, OpenStack\Images\v2\Models\Image, OpenStack\Images\v2\Models\Member, OpenStack\Metric\v1\Gnocchi\Models\Metric, OpenStack\Metric\v1\Gnocchi\Models\Resource, OpenStack\Metric\v1\Gnocchi\Models\ResourceType, OpenStack\Networking\v2\...ayer3\Models\FloatingIp, OpenStack\Networking\v2\...ns\Layer3\Models\Router, OpenStack\Networking\v2\...ps\Models\SecurityGroup, OpenStack\Networking\v2\...odels\SecurityGroupRule, OpenStack\Networking\v2\Models\InterfaceAttachment, OpenStack\Networking\v2\Models\Network, OpenStack\Networking\v2\Models\Port, OpenStack\Networking\v2\Models\Quota, OpenStack\Networking\v2\Models\Subnet, OpenStack\ObjectStore\v1\Models\Account, OpenStack\ObjectStore\v1\Models\Container, OpenStack\ObjectStore\v1\Models\Object.

Let’s take a look at an example:

interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the interface:

    interface User
    {
        /** @return string */
        public function getPassword();
    
        /** @return string */
        public function getDisplayName();
    }
    
Loading history...
435
    }
436
437
438
    /**
439
     * Returns Generator for VolumeAttachment
440
     *
441
     * @return \Generator
442
     */
443
    public function listVolumeAttachments(): \Generator
444
    {
445
        return $this->model(VolumeAttachment::class)->enumerate($this->api->getVolumeAttachments(), ['id' => $this->id]);
0 ignored issues
show
Bug introduced by
It seems like you code against a concrete implementation and not the interface OpenStack\Common\Resource\ResourceInterface as the method enumerate() does only exist in the following implementations of said interface: OpenStack\BlockStorage\v2\Models\QuotaSet, OpenStack\BlockStorage\v2\Models\Snapshot, OpenStack\BlockStorage\v2\Models\Volume, OpenStack\BlockStorage\v2\Models\VolumeAttachment, OpenStack\BlockStorage\v2\Models\VolumeType, OpenStack\Common\Resource\OperatorResource, OpenStack\Compute\v2\Models\AvailabilityZone, OpenStack\Compute\v2\Models\Flavor, OpenStack\Compute\v2\Models\Host, OpenStack\Compute\v2\Models\Hypervisor, OpenStack\Compute\v2\Models\HypervisorStatistic, OpenStack\Compute\v2\Models\Image, OpenStack\Compute\v2\Models\Keypair, OpenStack\Compute\v2\Models\QuotaSet, OpenStack\Compute\v2\Models\Server, OpenStack\Identity\v2\Models\Catalog, OpenStack\Identity\v2\Models\Endpoint, OpenStack\Identity\v2\Models\Entry, OpenStack\Identity\v2\Models\Tenant, OpenStack\Identity\v2\Models\Token, OpenStack\Identity\v3\Models\Assignment, OpenStack\Identity\v3\Models\Catalog, OpenStack\Identity\v3\Models\Credential, OpenStack\Identity\v3\Models\Domain, OpenStack\Identity\v3\Models\Endpoint, OpenStack\Identity\v3\Models\Group, OpenStack\Identity\v3\Models\Policy, OpenStack\Identity\v3\Models\Project, OpenStack\Identity\v3\Models\Role, OpenStack\Identity\v3\Models\Service, OpenStack\Identity\v3\Models\Token, OpenStack\Identity\v3\Models\User, OpenStack\Images\v2\Models\Image, OpenStack\Images\v2\Models\Member, OpenStack\Metric\v1\Gnocchi\Models\Metric, OpenStack\Metric\v1\Gnocchi\Models\Resource, OpenStack\Metric\v1\Gnocchi\Models\ResourceType, OpenStack\Networking\v2\...ayer3\Models\FloatingIp, OpenStack\Networking\v2\...ns\Layer3\Models\Router, OpenStack\Networking\v2\...ps\Models\SecurityGroup, OpenStack\Networking\v2\...odels\SecurityGroupRule, OpenStack\Networking\v2\Models\InterfaceAttachment, OpenStack\Networking\v2\Models\Network, OpenStack\Networking\v2\Models\Port, OpenStack\Networking\v2\Models\Quota, OpenStack\Networking\v2\Models\Subnet, OpenStack\ObjectStore\v1\Models\Account, OpenStack\ObjectStore\v1\Models\Container, OpenStack\ObjectStore\v1\Models\Object.

Let’s take a look at an example:

interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the interface:

    interface User
    {
        /** @return string */
        public function getPassword();
    
        /** @return string */
        public function getDisplayName();
    }
    
Loading history...
446
    }
447
448
    /**
449
     * Attach a volume and returns volume that was attached
450
     *
451
     * @param $volumeId
452
     *
453
     * @return VolumeAttachment
454
     */
455
    public function attachVolume(string $volumeId): VolumeAttachment
456
    {
457
        $response =  $this->execute($this->api->postVolumeAttachments(), ['id' => $this->id, 'volumeId' => $volumeId]);
458
459
        return $this->model(VolumeAttachment::class)->populateFromResponse($response);
460
    }
461
462
    /**
463
     * Detach a volume
464
     *
465
     * @param $attachmentId
466
     *
467
     * @return void
468
     */
469
    public function detachVolume(string $attachmentId)
470
    {
471
        $this->execute($this->api->deleteVolumeAttachments(), ['id' => $this->id, 'attachmentId' => $attachmentId]);
472
    }
473
}
474