GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Completed
Pull Request — master (#169)
by Casper
02:02
created

Server::changePassword()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 7
Code Lines 4

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 5
CRAP Score 1

Importance

Changes 0
Metric Value
dl 0
loc 7
c 0
b 0
f 0
rs 9.4285
ccs 5
cts 5
cp 1
cc 1
eloc 4
nc 1
nop 1
crap 1
1
<?php declare(strict_types=1);
2
3
namespace OpenStack\Compute\v2\Models;
4
5
use OpenStack\Common\Resource\HasWaiterTrait;
6
use OpenStack\Common\Resource\Creatable;
7
use OpenStack\Common\Resource\Deletable;
8
use OpenStack\Common\Resource\Listable;
9
use OpenStack\Common\Resource\Retrievable;
10
use OpenStack\Common\Resource\Updateable;
11
use OpenStack\Common\Resource\OperatorResource;
12
use OpenStack\Common\Transport\Utils;
13
use OpenStack\BlockStorage\v2\Models\VolumeAttachment;
14
use OpenStack\Networking\v2\Models\InterfaceAttachment;
15
use OpenStack\Compute\v2\Enum;
16
use OpenStack\Networking\v2\Extensions\SecurityGroups\Models\SecurityGroup;
17
use Psr\Http\Message\ResponseInterface;
18
19
/**
20
 * @property \OpenStack\Compute\v2\Api $api
21
 */
22
class Server extends OperatorResource implements
23
    Creatable,
24
    Updateable,
25
    Deletable,
26
    Retrievable,
27
    Listable
28
{
29
    use HasWaiterTrait;
30
31
    /** @var string */
32
    public $id;
33
34
    /** @var string */
35
    public $ipv4;
36
37
    /** @var string */
38
    public $ipv6;
39
40
    /** @var array */
41
    public $addresses;
42
43
    /** @var \DateTimeImmutable */
44
    public $created;
45
46
    /** @var \DateTimeImmutable */
47
    public $updated;
48
49
    /** @var Flavor */
50
    public $flavor;
51
52
    /** @var string */
53
    public $hostId;
54
55
    /** @var string */
56
    public $hypervisorHostname;
57
58
    /** @var Image */
59
    public $image;
60
61
    /** @var array */
62
    public $links;
63
64
    /** @var array */
65
    public $metadata;
66
67
    /** @var string */
68
    public $name;
69
70
    /** @var string */
71
    public $progress;
72
73
    /** @var string */
74
    public $status;
75
76
    /** @var string */
77
    public $tenantId;
78
79
    /** @var string */
80
    public $userId;
81
82
    /** @var string */
83
    public $adminPass;
84
85
    /** @var string */
86
    public $taskState;
87
88
    /** @var string */
89
    public $powerState;
90
91
    /** @var string */
92
    public $vmState;
93
94
    protected $resourceKey = 'server';
95
    protected $resourcesKey = 'servers';
96
    protected $markerKey = 'id';
97
98
    protected $aliases = [
99
        'block_device_mapping_v2'             => 'blockDeviceMapping',
100
        'accessIPv4'                          => 'ipv4',
101 2
        'accessIPv6'                          => 'ipv6',
102
        'tenant_id'                           => 'tenantId',
103 2
        'user_id'                             => 'userId',
104 2
        'security_groups'                     => 'securityGroups',
105
        'OS-EXT-STS:task_state'               => 'taskState',
106
        'OS-EXT-STS:power_state'              => 'powerState',
107
        'OS-EXT-STS:vm_state'                 => 'vmState',
108
        'OS-EXT-SRV-ATTR:hypervisor_hostname' => 'hypervisorHostname',
109
    ];
110 1
111
    /**
112 1
     * {@inheritDoc}
113
     *
114 1
     * @param array $userOptions {@see \OpenStack\Compute\v2\Api::postServer}
115
     */
116
    public function create(array $userOptions): Creatable
117
    {
118
        if (!isset($userOptions['imageId']) && !isset($userOptions['blockDeviceMapping'][0]['uuid'])) {
119
            throw new \RuntimeException('imageId or blockDeviceMapping.uuid must be set.');
120 1
        }
121
122 1
        $response = $this->execute($this->api->postServer(), $userOptions);
123 1
        return $this->populateFromResponse($response);
124
    }
125
126
    /**
127
     * {@inheritDoc}
128 1
     */
129
    public function update()
130 1
    {
131
        $response = $this->execute($this->api->putServer(), $this->getAttrs(['id', 'name', 'ipv4', 'ipv6']));
132 1
        $this->populateFromResponse($response);
133
    }
134
135
    /**
136
     * {@inheritDoc}
137
     */
138
    public function delete()
139
    {
140 1
        $this->execute($this->api->deleteServer(), $this->getAttrs(['id']));
141
    }
142 1
143 1
    /**
144
     * {@inheritDoc}
145 1
     */
146 1
    public function retrieve()
147
    {
148
        $response = $this->execute($this->api->getServer(), $this->getAttrs(['id']));
149
        $this->populateFromResponse($response);
150
    }
151
152
    /**
153 2
     * Changes the root password for a server.
154
     *
155 2
     * @param string $newPassword The new root password
156 1
     */
157
    public function changePassword(string $newPassword)
158
    {
159 1
        $this->execute($this->api->changeServerPassword(), [
160 1
            'id'       => $this->id,
161 1
            'password' => $newPassword,
162 1
        ]);
163 1
    }
164
165
    /**
166
     * Reboots the server.
167
     *
168
     * @param string $type The type of reboot that will be performed. Either SOFT or HARD is supported.
169
     */
170 1
    public function reboot(string $type = Enum::REBOOT_SOFT)
171
    {
172 1
        if (!in_array($type, ['SOFT', 'HARD'])) {
173 1
            throw new \RuntimeException('Reboot type must either be SOFT or HARD');
174
        }
175 1
176 1
        $this->execute($this->api->rebootServer(), [
177
            'id'   => $this->id,
178
            'type' => $type,
179
        ]);
180
    }
181
182
    /**
183
     * Starts server
184 1
     */
185
    public function start()
186 1
    {
187 1
        $this->execute($this->api->startServer(), [
188 1
            'id' => $this->id,
189 1
            'os-start' => null
190
        ]);
191 1
    }
192 1
193
    /**
194
     * Stops server
195
     */
196
    public function stop()
197 1
    {
198
        $this->execute($this->api->stopServer(), [
199 1
            'id' => $this->id,
200 1
            'os-stop' => null
201
        ]);
202
    }
203
204
    /**
205 1
     * Rebuilds the server.
206
     *
207 1
     * @param array $options {@see \OpenStack\Compute\v2\Api::rebuildServer}
208 1
     */
209
    public function rebuild(array $options)
210
    {
211
        $options['id'] = $this->id;
212
        $response = $this->execute($this->api->rebuildServer(), $options);
213
214
        $this->populateFromResponse($response);
215 1
    }
216
217 1
    /**
218 1
     * Rescues the server.
219 1
     *
220
     * @param array $options {@see \OpenStack\Compute\v2\Api::rescueServer}
221
     * @return string
222
     */
223
    public function rescue(array $options): string
224
    {
225
        $options['id'] = $this->id;
226
        $response = $this->execute($this->api->rescueServer(), $options);
227
228 2
        return Utils::jsonDecode($response)['adminPass'];
229
    }
230 2
231
    /**
232 2
     * Unrescues the server.
233 2
     */
234 2
    public function unrescue()
235
    {
236
        $this->execute($this->api->unrescueServer(), ['unrescue' => null, 'id' => $this->id]);
237
    }
238
239
    /**
240
     * Resizes the server to a new flavor. Once this operation is complete and server has transitioned
241
     * to an active state, you will either need to call {@see confirmResize()} or {@see revertResize()}.
242 1
     *
243
     * @param string $flavorId The UUID of the new flavor your server will be based on.
244 1
     */
245 1
    public function resize(string $flavorId)
246
    {
247
        $response = $this->execute($this->api->resizeServer(), [
248
            'id'       => $this->id,
249
            'flavorId' => $flavorId,
250
        ]);
251
252
        $this->populateFromResponse($response);
253
    }
254
255
    /**
256 1
     * Confirms a previous resize operation.
257
     */
258 1
    public function confirmResize()
259 1
    {
260
        $this->execute($this->api->confirmServerResize(), ['confirmResize' => null, 'id' => $this->id]);
261
    }
262
263
    /**
264
     * Reverts a previous resize operation.
265
     */
266
    public function revertResize()
267
    {
268
        $this->execute($this->api->revertServerResize(), ['revertResize' => null, 'id' => $this->id]);
269
    }
270
271 1
    /**
272
     * Gets a VNC console for a server.
273 1
     *
274 1
     * @param  string $type The type of VNC console: novnc|xvpvnc.
275
     *                      Defaults to novnc.
276
     *
277
     * @return array
278
     */
279
    public function getVncConsole($type = Enum::CONSOLE_NOVNC): array
280
    {
281
        $response = $this->execute($this->api->getVncConsole(), ['id' => $this->id, 'type' => $type]);
282
        return Utils::jsonDecode($response)['console'];
283
    }
284 1
285
    /**
286 1
     * Gets a RDP console for a server.
287 1
     *
288
     * @param  string $type The type of VNC console: rdp-html5 (default).
289
     *
290
     * @return array
291
     */
292
    public function getRDPConsole($type = Enum::CONSOLE_RDP_HTML5): array
293
    {
294
        $response = $this->execute($this->api->getRDPConsole(), ['id' => $this->id, 'type' => $type]);
295 1
        return Utils::jsonDecode($response)['console'];
296
    }
297 1
298 1
    /**
299
     * Gets a Spice console for a server.
300
     *
301
     * @param  string $type The type of VNC console: spice-html5.
302
     *
303
     * @return array
304
     */
305
    public function getSpiceConsole($type = Enum::CONSOLE_SPICE_HTML5): array
306
    {
307
        $response = $this->execute($this->api->getSpiceConsole(), ['id' => $this->id, 'type' => $type]);
308
        return Utils::jsonDecode($response)['console'];
309
    }
310
311
    /**
312
     * Gets a serial console for a server.
313
     *
314
     * @param  string $type The type of VNC console: serial.
315
     *
316
     * @return array
317
     */
318
    public function getSerialConsole($type = Enum::CONSOLE_SERIAL): array
319
    {
320
        $response = $this->execute($this->api->getSerialConsole(), ['id' => $this->id, 'type' => $type]);
321
        return Utils::jsonDecode($response)['console'];
322
    }
323
324
    /**
325
     * Creates an image for the current server.
326
     *
327
     * @param array $options {@see \OpenStack\Compute\v2\Api::createServerImage}
328
     */
329
    public function createImage(array $options)
330
    {
331
        $options['id'] = $this->id;
332
        $this->execute($this->api->createServerImage(), $options);
333
    }
334
335
    /**
336
     * Iterates over all the IP addresses for this server.
337
     *
338
     * @param array $options {@see \OpenStack\Compute\v2\Api::getAddressesByNetwork}
339
     *
340
     * @return array An array containing to two keys: "public" and "private"
341
     */
342
    public function listAddresses(array $options = []): array
343
    {
344
        $options['id'] = $this->id;
345
346
        $data = (isset($options['networkLabel'])) ? $this->api->getAddressesByNetwork() : $this->api->getAddresses();
347
        $response = $this->execute($data, $options);
348
        return Utils::jsonDecode($response)['addresses'];
349
    }
350
351
    /**
352
     * Returns Generator for InterfaceAttachment
353
     *
354
     * @return \Generator
355
     */
356
    public function listInterfaceAttachments(array $options = []): \Generator
0 ignored issues
show
Unused Code introduced by
The parameter $options is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
357
    {
358
        return $this->model(InterfaceAttachment::class)->enumerate($this->api->getInterfaceAttachments(), ['id' => $this->id]);
0 ignored issues
show
Bug introduced by
It seems like you code against a concrete implementation and not the interface OpenStack\Common\Resource\ResourceInterface as the method enumerate() does only exist in the following implementations of said interface: OpenStack\BlockStorage\v2\Models\QuotaSet, OpenStack\BlockStorage\v2\Models\Snapshot, OpenStack\BlockStorage\v2\Models\Volume, OpenStack\BlockStorage\v2\Models\VolumeAttachment, OpenStack\BlockStorage\v2\Models\VolumeType, OpenStack\Common\Resource\OperatorResource, OpenStack\Compute\v2\Models\AvailabilityZone, OpenStack\Compute\v2\Models\Flavor, OpenStack\Compute\v2\Models\Host, OpenStack\Compute\v2\Models\Hypervisor, OpenStack\Compute\v2\Models\HypervisorStatistic, OpenStack\Compute\v2\Models\Image, OpenStack\Compute\v2\Models\Keypair, OpenStack\Compute\v2\Models\QuotaSet, OpenStack\Compute\v2\Models\Server, OpenStack\Identity\v2\Models\Catalog, OpenStack\Identity\v2\Models\Endpoint, OpenStack\Identity\v2\Models\Entry, OpenStack\Identity\v2\Models\Tenant, OpenStack\Identity\v2\Models\Token, OpenStack\Identity\v3\Models\Assignment, OpenStack\Identity\v3\Models\Catalog, OpenStack\Identity\v3\Models\Credential, OpenStack\Identity\v3\Models\Domain, OpenStack\Identity\v3\Models\Endpoint, OpenStack\Identity\v3\Models\Group, OpenStack\Identity\v3\Models\Policy, OpenStack\Identity\v3\Models\Project, OpenStack\Identity\v3\Models\Role, OpenStack\Identity\v3\Models\Service, OpenStack\Identity\v3\Models\Token, OpenStack\Identity\v3\Models\User, OpenStack\Images\v2\Models\Image, OpenStack\Images\v2\Models\Member, OpenStack\Metric\v1\Gnocchi\Models\Metric, OpenStack\Metric\v1\Gnocchi\Models\Resource, OpenStack\Metric\v1\Gnocchi\Models\ResourceType, OpenStack\Networking\v2\...ayer3\Models\FloatingIp, OpenStack\Networking\v2\...ns\Layer3\Models\Router, OpenStack\Networking\v2\...ps\Models\SecurityGroup, OpenStack\Networking\v2\...odels\SecurityGroupRule, OpenStack\Networking\v2\Models\InterfaceAttachment, OpenStack\Networking\v2\Models\LoadBalancer, OpenStack\Networking\v2\...adBalancerHealthMonitor, OpenStack\Networking\v2\...ls\LoadBalancerListener, OpenStack\Networking\v2\Models\LoadBalancerMember, OpenStack\Networking\v2\Models\LoadBalancerPool, OpenStack\Networking\v2\Models\LoadBalancerStat, OpenStack\Networking\v2\Models\LoadBalancerStatus, OpenStack\Networking\v2\Models\Network, OpenStack\Networking\v2\Models\Port, OpenStack\Networking\v2\Models\Quota, OpenStack\Networking\v2\Models\Subnet, OpenStack\ObjectStore\v1\Models\Account, OpenStack\ObjectStore\v1\Models\Container, OpenStack\ObjectStore\v1\Models\Object.

Let’s take a look at an example:

interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the interface:

    interface User
    {
        /** @return string */
        public function getPassword();
    
        /** @return string */
        public function getDisplayName();
    }
    
Loading history...
359
    }
360
361
    /**
362
     * Retrieves metadata from the API.
363
     *
364
     * @return array
365
     */
366
    public function getMetadata(): array
367
    {
368
        $response = $this->execute($this->api->getServerMetadata(), ['id' => $this->id]);
369
        return $this->parseMetadata($response);
370
    }
371
372
    /**
373
     * Resets all the metadata for this server with the values provided. All existing metadata keys
374
     * will either be replaced or removed.
375
     *
376
     * @param array $metadata {@see \OpenStack\Compute\v2\Api::putServerMetadata}
377
     */
378
    public function resetMetadata(array $metadata)
379
    {
380
        $response = $this->execute($this->api->putServerMetadata(), ['id' => $this->id, 'metadata' => $metadata]);
381
        $this->metadata = $this->parseMetadata($response);
382
    }
383
384
    /**
385
     * Merges the existing metadata for the server with the values provided. Any existing keys
386
     * referenced in the user options will be replaced with the user's new values. All other
387
     * existing keys will remain unaffected.
388
     *
389
     * @param array $metadata {@see \OpenStack\Compute\v2\Api::postServerMetadata}
390
     *
391
     * @return array
392
     */
393
    public function mergeMetadata(array $metadata)
394
    {
395
        $response = $this->execute($this->api->postServerMetadata(), ['id' => $this->id, 'metadata' => $metadata]);
396
        $this->metadata = $this->parseMetadata($response);
397
    }
398
399
    /**
400
     * Retrieve the value for a specific metadata key.
401
     *
402
     * @param string $key {@see \OpenStack\Compute\v2\Api::getServerMetadataKey}
403
     *
404
     * @return mixed
405
     */
406 View Code Duplication
    public function getMetadataItem(string $key)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
407
    {
408
        $response = $this->execute($this->api->getServerMetadataKey(), ['id' => $this->id, 'key' => $key]);
409
        $value = $this->parseMetadata($response)[$key];
410
        $this->metadata[$key] = $value;
411
        return $value;
412
    }
413
414
    /**
415
     * Remove a specific metadata key.
416
     *
417
     * @param string $key {@see \OpenStack\Compute\v2\Api::deleteServerMetadataKey}
418
     */
419 View Code Duplication
    public function deleteMetadataItem(string $key)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
420
    {
421
        if (isset($this->metadata[$key])) {
422
            unset($this->metadata[$key]);
423
        }
424
425
        $this->execute($this->api->deleteServerMetadataKey(), ['id' => $this->id, 'key' => $key]);
426
    }
427
428
429
    /**
430
     * Add security group to a server (addSecurityGroup action)
431
     *
432
     * @param array $options {@see \OpenStack\Compute\v2\Api::postSecurityGroup}
433
     *
434
     * @return SecurityGroup
435
     */
436
    public function addSecurityGroup(array $options) : SecurityGroup
437
    {
438
        $options['id'] = $this->id;
439
440
        $response = $this->execute($this->api->postSecurityGroup(), $options);
441
442
        return $this->model(SecurityGroup::class)->populateFromResponse($response);
443
    }
444
445
    /**
446
     * Add security group to a server (addSecurityGroup action)
447
     *
448
     * @param array $options {@see \OpenStack\Compute\v2\Api::deleteSecurityGroup}
449
     */
450
    public function removeSecurityGroup(array $options)
451
    {
452
        $options['id'] = $this->id;
453
        $this->execute($this->api->deleteSecurityGroup(), $options);
454
    }
455
456
    public function parseMetadata(ResponseInterface $response): array
457
    {
458
        return Utils::jsonDecode($response)['metadata'];
459
    }
460
461
    /**
462
     * Returns Generator for SecurityGroups
463
     *
464
     * @return \Generator
465
     */
466
    public function listSecurityGroups(): \Generator
467
    {
468
        return $this->model(SecurityGroup::class)->enumerate($this->api->getSecurityGroups(), ['id' => $this->id]);
0 ignored issues
show
Bug introduced by
It seems like you code against a concrete implementation and not the interface OpenStack\Common\Resource\ResourceInterface as the method enumerate() does only exist in the following implementations of said interface: OpenStack\BlockStorage\v2\Models\QuotaSet, OpenStack\BlockStorage\v2\Models\Snapshot, OpenStack\BlockStorage\v2\Models\Volume, OpenStack\BlockStorage\v2\Models\VolumeAttachment, OpenStack\BlockStorage\v2\Models\VolumeType, OpenStack\Common\Resource\OperatorResource, OpenStack\Compute\v2\Models\AvailabilityZone, OpenStack\Compute\v2\Models\Flavor, OpenStack\Compute\v2\Models\Host, OpenStack\Compute\v2\Models\Hypervisor, OpenStack\Compute\v2\Models\HypervisorStatistic, OpenStack\Compute\v2\Models\Image, OpenStack\Compute\v2\Models\Keypair, OpenStack\Compute\v2\Models\QuotaSet, OpenStack\Compute\v2\Models\Server, OpenStack\Identity\v2\Models\Catalog, OpenStack\Identity\v2\Models\Endpoint, OpenStack\Identity\v2\Models\Entry, OpenStack\Identity\v2\Models\Tenant, OpenStack\Identity\v2\Models\Token, OpenStack\Identity\v3\Models\Assignment, OpenStack\Identity\v3\Models\Catalog, OpenStack\Identity\v3\Models\Credential, OpenStack\Identity\v3\Models\Domain, OpenStack\Identity\v3\Models\Endpoint, OpenStack\Identity\v3\Models\Group, OpenStack\Identity\v3\Models\Policy, OpenStack\Identity\v3\Models\Project, OpenStack\Identity\v3\Models\Role, OpenStack\Identity\v3\Models\Service, OpenStack\Identity\v3\Models\Token, OpenStack\Identity\v3\Models\User, OpenStack\Images\v2\Models\Image, OpenStack\Images\v2\Models\Member, OpenStack\Metric\v1\Gnocchi\Models\Metric, OpenStack\Metric\v1\Gnocchi\Models\Resource, OpenStack\Metric\v1\Gnocchi\Models\ResourceType, OpenStack\Networking\v2\...ayer3\Models\FloatingIp, OpenStack\Networking\v2\...ns\Layer3\Models\Router, OpenStack\Networking\v2\...ps\Models\SecurityGroup, OpenStack\Networking\v2\...odels\SecurityGroupRule, OpenStack\Networking\v2\Models\InterfaceAttachment, OpenStack\Networking\v2\Models\LoadBalancer, OpenStack\Networking\v2\...adBalancerHealthMonitor, OpenStack\Networking\v2\...ls\LoadBalancerListener, OpenStack\Networking\v2\Models\LoadBalancerMember, OpenStack\Networking\v2\Models\LoadBalancerPool, OpenStack\Networking\v2\Models\LoadBalancerStat, OpenStack\Networking\v2\Models\LoadBalancerStatus, OpenStack\Networking\v2\Models\Network, OpenStack\Networking\v2\Models\Port, OpenStack\Networking\v2\Models\Quota, OpenStack\Networking\v2\Models\Subnet, OpenStack\ObjectStore\v1\Models\Account, OpenStack\ObjectStore\v1\Models\Container, OpenStack\ObjectStore\v1\Models\Object.

Let’s take a look at an example:

interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the interface:

    interface User
    {
        /** @return string */
        public function getPassword();
    
        /** @return string */
        public function getDisplayName();
    }
    
Loading history...
469
    }
470
471
472
    /**
473
     * Returns Generator for VolumeAttachment
474
     *
475
     * @return \Generator
476
     */
477
    public function listVolumeAttachments(): \Generator
478
    {
479
        return $this->model(VolumeAttachment::class)->enumerate($this->api->getVolumeAttachments(), ['id' => $this->id]);
0 ignored issues
show
Bug introduced by
It seems like you code against a concrete implementation and not the interface OpenStack\Common\Resource\ResourceInterface as the method enumerate() does only exist in the following implementations of said interface: OpenStack\BlockStorage\v2\Models\QuotaSet, OpenStack\BlockStorage\v2\Models\Snapshot, OpenStack\BlockStorage\v2\Models\Volume, OpenStack\BlockStorage\v2\Models\VolumeAttachment, OpenStack\BlockStorage\v2\Models\VolumeType, OpenStack\Common\Resource\OperatorResource, OpenStack\Compute\v2\Models\AvailabilityZone, OpenStack\Compute\v2\Models\Flavor, OpenStack\Compute\v2\Models\Host, OpenStack\Compute\v2\Models\Hypervisor, OpenStack\Compute\v2\Models\HypervisorStatistic, OpenStack\Compute\v2\Models\Image, OpenStack\Compute\v2\Models\Keypair, OpenStack\Compute\v2\Models\QuotaSet, OpenStack\Compute\v2\Models\Server, OpenStack\Identity\v2\Models\Catalog, OpenStack\Identity\v2\Models\Endpoint, OpenStack\Identity\v2\Models\Entry, OpenStack\Identity\v2\Models\Tenant, OpenStack\Identity\v2\Models\Token, OpenStack\Identity\v3\Models\Assignment, OpenStack\Identity\v3\Models\Catalog, OpenStack\Identity\v3\Models\Credential, OpenStack\Identity\v3\Models\Domain, OpenStack\Identity\v3\Models\Endpoint, OpenStack\Identity\v3\Models\Group, OpenStack\Identity\v3\Models\Policy, OpenStack\Identity\v3\Models\Project, OpenStack\Identity\v3\Models\Role, OpenStack\Identity\v3\Models\Service, OpenStack\Identity\v3\Models\Token, OpenStack\Identity\v3\Models\User, OpenStack\Images\v2\Models\Image, OpenStack\Images\v2\Models\Member, OpenStack\Metric\v1\Gnocchi\Models\Metric, OpenStack\Metric\v1\Gnocchi\Models\Resource, OpenStack\Metric\v1\Gnocchi\Models\ResourceType, OpenStack\Networking\v2\...ayer3\Models\FloatingIp, OpenStack\Networking\v2\...ns\Layer3\Models\Router, OpenStack\Networking\v2\...ps\Models\SecurityGroup, OpenStack\Networking\v2\...odels\SecurityGroupRule, OpenStack\Networking\v2\Models\InterfaceAttachment, OpenStack\Networking\v2\Models\LoadBalancer, OpenStack\Networking\v2\...adBalancerHealthMonitor, OpenStack\Networking\v2\...ls\LoadBalancerListener, OpenStack\Networking\v2\Models\LoadBalancerMember, OpenStack\Networking\v2\Models\LoadBalancerPool, OpenStack\Networking\v2\Models\LoadBalancerStat, OpenStack\Networking\v2\Models\LoadBalancerStatus, OpenStack\Networking\v2\Models\Network, OpenStack\Networking\v2\Models\Port, OpenStack\Networking\v2\Models\Quota, OpenStack\Networking\v2\Models\Subnet, OpenStack\ObjectStore\v1\Models\Account, OpenStack\ObjectStore\v1\Models\Container, OpenStack\ObjectStore\v1\Models\Object.

Let’s take a look at an example:

interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the interface:

    interface User
    {
        /** @return string */
        public function getPassword();
    
        /** @return string */
        public function getDisplayName();
    }
    
Loading history...
480
    }
481
482
    /**
483
     * Attach a volume and returns volume that was attached
484
     *
485
     * @param $volumeId
486
     *
487
     * @return VolumeAttachment
488
     */
489
    public function attachVolume(string $volumeId): VolumeAttachment
490
    {
491
        $response =  $this->execute($this->api->postVolumeAttachments(), ['id' => $this->id, 'volumeId' => $volumeId]);
492
493
        return $this->model(VolumeAttachment::class)->populateFromResponse($response);
494
    }
495
496
    /**
497
     * Detach a volume
498
     *
499
     * @param $attachmentId
500
     *
501
     * @return void
502
     */
503
    public function detachVolume(string $attachmentId)
504
    {
505
        $this->execute($this->api->deleteVolumeAttachments(), ['id' => $this->id, 'attachmentId' => $attachmentId]);
506
    }
507
}
508