Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php declare(strict_types=1); |
||
22 | class Server extends OperatorResource implements |
||
23 | Creatable, |
||
24 | Updateable, |
||
25 | Deletable, |
||
26 | Retrievable, |
||
27 | Listable |
||
28 | { |
||
29 | use HasWaiterTrait; |
||
30 | |||
31 | /** @var string */ |
||
32 | public $id; |
||
33 | |||
34 | /** @var string */ |
||
35 | public $ipv4; |
||
36 | |||
37 | /** @var string */ |
||
38 | public $ipv6; |
||
39 | |||
40 | /** @var array */ |
||
41 | public $addresses; |
||
42 | |||
43 | /** @var \DateTimeImmutable */ |
||
44 | public $created; |
||
45 | |||
46 | /** @var \DateTimeImmutable */ |
||
47 | public $updated; |
||
48 | |||
49 | /** @var Flavor */ |
||
50 | public $flavor; |
||
51 | |||
52 | /** @var string */ |
||
53 | public $hostId; |
||
54 | |||
55 | /** @var string */ |
||
56 | public $hypervisorHostname; |
||
57 | |||
58 | /** @var Image */ |
||
59 | public $image; |
||
60 | |||
61 | /** @var array */ |
||
62 | public $links; |
||
63 | |||
64 | /** @var array */ |
||
65 | public $metadata; |
||
66 | |||
67 | /** @var string */ |
||
68 | public $name; |
||
69 | |||
70 | /** @var string */ |
||
71 | public $progress; |
||
72 | |||
73 | /** @var string */ |
||
74 | public $status; |
||
75 | |||
76 | /** @var string */ |
||
77 | public $tenantId; |
||
78 | |||
79 | /** @var string */ |
||
80 | public $userId; |
||
81 | |||
82 | /** @var string */ |
||
83 | public $adminPass; |
||
84 | |||
85 | /** @var string */ |
||
86 | public $taskState; |
||
87 | |||
88 | protected $resourceKey = 'server'; |
||
89 | protected $resourcesKey = 'servers'; |
||
90 | protected $markerKey = 'id'; |
||
91 | |||
92 | protected $aliases = [ |
||
93 | 'block_device_mapping_v2' => 'blockDeviceMapping', |
||
94 | 'accessIPv4' => 'ipv4', |
||
95 | 'accessIPv6' => 'ipv6', |
||
96 | 'tenant_id' => 'tenantId', |
||
97 | 'user_id' => 'userId', |
||
98 | 'security_groups' => 'securityGroups', |
||
99 | 'OS-EXT-STS:task_state' => 'taskState', |
||
100 | 'OS-EXT-SRV-ATTR:hypervisor_hostname' => 'hypervisorHostname', |
||
101 | 2 | ]; |
|
102 | |||
103 | 2 | /** |
|
104 | 2 | * {@inheritDoc} |
|
105 | * |
||
106 | * @param array $userOptions {@see \OpenStack\Compute\v2\Api::postServer} |
||
107 | */ |
||
108 | public function create(array $userOptions): Creatable |
||
117 | |||
118 | /** |
||
119 | * {@inheritDoc} |
||
120 | 1 | */ |
|
121 | public function update() |
||
126 | |||
127 | /** |
||
128 | 1 | * {@inheritDoc} |
|
129 | */ |
||
130 | 1 | public function delete() |
|
134 | |||
135 | /** |
||
136 | * {@inheritDoc} |
||
137 | */ |
||
138 | public function retrieve() |
||
143 | 1 | ||
144 | /** |
||
145 | 1 | * Changes the root password for a server. |
|
146 | 1 | * |
|
147 | * @param string $newPassword The new root password |
||
148 | */ |
||
149 | public function changePassword(string $newPassword) |
||
156 | 1 | ||
157 | /** |
||
158 | * Reboots the server. |
||
159 | 1 | * |
|
160 | 1 | * @param string $type The type of reboot that will be performed. Either SOFT or HARD is supported. |
|
161 | 1 | */ |
|
162 | 1 | public function reboot(string $type = Enum::REBOOT_SOFT) |
|
173 | 1 | ||
174 | /** |
||
175 | 1 | * Starts server |
|
176 | 1 | */ |
|
177 | public function start() |
||
184 | 1 | ||
185 | /** |
||
186 | 1 | * Stops server |
|
187 | 1 | */ |
|
188 | 1 | public function stop() |
|
195 | |||
196 | /** |
||
197 | 1 | * Suspend server |
|
198 | */ |
||
199 | 1 | public function suspend() |
|
206 | |||
207 | 1 | /** |
|
208 | 1 | * Resume server |
|
209 | */ |
||
210 | public function resume() |
||
217 | 1 | ||
218 | 1 | /** |
|
219 | 1 | * Rebuilds the server. |
|
220 | * |
||
221 | * @param array $options {@see \OpenStack\Compute\v2\Api::rebuildServer} |
||
222 | */ |
||
223 | public function rebuild(array $options) |
||
230 | 2 | ||
231 | /** |
||
232 | 2 | * Resizes the server to a new flavor. Once this operation is complete and server has transitioned |
|
233 | 2 | * to an active state, you will either need to call {@see confirmResize()} or {@see revertResize()}. |
|
234 | 2 | * |
|
235 | * @param string $flavorId The UUID of the new flavor your server will be based on. |
||
236 | */ |
||
237 | public function resize(string $flavorId) |
||
246 | |||
247 | /** |
||
248 | * Confirms a previous resize operation. |
||
249 | */ |
||
250 | public function confirmResize() |
||
254 | |||
255 | /** |
||
256 | 1 | * Reverts a previous resize operation. |
|
257 | */ |
||
258 | 1 | public function revertResize() |
|
262 | |||
263 | /** |
||
264 | * Gets a VNC console for a server. |
||
265 | * |
||
266 | * @param string $type The type of VNC console: novnc|xvpvnc. |
||
267 | * Defaults to novnc. |
||
268 | * |
||
269 | * @return array |
||
270 | */ |
||
271 | 1 | public function getVncConsole($type = Enum::CONSOLE_NOVNC): array |
|
276 | |||
277 | /** |
||
278 | * Gets a RDP console for a server. |
||
279 | * |
||
280 | * @param string $type The type of VNC console: rdp-html5 (default). |
||
281 | * |
||
282 | * @return array |
||
283 | */ |
||
284 | 1 | public function getRDPConsole($type = Enum::CONSOLE_RDP_HTML5): array |
|
289 | |||
290 | /** |
||
291 | * Gets a Spice console for a server. |
||
292 | * |
||
293 | * @param string $type The type of VNC console: spice-html5. |
||
294 | * |
||
295 | 1 | * @return array |
|
296 | */ |
||
297 | 1 | public function getSpiceConsole($type = Enum::CONSOLE_SPICE_HTML5): array |
|
302 | |||
303 | /** |
||
304 | * Gets a serial console for a server. |
||
305 | * |
||
306 | * @param string $type The type of VNC console: serial. |
||
307 | * |
||
308 | * @return array |
||
309 | */ |
||
310 | public function getSerialConsole($type = Enum::CONSOLE_SERIAL): array |
||
315 | |||
316 | /** |
||
317 | * Creates an image for the current server. |
||
318 | * |
||
319 | * @param array $options {@see \OpenStack\Compute\v2\Api::createServerImage} |
||
320 | */ |
||
321 | public function createImage(array $options) |
||
326 | |||
327 | /** |
||
328 | * Iterates over all the IP addresses for this server. |
||
329 | * |
||
330 | * @param array $options {@see \OpenStack\Compute\v2\Api::getAddressesByNetwork} |
||
331 | * |
||
332 | * @return array An array containing to two keys: "public" and "private" |
||
333 | */ |
||
334 | public function listAddresses(array $options = []): array |
||
342 | |||
343 | /** |
||
344 | * Returns Generator for InterfaceAttachment |
||
345 | * |
||
346 | * @return \Generator |
||
347 | */ |
||
348 | public function listInterfaceAttachments(array $options = []): \Generator |
||
352 | |||
353 | /** |
||
354 | * Retrieves metadata from the API. |
||
355 | * |
||
356 | * @return array |
||
357 | */ |
||
358 | public function getMetadata(): array |
||
363 | |||
364 | /** |
||
365 | * Resets all the metadata for this server with the values provided. All existing metadata keys |
||
366 | * will either be replaced or removed. |
||
367 | * |
||
368 | * @param array $metadata {@see \OpenStack\Compute\v2\Api::putServerMetadata} |
||
369 | */ |
||
370 | public function resetMetadata(array $metadata) |
||
375 | |||
376 | /** |
||
377 | * Merges the existing metadata for the server with the values provided. Any existing keys |
||
378 | * referenced in the user options will be replaced with the user's new values. All other |
||
379 | * existing keys will remain unaffected. |
||
380 | * |
||
381 | * @param array $metadata {@see \OpenStack\Compute\v2\Api::postServerMetadata} |
||
382 | * |
||
383 | * @return array |
||
384 | */ |
||
385 | public function mergeMetadata(array $metadata) |
||
390 | |||
391 | /** |
||
392 | * Retrieve the value for a specific metadata key. |
||
393 | * |
||
394 | * @param string $key {@see \OpenStack\Compute\v2\Api::getServerMetadataKey} |
||
395 | * |
||
396 | * @return mixed |
||
397 | */ |
||
398 | View Code Duplication | public function getMetadataItem(string $key) |
|
405 | |||
406 | /** |
||
407 | * Remove a specific metadata key. |
||
408 | * |
||
409 | * @param string $key {@see \OpenStack\Compute\v2\Api::deleteServerMetadataKey} |
||
410 | */ |
||
411 | View Code Duplication | public function deleteMetadataItem(string $key) |
|
419 | |||
420 | |||
421 | /** |
||
422 | * Add security group to a server (addSecurityGroup action) |
||
423 | * |
||
424 | * @param array $options {@see \OpenStack\Compute\v2\Api::postSecurityGroup} |
||
425 | * |
||
426 | * @return SecurityGroup |
||
427 | */ |
||
428 | public function addSecurityGroup(array $options) : SecurityGroup |
||
436 | |||
437 | /** |
||
438 | * Add security group to a server (addSecurityGroup action) |
||
439 | * |
||
440 | * @param array $options {@see \OpenStack\Compute\v2\Api::deleteSecurityGroup} |
||
441 | */ |
||
442 | public function removeSecurityGroup(array $options) |
||
447 | |||
448 | public function parseMetadata(ResponseInterface $response): array |
||
452 | |||
453 | /** |
||
454 | * Returns Generator for SecurityGroups |
||
455 | * |
||
456 | * @return \Generator |
||
457 | */ |
||
458 | public function listSecurityGroups(): \Generator |
||
462 | |||
463 | |||
464 | /** |
||
465 | * Returns Generator for VolumeAttachment |
||
466 | * |
||
467 | * @return \Generator |
||
468 | */ |
||
469 | public function listVolumeAttachments(): \Generator |
||
473 | |||
474 | /** |
||
475 | * Attach a volume and returns volume that was attached |
||
476 | * |
||
477 | * @param $volumeId |
||
478 | * |
||
479 | * @return VolumeAttachment |
||
480 | */ |
||
481 | public function attachVolume(string $volumeId): VolumeAttachment |
||
487 | |||
488 | /** |
||
489 | * Detach a volume |
||
490 | * |
||
491 | * @param $attachmentId |
||
492 | * |
||
493 | * @return void |
||
494 | */ |
||
495 | public function detachVolume(string $attachmentId) |
||
499 | } |
||
500 |
This check looks from parameters that have been defined for a function or method, but which are not used in the method body.