OpenStack\Common\Resource\Alias

Complexity

Total Complexity

10

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	3
B	getValue()	0	16	7

<?php declare(strict_types=1);

namespace OpenStack\Common\Resource;

/**
 * @package OpenStack\Common\Resource
 */
class Alias
{
    /**
     * @var string
     */
    public $propertyName;

    /**
     * @var bool
     */
    private $isList;

    /**
     * @var string
     */
    private $className;

    /**
     * @param string      $propertyName A name of the property in target resource class
     * @param string|null $className    A class name for the property value
     * @param bool        $list         Whether value of the property should be treated as a list or not
     */
    public function __construct(string $propertyName, string $className = null, bool $list = false)
    {
        $this->isList = $list;
        $this->propertyName = $propertyName;
        $this->className = $className && class_exists($className) ? $className : null;

The expression $className of type null|string is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

    }

    /**
     * @param ResourceInterface $resource
     * @param mixed             $value
     *
     * @return mixed
     */
    public function getValue(ResourceInterface $resource, $value)
    {
        if ($value === null || !$this->className) {
            return $value;
        } elseif ($this->isList && is_array($value)) {
            $array = [];
            foreach ($value as $subVal) {
                $array[] = $resource->model($this->className, $subVal);
            }
            return $array;
        } elseif ($this->className === \DateTimeImmutable::class) {
            return new \DateTimeImmutable($value);
        }

        return $resource->model($this->className, $value);
    }
}