GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Completed
Pull Request — master (#152)
by Chris
01:56
created

Server::start()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 7
Code Lines 4

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 5
CRAP Score 1

Importance

Changes 0
Metric Value
dl 0
loc 7
ccs 5
cts 5
cp 1
rs 9.4285
c 0
b 0
f 0
cc 1
eloc 4
nc 1
nop 0
crap 1
1
<?php declare(strict_types=1);
2
3
namespace OpenStack\Compute\v2\Models;
4
5
use OpenStack\Common\Resource\HasWaiterTrait;
6
use OpenStack\Common\Resource\Creatable;
7
use OpenStack\Common\Resource\Deletable;
8
use OpenStack\Common\Resource\Listable;
9
use OpenStack\Common\Resource\Retrievable;
10
use OpenStack\Common\Resource\Updateable;
11
use OpenStack\Common\Resource\OperatorResource;
12
use OpenStack\Common\Transport\Utils;
13
use OpenStack\BlockStorage\v2\Models\VolumeAttachment;
14
use OpenStack\Networking\v2\Models\InterfaceAttachment;
15
use OpenStack\Compute\v2\Enum;
16
use OpenStack\Networking\v2\Extensions\SecurityGroups\Models\SecurityGroup;
17
use Psr\Http\Message\ResponseInterface;
18
19
/**
20
 * @property \OpenStack\Compute\v2\Api $api
21
 */
22
class Server extends OperatorResource implements
23
    Creatable,
24
    Updateable,
25
    Deletable,
26
    Retrievable,
27
    Listable
28
{
29
    use HasWaiterTrait;
30
31
    /** @var string */
32
    public $id;
33
34
    /** @var string */
35
    public $ipv4;
36
37
    /** @var string */
38
    public $ipv6;
39
40
    /** @var array */
41
    public $addresses;
42
43
    /** @var \DateTimeImmutable */
44
    public $created;
45
46
    /** @var \DateTimeImmutable */
47
    public $updated;
48
49
    /** @var Flavor */
50
    public $flavor;
51
52
    /** @var string */
53
    public $hostId;
54
55
    /** @var string */
56
    public $hypervisorHostname;
57
58
    /** @var Image */
59
    public $image;
60
61
    /** @var array */
62
    public $links;
63
64
    /** @var array */
65
    public $metadata;
66
67
    /** @var string */
68
    public $name;
69
70
    /** @var string */
71
    public $progress;
72
73
    /** @var string */
74
    public $status;
75
76
    /** @var string */
77
    public $tenantId;
78
79
    /** @var string */
80
    public $userId;
81
82
    /** @var string */
83
    public $adminPass;
84
85
    /** @var string */
86
    public $taskState;
87
88
    /** @var string */
89
    public $powerState;
90
91
    /** @var string */
92
    public $vmState;
93
94
    protected $resourceKey = 'server';
95
    protected $resourcesKey = 'servers';
96
    protected $markerKey = 'id';
97
98
    protected $aliases = [
99
        'block_device_mapping_v2'             => 'blockDeviceMapping',
100
        'accessIPv4'                          => 'ipv4',
101 2
        'accessIPv6'                          => 'ipv6',
102
        'tenant_id'                           => 'tenantId',
103 2
        'user_id'                             => 'userId',
104 2
        'security_groups'                     => 'securityGroups',
105
        'OS-EXT-STS:task_state'               => 'taskState',
106
        'OS-EXT-STS:power_state'              => 'powerState',
107
        'OS-EXT-STS:vm_state'                 => 'vmState',
108
        'OS-EXT-SRV-ATTR:hypervisor_hostname' => 'hypervisorHostname',
109
    ];
110 1
111
    /**
112 1
     * {@inheritDoc}
113
     *
114 1
     * @param array $userOptions {@see \OpenStack\Compute\v2\Api::postServer}
115
     */
116
    public function create(array $userOptions): Creatable
117
    {
118
        if (!isset($userOptions['imageId']) && !isset($userOptions['blockDeviceMapping'][0]['uuid'])) {
119
            throw new \RuntimeException('imageId or blockDeviceMapping.uuid must be set.');
120 1
        }
121
122 1
        $response = $this->execute($this->api->postServer(), $userOptions);
123 1
        return $this->populateFromResponse($response);
124
    }
125
126
    /**
127
     * {@inheritDoc}
128 1
     */
129
    public function update()
130 1
    {
131
        $response = $this->execute($this->api->putServer(), $this->getAttrs(['id', 'name', 'ipv4', 'ipv6']));
132 1
        $this->populateFromResponse($response);
133
    }
134
135
    /**
136
     * {@inheritDoc}
137
     */
138
    public function delete()
139
    {
140 1
        $this->execute($this->api->deleteServer(), $this->getAttrs(['id']));
141
    }
142 1
143 1
    /**
144
     * {@inheritDoc}
145 1
     */
146 1
    public function retrieve()
147
    {
148
        $response = $this->execute($this->api->getServer(), $this->getAttrs(['id']));
149
        $this->populateFromResponse($response);
150
    }
151
152
    /**
153 2
     * Changes the root password for a server.
154
     *
155 2
     * @param string $newPassword The new root password
156 1
     */
157
    public function changePassword(string $newPassword)
158
    {
159 1
        $this->execute($this->api->changeServerPassword(), [
160 1
            'id'       => $this->id,
161 1
            'password' => $newPassword,
162 1
        ]);
163 1
    }
164
165
    /**
166
     * Reboots the server.
167
     *
168
     * @param string $type The type of reboot that will be performed. Either SOFT or HARD is supported.
169
     */
170 1
    public function reboot(string $type = Enum::REBOOT_SOFT)
171
    {
172 1
        if (!in_array($type, ['SOFT', 'HARD'])) {
173 1
            throw new \RuntimeException('Reboot type must either be SOFT or HARD');
174
        }
175 1
176 1
        $this->execute($this->api->rebootServer(), [
177
            'id'   => $this->id,
178
            'type' => $type,
179
        ]);
180
    }
181
182
    /**
183
     * Starts server
184 1
     */
185
    public function start()
186 1
    {
187 1
        $this->execute($this->api->startServer(), [
188 1
            'id' => $this->id,
189 1
            'os-start' => null
190
        ]);
191 1
    }
192 1
193
    /**
194
     * Stops server
195
     */
196
    public function stop()
197 1
    {
198
        $this->execute($this->api->stopServer(), [
199 1
            'id' => $this->id,
200 1
            'os-stop' => null
201
        ]);
202
    }
203
204
    /**
205 1
     * Shelves server
206
     */
207 1
    public function shelve()
208 1
    {
209
        $this->execute($this->api->shelveServer(), [
210
            'id' => $this->id,
211
            'shelve' => null
212
        ]);
213
    }
214
215 1
    /*
216
     * Suspend server
217 1
     */
218 1
    public function suspend()
219 1
    {
220
        $this->execute($this->api->suspendServer(), [
221
            'id' => $this->id,
222
            'suspend' => null
223
        ]);
224
    }
225
226
    /**
227
     * Shelf-offloads server
228 2
     */
229
    public function shelveOffload()
230 2
    {
231
        $this->execute($this->api->shelveOffloadServer(), [
232 2
            'id' => $this->id,
233 2
            'shelveOffload' => null
234 2
        ]);
235
    }
236
237
    /**
238
     * Unshelves server
239
     */
240
    public function unshelve()
241
    {
242 1
        $this->execute($this->api->unshelveServer(), [
243
            'id' => $this->id,
244 1
            'unshelve' => null
245 1
        ]);
246
    }
247
248
    /*
249
     * Resume server
250
     */
251
    public function resume()
252
    {
253
        $this->execute($this->api->resumeServer(), [
254
            'id' => $this->id,
255
            'resume' => null
256 1
        ]);
257
    }
258 1
259 1
    /**
260
     * Rebuilds the server.
261
     *
262
     * @param array $options {@see \OpenStack\Compute\v2\Api::rebuildServer}
263
     */
264
    public function rebuild(array $options)
265
    {
266
        $options['id'] = $this->id;
267
        $response = $this->execute($this->api->rebuildServer(), $options);
268
269
        $this->populateFromResponse($response);
270
    }
271 1
272
    /**
273 1
     * Resizes the server to a new flavor. Once this operation is complete and server has transitioned
274 1
     * to an active state, you will either need to call {@see confirmResize()} or {@see revertResize()}.
275
     *
276
     * @param string $flavorId The UUID of the new flavor your server will be based on.
277
     */
278
    public function resize(string $flavorId)
279
    {
280
        $response = $this->execute($this->api->resizeServer(), [
281
            'id'       => $this->id,
282
            'flavorId' => $flavorId,
283
        ]);
284 1
285
        $this->populateFromResponse($response);
286 1
    }
287 1
288
    /**
289
     * Confirms a previous resize operation.
290
     */
291
    public function confirmResize()
292
    {
293
        $this->execute($this->api->confirmServerResize(), ['confirmResize' => null, 'id' => $this->id]);
294
    }
295 1
296
    /**
297 1
     * Reverts a previous resize operation.
298 1
     */
299
    public function revertResize()
300
    {
301
        $this->execute($this->api->revertServerResize(), ['revertResize' => null, 'id' => $this->id]);
302
    }
303
304
    /**
305
     * Gets a VNC console for a server.
306
     *
307
     * @param  string $type The type of VNC console: novnc|xvpvnc.
308
     *                      Defaults to novnc.
309
     *
310
     * @return array
311
     */
312
    public function getVncConsole($type = Enum::CONSOLE_NOVNC): array
313
    {
314
        $response = $this->execute($this->api->getVncConsole(), ['id' => $this->id, 'type' => $type]);
315
        return Utils::jsonDecode($response)['console'];
316
    }
317
318
    /**
319
     * Gets a RDP console for a server.
320
     *
321
     * @param  string $type The type of VNC console: rdp-html5 (default).
322
     *
323
     * @return array
324
     */
325
    public function getRDPConsole($type = Enum::CONSOLE_RDP_HTML5): array
326
    {
327
        $response = $this->execute($this->api->getRDPConsole(), ['id' => $this->id, 'type' => $type]);
328
        return Utils::jsonDecode($response)['console'];
329
    }
330
331
    /**
332
     * Gets a Spice console for a server.
333
     *
334
     * @param  string $type The type of VNC console: spice-html5.
335
     *
336
     * @return array
337
     */
338
    public function getSpiceConsole($type = Enum::CONSOLE_SPICE_HTML5): array
339
    {
340
        $response = $this->execute($this->api->getSpiceConsole(), ['id' => $this->id, 'type' => $type]);
341
        return Utils::jsonDecode($response)['console'];
342
    }
343
344
    /**
345
     * Gets a serial console for a server.
346
     *
347
     * @param  string $type The type of VNC console: serial.
348
     *
349
     * @return array
350
     */
351
    public function getSerialConsole($type = Enum::CONSOLE_SERIAL): array
352
    {
353
        $response = $this->execute($this->api->getSerialConsole(), ['id' => $this->id, 'type' => $type]);
354
        return Utils::jsonDecode($response)['console'];
355
    }
356
357
    /**
358
     * Get the console log.
359
     *
360
     * @param int $length Number of lines of console log to grab.
361
     *
362
     * @return string - the console log output
363
     */
364
    public function getConsoleLog(int $length = 50): string {
365
        $response = $this->execute($this->api->getConsoleLog(), ['id' => $this->id, 'length' => $length]);
366
        return Utils::jsonDecode($response)['output'];
367
    }
368
369
    /**
370
     * Creates an image for the current server.
371
     *
372
     * @param array $options {@see \OpenStack\Compute\v2\Api::createServerImage}
373
     */
374
    public function createImage(array $options)
375
    {
376
        $options['id'] = $this->id;
377
        $this->execute($this->api->createServerImage(), $options);
378
    }
379
380
    /**
381
     * Iterates over all the IP addresses for this server.
382
     *
383
     * @param array $options {@see \OpenStack\Compute\v2\Api::getAddressesByNetwork}
384
     *
385
     * @return array An array containing to two keys: "public" and "private"
386
     */
387
    public function listAddresses(array $options = []): array
388
    {
389
        $options['id'] = $this->id;
390
391
        $data = (isset($options['networkLabel'])) ? $this->api->getAddressesByNetwork() : $this->api->getAddresses();
392
        $response = $this->execute($data, $options);
393
        return Utils::jsonDecode($response)['addresses'];
394
    }
395
396
    /**
397
     * Returns Generator for InterfaceAttachment
398
     *
399
     * @return \Generator
400
     */
401
    public function listInterfaceAttachments(array $options = []): \Generator
0 ignored issues
show
Unused Code introduced by
The parameter $options is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
402
    {
403
        return $this->model(InterfaceAttachment::class)->enumerate($this->api->getInterfaceAttachments(), ['id' => $this->id]);
0 ignored issues
show
Bug introduced by
It seems like you code against a concrete implementation and not the interface OpenStack\Common\Resource\ResourceInterface as the method enumerate() does only exist in the following implementations of said interface: OpenStack\BlockStorage\v2\Models\QuotaSet, OpenStack\BlockStorage\v2\Models\Snapshot, OpenStack\BlockStorage\v2\Models\Volume, OpenStack\BlockStorage\v2\Models\VolumeAttachment, OpenStack\BlockStorage\v2\Models\VolumeType, OpenStack\Common\Resource\OperatorResource, OpenStack\Compute\v2\Models\AvailabilityZone, OpenStack\Compute\v2\Models\Flavor, OpenStack\Compute\v2\Models\Host, OpenStack\Compute\v2\Models\Hypervisor, OpenStack\Compute\v2\Models\HypervisorStatistic, OpenStack\Compute\v2\Models\Image, OpenStack\Compute\v2\Models\Keypair, OpenStack\Compute\v2\Models\QuotaSet, OpenStack\Compute\v2\Models\Server, OpenStack\Identity\v2\Models\Catalog, OpenStack\Identity\v2\Models\Endpoint, OpenStack\Identity\v2\Models\Entry, OpenStack\Identity\v2\Models\Tenant, OpenStack\Identity\v2\Models\Token, OpenStack\Identity\v3\Models\Assignment, OpenStack\Identity\v3\Models\Catalog, OpenStack\Identity\v3\Models\Credential, OpenStack\Identity\v3\Models\Domain, OpenStack\Identity\v3\Models\Endpoint, OpenStack\Identity\v3\Models\Group, OpenStack\Identity\v3\Models\Policy, OpenStack\Identity\v3\Models\Project, OpenStack\Identity\v3\Models\Role, OpenStack\Identity\v3\Models\Service, OpenStack\Identity\v3\Models\Token, OpenStack\Identity\v3\Models\User, OpenStack\Images\v2\Models\Image, OpenStack\Images\v2\Models\Member, OpenStack\Metric\v1\Gnocchi\Models\Metric, OpenStack\Metric\v1\Gnocchi\Models\Resource, OpenStack\Metric\v1\Gnocchi\Models\ResourceType, OpenStack\Networking\v2\...ayer3\Models\FloatingIp, OpenStack\Networking\v2\...ns\Layer3\Models\Router, OpenStack\Networking\v2\...ps\Models\SecurityGroup, OpenStack\Networking\v2\...odels\SecurityGroupRule, OpenStack\Networking\v2\Models\InterfaceAttachment, OpenStack\Networking\v2\Models\LoadBalancer, OpenStack\Networking\v2\...adBalancerHealthMonitor, OpenStack\Networking\v2\...ls\LoadBalancerListener, OpenStack\Networking\v2\Models\LoadBalancerMember, OpenStack\Networking\v2\Models\LoadBalancerPool, OpenStack\Networking\v2\Models\LoadBalancerStat, OpenStack\Networking\v2\Models\LoadBalancerStatus, OpenStack\Networking\v2\Models\Network, OpenStack\Networking\v2\...s\NetworkIpAvailability, OpenStack\Networking\v2\Models\Port, OpenStack\Networking\v2\Models\Quota, OpenStack\Networking\v2\Models\Subnet, OpenStack\ObjectStore\v1\Models\Account, OpenStack\ObjectStore\v1\Models\Container, OpenStack\ObjectStore\v1\Models\Object.

Let’s take a look at an example:

interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the interface:

    interface User
    {
        /** @return string */
        public function getPassword();
    
        /** @return string */
        public function getDisplayName();
    }
    
Loading history...
404
    }
405
406
    /**
407
     * Retrieves metadata from the API.
408
     *
409
     * @return array
410
     */
411
    public function getMetadata(): array
412
    {
413
        $response = $this->execute($this->api->getServerMetadata(), ['id' => $this->id]);
414
        return $this->parseMetadata($response);
415
    }
416
417
    /**
418
     * Resets all the metadata for this server with the values provided. All existing metadata keys
419
     * will either be replaced or removed.
420
     *
421
     * @param array $metadata {@see \OpenStack\Compute\v2\Api::putServerMetadata}
422
     */
423
    public function resetMetadata(array $metadata)
424
    {
425
        $response = $this->execute($this->api->putServerMetadata(), ['id' => $this->id, 'metadata' => $metadata]);
426
        $this->metadata = $this->parseMetadata($response);
427
    }
428
429
    /**
430
     * Merges the existing metadata for the server with the values provided. Any existing keys
431
     * referenced in the user options will be replaced with the user's new values. All other
432
     * existing keys will remain unaffected.
433
     *
434
     * @param array $metadata {@see \OpenStack\Compute\v2\Api::postServerMetadata}
435
     *
436
     * @return array
437
     */
438
    public function mergeMetadata(array $metadata)
439
    {
440
        $response = $this->execute($this->api->postServerMetadata(), ['id' => $this->id, 'metadata' => $metadata]);
441
        $this->metadata = $this->parseMetadata($response);
442
    }
443
444
    /**
445
     * Retrieve the value for a specific metadata key.
446
     *
447
     * @param string $key {@see \OpenStack\Compute\v2\Api::getServerMetadataKey}
448
     *
449
     * @return mixed
450
     */
451 View Code Duplication
    public function getMetadataItem(string $key)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
452
    {
453
        $response = $this->execute($this->api->getServerMetadataKey(), ['id' => $this->id, 'key' => $key]);
454
        $value = $this->parseMetadata($response)[$key];
455
        $this->metadata[$key] = $value;
456
        return $value;
457
    }
458
459
    /**
460
     * Remove a specific metadata key.
461
     *
462
     * @param string $key {@see \OpenStack\Compute\v2\Api::deleteServerMetadataKey}
463
     */
464 View Code Duplication
    public function deleteMetadataItem(string $key)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
465
    {
466
        if (isset($this->metadata[$key])) {
467
            unset($this->metadata[$key]);
468
        }
469
470
        $this->execute($this->api->deleteServerMetadataKey(), ['id' => $this->id, 'key' => $key]);
471
    }
472
473
474
    /**
475
     * Add security group to a server (addSecurityGroup action)
476
     *
477
     * @param array $options {@see \OpenStack\Compute\v2\Api::postSecurityGroup}
478
     *
479
     * @return SecurityGroup
480
     */
481
    public function addSecurityGroup(array $options) : SecurityGroup
482
    {
483
        $options['id'] = $this->id;
484
485
        $response = $this->execute($this->api->postSecurityGroup(), $options);
486
487
        return $this->model(SecurityGroup::class)->populateFromResponse($response);
488
    }
489
490
    /**
491
     * Add security group to a server (addSecurityGroup action)
492
     *
493
     * @param array $options {@see \OpenStack\Compute\v2\Api::deleteSecurityGroup}
494
     */
495
    public function removeSecurityGroup(array $options)
496
    {
497
        $options['id'] = $this->id;
498
        $this->execute($this->api->deleteSecurityGroup(), $options);
499
    }
500
501
    public function parseMetadata(ResponseInterface $response): array
502
    {
503
        return Utils::jsonDecode($response)['metadata'];
504
    }
505
506
    /**
507
     * Returns Generator for SecurityGroups
508
     *
509
     * @return \Generator
510
     */
511
    public function listSecurityGroups(): \Generator
512
    {
513
        return $this->model(SecurityGroup::class)->enumerate($this->api->getSecurityGroups(), ['id' => $this->id]);
0 ignored issues
show
Bug introduced by
It seems like you code against a concrete implementation and not the interface OpenStack\Common\Resource\ResourceInterface as the method enumerate() does only exist in the following implementations of said interface: OpenStack\BlockStorage\v2\Models\QuotaSet, OpenStack\BlockStorage\v2\Models\Snapshot, OpenStack\BlockStorage\v2\Models\Volume, OpenStack\BlockStorage\v2\Models\VolumeAttachment, OpenStack\BlockStorage\v2\Models\VolumeType, OpenStack\Common\Resource\OperatorResource, OpenStack\Compute\v2\Models\AvailabilityZone, OpenStack\Compute\v2\Models\Flavor, OpenStack\Compute\v2\Models\Host, OpenStack\Compute\v2\Models\Hypervisor, OpenStack\Compute\v2\Models\HypervisorStatistic, OpenStack\Compute\v2\Models\Image, OpenStack\Compute\v2\Models\Keypair, OpenStack\Compute\v2\Models\QuotaSet, OpenStack\Compute\v2\Models\Server, OpenStack\Identity\v2\Models\Catalog, OpenStack\Identity\v2\Models\Endpoint, OpenStack\Identity\v2\Models\Entry, OpenStack\Identity\v2\Models\Tenant, OpenStack\Identity\v2\Models\Token, OpenStack\Identity\v3\Models\Assignment, OpenStack\Identity\v3\Models\Catalog, OpenStack\Identity\v3\Models\Credential, OpenStack\Identity\v3\Models\Domain, OpenStack\Identity\v3\Models\Endpoint, OpenStack\Identity\v3\Models\Group, OpenStack\Identity\v3\Models\Policy, OpenStack\Identity\v3\Models\Project, OpenStack\Identity\v3\Models\Role, OpenStack\Identity\v3\Models\Service, OpenStack\Identity\v3\Models\Token, OpenStack\Identity\v3\Models\User, OpenStack\Images\v2\Models\Image, OpenStack\Images\v2\Models\Member, OpenStack\Metric\v1\Gnocchi\Models\Metric, OpenStack\Metric\v1\Gnocchi\Models\Resource, OpenStack\Metric\v1\Gnocchi\Models\ResourceType, OpenStack\Networking\v2\...ayer3\Models\FloatingIp, OpenStack\Networking\v2\...ns\Layer3\Models\Router, OpenStack\Networking\v2\...ps\Models\SecurityGroup, OpenStack\Networking\v2\...odels\SecurityGroupRule, OpenStack\Networking\v2\Models\InterfaceAttachment, OpenStack\Networking\v2\Models\LoadBalancer, OpenStack\Networking\v2\...adBalancerHealthMonitor, OpenStack\Networking\v2\...ls\LoadBalancerListener, OpenStack\Networking\v2\Models\LoadBalancerMember, OpenStack\Networking\v2\Models\LoadBalancerPool, OpenStack\Networking\v2\Models\LoadBalancerStat, OpenStack\Networking\v2\Models\LoadBalancerStatus, OpenStack\Networking\v2\Models\Network, OpenStack\Networking\v2\...s\NetworkIpAvailability, OpenStack\Networking\v2\Models\Port, OpenStack\Networking\v2\Models\Quota, OpenStack\Networking\v2\Models\Subnet, OpenStack\ObjectStore\v1\Models\Account, OpenStack\ObjectStore\v1\Models\Container, OpenStack\ObjectStore\v1\Models\Object.

Let’s take a look at an example:

interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the interface:

    interface User
    {
        /** @return string */
        public function getPassword();
    
        /** @return string */
        public function getDisplayName();
    }
    
Loading history...
514
    }
515
516
517
    /**
518
     * Returns Generator for VolumeAttachment
519
     *
520
     * @return \Generator
521
     */
522
    public function listVolumeAttachments(): \Generator
523
    {
524
        return $this->model(VolumeAttachment::class)->enumerate($this->api->getVolumeAttachments(), ['id' => $this->id]);
0 ignored issues
show
Bug introduced by
It seems like you code against a concrete implementation and not the interface OpenStack\Common\Resource\ResourceInterface as the method enumerate() does only exist in the following implementations of said interface: OpenStack\BlockStorage\v2\Models\QuotaSet, OpenStack\BlockStorage\v2\Models\Snapshot, OpenStack\BlockStorage\v2\Models\Volume, OpenStack\BlockStorage\v2\Models\VolumeAttachment, OpenStack\BlockStorage\v2\Models\VolumeType, OpenStack\Common\Resource\OperatorResource, OpenStack\Compute\v2\Models\AvailabilityZone, OpenStack\Compute\v2\Models\Flavor, OpenStack\Compute\v2\Models\Host, OpenStack\Compute\v2\Models\Hypervisor, OpenStack\Compute\v2\Models\HypervisorStatistic, OpenStack\Compute\v2\Models\Image, OpenStack\Compute\v2\Models\Keypair, OpenStack\Compute\v2\Models\QuotaSet, OpenStack\Compute\v2\Models\Server, OpenStack\Identity\v2\Models\Catalog, OpenStack\Identity\v2\Models\Endpoint, OpenStack\Identity\v2\Models\Entry, OpenStack\Identity\v2\Models\Tenant, OpenStack\Identity\v2\Models\Token, OpenStack\Identity\v3\Models\Assignment, OpenStack\Identity\v3\Models\Catalog, OpenStack\Identity\v3\Models\Credential, OpenStack\Identity\v3\Models\Domain, OpenStack\Identity\v3\Models\Endpoint, OpenStack\Identity\v3\Models\Group, OpenStack\Identity\v3\Models\Policy, OpenStack\Identity\v3\Models\Project, OpenStack\Identity\v3\Models\Role, OpenStack\Identity\v3\Models\Service, OpenStack\Identity\v3\Models\Token, OpenStack\Identity\v3\Models\User, OpenStack\Images\v2\Models\Image, OpenStack\Images\v2\Models\Member, OpenStack\Metric\v1\Gnocchi\Models\Metric, OpenStack\Metric\v1\Gnocchi\Models\Resource, OpenStack\Metric\v1\Gnocchi\Models\ResourceType, OpenStack\Networking\v2\...ayer3\Models\FloatingIp, OpenStack\Networking\v2\...ns\Layer3\Models\Router, OpenStack\Networking\v2\...ps\Models\SecurityGroup, OpenStack\Networking\v2\...odels\SecurityGroupRule, OpenStack\Networking\v2\Models\InterfaceAttachment, OpenStack\Networking\v2\Models\LoadBalancer, OpenStack\Networking\v2\...adBalancerHealthMonitor, OpenStack\Networking\v2\...ls\LoadBalancerListener, OpenStack\Networking\v2\Models\LoadBalancerMember, OpenStack\Networking\v2\Models\LoadBalancerPool, OpenStack\Networking\v2\Models\LoadBalancerStat, OpenStack\Networking\v2\Models\LoadBalancerStatus, OpenStack\Networking\v2\Models\Network, OpenStack\Networking\v2\...s\NetworkIpAvailability, OpenStack\Networking\v2\Models\Port, OpenStack\Networking\v2\Models\Quota, OpenStack\Networking\v2\Models\Subnet, OpenStack\ObjectStore\v1\Models\Account, OpenStack\ObjectStore\v1\Models\Container, OpenStack\ObjectStore\v1\Models\Object.

Let’s take a look at an example:

interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the interface:

    interface User
    {
        /** @return string */
        public function getPassword();
    
        /** @return string */
        public function getDisplayName();
    }
    
Loading history...
525
    }
526
527
    /**
528
     * Attach a volume and returns volume that was attached
529
     *
530
     * @param $volumeId
531
     *
532
     * @return VolumeAttachment
533
     */
534
    public function attachVolume(string $volumeId): VolumeAttachment
535
    {
536
        $response =  $this->execute($this->api->postVolumeAttachments(), ['id' => $this->id, 'volumeId' => $volumeId]);
537
538
        return $this->model(VolumeAttachment::class)->populateFromResponse($response);
539
    }
540
541
    /**
542
     * Detach a volume
543
     *
544
     * @param $attachmentId
545
     *
546
     * @return void
547
     */
548
    public function detachVolume(string $attachmentId)
549
    {
550
        $this->execute($this->api->deleteVolumeAttachments(), ['id' => $this->id, 'attachmentId' => $attachmentId]);
551
    }
552
}
553