GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Completed
Pull Request — master (#145)
by Casper
01:45
created

Server::addSecurityGroup()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 8
Code Lines 4

Duplication

Lines 8
Ratio 100 %

Code Coverage

Tests 0
CRAP Score 2

Importance

Changes 0
Metric Value
dl 8
loc 8
ccs 0
cts 0
cp 0
rs 9.4285
c 0
b 0
f 0
cc 1
eloc 4
nc 1
nop 1
crap 2
1
<?php declare(strict_types=1);
2
3
namespace OpenStack\Compute\v2\Models;
4
5
use OpenStack\Common\Resource\HasWaiterTrait;
6
use OpenStack\Common\Resource\Creatable;
7
use OpenStack\Common\Resource\Deletable;
8
use OpenStack\Common\Resource\Listable;
9
use OpenStack\Common\Resource\Retrievable;
10
use OpenStack\Common\Resource\Updateable;
11
use OpenStack\Common\Resource\OperatorResource;
12
use OpenStack\Common\Transport\Utils;
13
use OpenStack\BlockStorage\v2\Models\VolumeAttachment;
14
use OpenStack\Networking\v2\Models\InterfaceAttachment;
15
use OpenStack\Compute\v2\Enum;
16
use OpenStack\Networking\v2\Extensions\SecurityGroups\Models\SecurityGroup;
17
use Psr\Http\Message\ResponseInterface;
18
19
/**
20
 * @property \OpenStack\Compute\v2\Api $api
21
 */
22
class Server extends OperatorResource implements
23
    Creatable,
24
    Updateable,
25
    Deletable,
26
    Retrievable,
27
    Listable
28
{
29
    use HasWaiterTrait;
30
31
    /** @var string */
32
    public $id;
33
34
    /** @var string */
35
    public $ipv4;
36
37
    /** @var string */
38
    public $ipv6;
39
40
    /** @var array */
41
    public $addresses;
42
43
    /** @var \DateTimeImmutable */
44
    public $created;
45
46
    /** @var \DateTimeImmutable */
47
    public $updated;
48
49
    /** @var Flavor */
50
    public $flavor;
51
52
    /** @var string */
53
    public $hostId;
54
55
    /** @var string */
56
    public $hypervisorHostname;
57
58
    /** @var Image */
59
    public $image;
60
61
    /** @var array */
62
    public $links;
63
64
    /** @var array */
65
    public $metadata;
66
67
    /** @var string */
68
    public $name;
69
70
    /** @var string */
71
    public $progress;
72
73
    /** @var string */
74
    public $status;
75
76
    /** @var string */
77
    public $tenantId;
78
79
    /** @var string */
80
    public $userId;
81
82
    /** @var string */
83
    public $adminPass;
84
85
    /** @var string */
86
    public $taskState;
87
88
    /** @var string */
89
    public $powerState;
90
91
    /** @var string */
92
    public $vmState;
93
94
    protected $resourceKey = 'server';
95
    protected $resourcesKey = 'servers';
96
    protected $markerKey = 'id';
97
98
    protected $aliases = [
99
        'block_device_mapping_v2'             => 'blockDeviceMapping',
100
        'accessIPv4'                          => 'ipv4',
101 2
        'accessIPv6'                          => 'ipv6',
102
        'tenant_id'                           => 'tenantId',
103 2
        'user_id'                             => 'userId',
104 2
        'security_groups'                     => 'securityGroups',
105
        'OS-EXT-STS:task_state'               => 'taskState',
106
        'OS-EXT-STS:power_state'              => 'powerState',
107
        'OS-EXT-STS:vm_state'                 => 'vmState',
108
        'OS-EXT-SRV-ATTR:hypervisor_hostname' => 'hypervisorHostname',
109
    ];
110 1
111
    /**
112 1
     * {@inheritDoc}
113
     *
114 1
     * @param array $userOptions {@see \OpenStack\Compute\v2\Api::postServer}
115
     */
116
    public function create(array $userOptions): Creatable
117
    {
118
        if (!isset($userOptions['imageId']) && !isset($userOptions['blockDeviceMapping'][0]['uuid'])) {
119
            throw new \RuntimeException('imageId or blockDeviceMapping.uuid must be set.');
120 1
        }
121
122 1
        $response = $this->execute($this->api->postServer(), $userOptions);
123 1
        return $this->populateFromResponse($response);
124
    }
125
126
    /**
127
     * {@inheritDoc}
128 1
     */
129
    public function update()
130 1
    {
131
        $response = $this->execute($this->api->putServer(), $this->getAttrs(['id', 'name', 'ipv4', 'ipv6']));
132 1
        $this->populateFromResponse($response);
133
    }
134
135
    /**
136
     * {@inheritDoc}
137
     */
138
    public function delete()
139
    {
140 1
        $this->execute($this->api->deleteServer(), $this->getAttrs(['id']));
141
    }
142 1
143 1
    /**
144
     * {@inheritDoc}
145 1
     */
146 1
    public function retrieve()
147
    {
148
        $response = $this->execute($this->api->getServer(), $this->getAttrs(['id']));
149
        $this->populateFromResponse($response);
150
    }
151
152
    /**
153 2
     * Changes the root password for a server.
154
     *
155 2
     * @param string $newPassword The new root password
156 1
     */
157
    public function changePassword(string $newPassword)
158
    {
159 1
        $this->execute($this->api->changeServerPassword(), [
160 1
            'id'       => $this->id,
161 1
            'password' => $newPassword,
162 1
        ]);
163 1
    }
164
165
    /**
166
     * Reboots the server.
167
     *
168
     * @param string $type The type of reboot that will be performed. Either SOFT or HARD is supported.
169
     */
170 1
    public function reboot(string $type = Enum::REBOOT_SOFT)
171
    {
172 1
        if (!in_array($type, ['SOFT', 'HARD'])) {
173 1
            throw new \RuntimeException('Reboot type must either be SOFT or HARD');
174
        }
175 1
176 1
        $this->execute($this->api->rebootServer(), [
177
            'id'   => $this->id,
178
            'type' => $type,
179
        ]);
180
    }
181
182
    /**
183
     * Starts server
184 1
     */
185
    public function start()
186 1
    {
187 1
        $this->execute($this->api->startServer(), [
188 1
            'id' => $this->id,
189 1
            'os-start' => null
190
        ]);
191 1
    }
192 1
193
    /**
194
     * Stops server
195
     */
196
    public function stop()
197 1
    {
198
        $this->execute($this->api->stopServer(), [
199 1
            'id' => $this->id,
200 1
            'os-stop' => null
201
        ]);
202
    }
203
204
    /**
205 1
     * Rebuilds the server.
206
     *
207 1
     * @param array $options {@see \OpenStack\Compute\v2\Api::rebuildServer}
208 1
     */
209
    public function rebuild(array $options)
210
    {
211
        $options['id'] = $this->id;
212
        $response = $this->execute($this->api->rebuildServer(), $options);
213
214
        $this->populateFromResponse($response);
215 1
    }
216
217 1
    /**
218 1
     * Resizes the server to a new flavor. Once this operation is complete and server has transitioned
219 1
     * to an active state, you will either need to call {@see confirmResize()} or {@see revertResize()}.
220
     *
221
     * @param string $flavorId The UUID of the new flavor your server will be based on.
222
     */
223
    public function resize(string $flavorId)
224
    {
225
        $response = $this->execute($this->api->resizeServer(), [
226
            'id'       => $this->id,
227
            'flavorId' => $flavorId,
228 2
        ]);
229
230 2
        $this->populateFromResponse($response);
231
    }
232 2
233 2
    /**
234 2
     * Confirms a previous resize operation.
235
     */
236
    public function confirmResize()
237
    {
238
        $this->execute($this->api->confirmServerResize(), ['confirmResize' => null, 'id' => $this->id]);
239
    }
240
241
    /**
242 1
     * Reverts a previous resize operation.
243
     */
244 1
    public function revertResize()
245 1
    {
246
        $this->execute($this->api->revertServerResize(), ['revertResize' => null, 'id' => $this->id]);
247
    }
248
249
    /**
250
     * Gets the console output of the server.
251
     *
252
     * @param int $length The number of lines, by default all lines will be returned.
253
     * @return string
254
     */
255
    public function getConsoleOutput(int $length = -1): string
256 1
    {
257
        $definition = $length == -1 ? $this->api->getAllConsoleOutput() : $this->api->getConsoleOutput();
258 1
259 1
        $response = $this->execute($definition, [
260
            'os-getConsoleOutput' => new \stdClass(),
261
            'id' => $this->id,
262
            'length' => $length,
263
        ]);
264
265
        return Utils::jsonDecode($response)['output'];
266
    }
267
268
    /**
269
     * Gets a VNC console for a server.
270
     *
271 1
     * @param  string $type The type of VNC console: novnc|xvpvnc.
272
     *                      Defaults to novnc.
273 1
     *
274 1
     * @return array
275
     */
276
    public function getVncConsole($type = Enum::CONSOLE_NOVNC): array
277
    {
278
        $response = $this->execute($this->api->getVncConsole(), ['id' => $this->id, 'type' => $type]);
279
        return Utils::jsonDecode($response)['console'];
280
    }
281
282
    /**
283
     * Gets a RDP console for a server.
284 1
     *
285
     * @param  string $type The type of VNC console: rdp-html5 (default).
286 1
     *
287 1
     * @return array
288
     */
289
    public function getRDPConsole($type = Enum::CONSOLE_RDP_HTML5): array
290
    {
291
        $response = $this->execute($this->api->getRDPConsole(), ['id' => $this->id, 'type' => $type]);
292
        return Utils::jsonDecode($response)['console'];
293
    }
294
295 1
    /**
296
     * Gets a Spice console for a server.
297 1
     *
298 1
     * @param  string $type The type of VNC console: spice-html5.
299
     *
300
     * @return array
301
     */
302
    public function getSpiceConsole($type = Enum::CONSOLE_SPICE_HTML5): array
303
    {
304
        $response = $this->execute($this->api->getSpiceConsole(), ['id' => $this->id, 'type' => $type]);
305
        return Utils::jsonDecode($response)['console'];
306
    }
307
308
    /**
309
     * Gets a serial console for a server.
310
     *
311
     * @param  string $type The type of VNC console: serial.
312
     *
313
     * @return array
314
     */
315
    public function getSerialConsole($type = Enum::CONSOLE_SERIAL): array
316
    {
317
        $response = $this->execute($this->api->getSerialConsole(), ['id' => $this->id, 'type' => $type]);
318
        return Utils::jsonDecode($response)['console'];
319
    }
320
321
    /**
322
     * Creates an image for the current server.
323
     *
324
     * @param array $options {@see \OpenStack\Compute\v2\Api::createServerImage}
325
     */
326
    public function createImage(array $options)
327
    {
328
        $options['id'] = $this->id;
329
        $this->execute($this->api->createServerImage(), $options);
330
    }
331
332
    /**
333
     * Iterates over all the IP addresses for this server.
334
     *
335
     * @param array $options {@see \OpenStack\Compute\v2\Api::getAddressesByNetwork}
336
     *
337
     * @return array An array containing to two keys: "public" and "private"
338
     */
339
    public function listAddresses(array $options = []): array
340
    {
341
        $options['id'] = $this->id;
342
343
        $data = (isset($options['networkLabel'])) ? $this->api->getAddressesByNetwork() : $this->api->getAddresses();
344
        $response = $this->execute($data, $options);
345
        return Utils::jsonDecode($response)['addresses'];
346
    }
347
348
    /**
349
     * Returns Generator for InterfaceAttachment
350
     *
351
     * @return \Generator
352
     */
353
    public function listInterfaceAttachments(array $options = []): \Generator
0 ignored issues
show
Unused Code introduced by
The parameter $options is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
354
    {
355
        return $this->model(InterfaceAttachment::class)->enumerate($this->api->getInterfaceAttachments(), ['id' => $this->id]);
0 ignored issues
show
Bug introduced by
It seems like you code against a concrete implementation and not the interface OpenStack\Common\Resource\ResourceInterface as the method enumerate() does only exist in the following implementations of said interface: OpenStack\BlockStorage\v2\Models\QuotaSet, OpenStack\BlockStorage\v2\Models\Snapshot, OpenStack\BlockStorage\v2\Models\Volume, OpenStack\BlockStorage\v2\Models\VolumeAttachment, OpenStack\BlockStorage\v2\Models\VolumeType, OpenStack\Common\Resource\OperatorResource, OpenStack\Compute\v2\Models\AvailabilityZone, OpenStack\Compute\v2\Models\Flavor, OpenStack\Compute\v2\Models\Host, OpenStack\Compute\v2\Models\Hypervisor, OpenStack\Compute\v2\Models\HypervisorStatistic, OpenStack\Compute\v2\Models\Image, OpenStack\Compute\v2\Models\Keypair, OpenStack\Compute\v2\Models\QuotaSet, OpenStack\Compute\v2\Models\Server, OpenStack\Identity\v2\Models\Catalog, OpenStack\Identity\v2\Models\Endpoint, OpenStack\Identity\v2\Models\Entry, OpenStack\Identity\v2\Models\Tenant, OpenStack\Identity\v2\Models\Token, OpenStack\Identity\v3\Models\Assignment, OpenStack\Identity\v3\Models\Catalog, OpenStack\Identity\v3\Models\Credential, OpenStack\Identity\v3\Models\Domain, OpenStack\Identity\v3\Models\Endpoint, OpenStack\Identity\v3\Models\Group, OpenStack\Identity\v3\Models\Policy, OpenStack\Identity\v3\Models\Project, OpenStack\Identity\v3\Models\Role, OpenStack\Identity\v3\Models\Service, OpenStack\Identity\v3\Models\Token, OpenStack\Identity\v3\Models\User, OpenStack\Images\v2\Models\Image, OpenStack\Images\v2\Models\Member, OpenStack\Metric\v1\Gnocchi\Models\Metric, OpenStack\Metric\v1\Gnocchi\Models\Resource, OpenStack\Metric\v1\Gnocchi\Models\ResourceType, OpenStack\Networking\v2\...ayer3\Models\FloatingIp, OpenStack\Networking\v2\...ns\Layer3\Models\Router, OpenStack\Networking\v2\...ps\Models\SecurityGroup, OpenStack\Networking\v2\...odels\SecurityGroupRule, OpenStack\Networking\v2\Models\InterfaceAttachment, OpenStack\Networking\v2\Models\LoadBalancer, OpenStack\Networking\v2\...adBalancerHealthMonitor, OpenStack\Networking\v2\...ls\LoadBalancerListener, OpenStack\Networking\v2\Models\LoadBalancerMember, OpenStack\Networking\v2\Models\LoadBalancerPool, OpenStack\Networking\v2\Models\LoadBalancerStat, OpenStack\Networking\v2\Models\LoadBalancerStatus, OpenStack\Networking\v2\Models\Network, OpenStack\Networking\v2\Models\Port, OpenStack\Networking\v2\Models\Quota, OpenStack\Networking\v2\Models\Subnet, OpenStack\ObjectStore\v1\Models\Account, OpenStack\ObjectStore\v1\Models\Container, OpenStack\ObjectStore\v1\Models\Object.

Let’s take a look at an example:

interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the interface:

    interface User
    {
        /** @return string */
        public function getPassword();
    
        /** @return string */
        public function getDisplayName();
    }
    
Loading history...
356
    }
357
358
    /**
359
     * Gets an interface attachment.
360
     *
361
     * @param string $portId The unique ID of the port.
362
     * @return InterfaceAttachment
363
     */
364 View Code Duplication
    public function getInterfaceAttachment(string $portId): InterfaceAttachment
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
365
    {
366
        $response = $this->execute($this->api->getInterfaceAttachment(), [
367
            'id'     => $this->id,
368
            'portId' => $portId
369
        ]);
370
371
        return $this->model(InterfaceAttachment::class)->populateFromResponse($response);
372
    }
373
374
    /**
375
     * Creates an interface attachment.
376
     *
377
     * @param array $userOptions {@see \OpenStack\Compute\v2\Api::postInterfaceAttachment}
378
     * @return InterfaceAttachment
379
     */
380
    public function createInterfaceAttachment(array $userOptions): InterfaceAttachment
381
    {
382
        if (!isset($userOptions['networkId']) && !isset($userOptions['portId'])) {
383
            throw new \RuntimeException('networkId or portId must be set.');
384
        }
385
386
        $response = $this->execute($this->api->postInterfaceAttachment(), array_merge($userOptions, ['id' => $this->id]));
387
        return $this->model(InterfaceAttachment::class)->populateFromResponse($response);
388
    }
389
390
    /**
391
     * Detaches an interface attachment.
392
     *
393
     * @param string $portId
394
     */
395
    public function detachInterface(string $portId)
396
    {
397
        $this->execute($this->api->deleteInterfaceAttachment(), [
398
            'id' => $this->id,
399
            'portId' => $portId,
400
        ]);
401
    }
402
403
    /**
404
     * Retrieves metadata from the API.
405
     *
406
     * @return array
407
     */
408
    public function getMetadata(): array
409
    {
410
        $response = $this->execute($this->api->getServerMetadata(), ['id' => $this->id]);
411
        return $this->parseMetadata($response);
412
    }
413
414
    /**
415
     * Resets all the metadata for this server with the values provided. All existing metadata keys
416
     * will either be replaced or removed.
417
     *
418
     * @param array $metadata {@see \OpenStack\Compute\v2\Api::putServerMetadata}
419
     */
420
    public function resetMetadata(array $metadata)
421
    {
422
        $response = $this->execute($this->api->putServerMetadata(), ['id' => $this->id, 'metadata' => $metadata]);
423
        $this->metadata = $this->parseMetadata($response);
424
    }
425
426
    /**
427
     * Merges the existing metadata for the server with the values provided. Any existing keys
428
     * referenced in the user options will be replaced with the user's new values. All other
429
     * existing keys will remain unaffected.
430
     *
431
     * @param array $metadata {@see \OpenStack\Compute\v2\Api::postServerMetadata}
432
     *
433
     * @return array
434
     */
435
    public function mergeMetadata(array $metadata)
436
    {
437
        $response = $this->execute($this->api->postServerMetadata(), ['id' => $this->id, 'metadata' => $metadata]);
438
        $this->metadata = $this->parseMetadata($response);
439
    }
440
441
    /**
442
     * Retrieve the value for a specific metadata key.
443
     *
444
     * @param string $key {@see \OpenStack\Compute\v2\Api::getServerMetadataKey}
445
     *
446
     * @return mixed
447
     */
448 View Code Duplication
    public function getMetadataItem(string $key)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
449
    {
450
        $response = $this->execute($this->api->getServerMetadataKey(), ['id' => $this->id, 'key' => $key]);
451
        $value = $this->parseMetadata($response)[$key];
452
        $this->metadata[$key] = $value;
453
        return $value;
454
    }
455
456
    /**
457
     * Remove a specific metadata key.
458
     *
459
     * @param string $key {@see \OpenStack\Compute\v2\Api::deleteServerMetadataKey}
460
     */
461 View Code Duplication
    public function deleteMetadataItem(string $key)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
462
    {
463
        if (isset($this->metadata[$key])) {
464
            unset($this->metadata[$key]);
465
        }
466
467
        $this->execute($this->api->deleteServerMetadataKey(), ['id' => $this->id, 'key' => $key]);
468
    }
469
470
471
    /**
472
     * Add security group to a server (addSecurityGroup action)
473
     *
474
     * @param array $options {@see \OpenStack\Compute\v2\Api::postSecurityGroup}
475
     *
476
     * @return SecurityGroup
477
     */
478 View Code Duplication
    public function addSecurityGroup(array $options) : SecurityGroup
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
479
    {
480
        $options['id'] = $this->id;
481
482
        $response = $this->execute($this->api->postSecurityGroup(), $options);
483
484
        return $this->model(SecurityGroup::class)->populateFromResponse($response);
485
    }
486
487
    /**
488
     * Add security group to a server (addSecurityGroup action)
489
     *
490
     * @param array $options {@see \OpenStack\Compute\v2\Api::deleteSecurityGroup}
491
     */
492
    public function removeSecurityGroup(array $options)
493
    {
494
        $options['id'] = $this->id;
495
        $this->execute($this->api->deleteSecurityGroup(), $options);
496
    }
497
498
    public function parseMetadata(ResponseInterface $response): array
499
    {
500
        return Utils::jsonDecode($response)['metadata'];
501
    }
502
503
    /**
504
     * Returns Generator for SecurityGroups
505
     *
506
     * @return \Generator
507
     */
508
    public function listSecurityGroups(): \Generator
509
    {
510
        return $this->model(SecurityGroup::class)->enumerate($this->api->getSecurityGroups(), ['id' => $this->id]);
0 ignored issues
show
Bug introduced by
It seems like you code against a concrete implementation and not the interface OpenStack\Common\Resource\ResourceInterface as the method enumerate() does only exist in the following implementations of said interface: OpenStack\BlockStorage\v2\Models\QuotaSet, OpenStack\BlockStorage\v2\Models\Snapshot, OpenStack\BlockStorage\v2\Models\Volume, OpenStack\BlockStorage\v2\Models\VolumeAttachment, OpenStack\BlockStorage\v2\Models\VolumeType, OpenStack\Common\Resource\OperatorResource, OpenStack\Compute\v2\Models\AvailabilityZone, OpenStack\Compute\v2\Models\Flavor, OpenStack\Compute\v2\Models\Host, OpenStack\Compute\v2\Models\Hypervisor, OpenStack\Compute\v2\Models\HypervisorStatistic, OpenStack\Compute\v2\Models\Image, OpenStack\Compute\v2\Models\Keypair, OpenStack\Compute\v2\Models\QuotaSet, OpenStack\Compute\v2\Models\Server, OpenStack\Identity\v2\Models\Catalog, OpenStack\Identity\v2\Models\Endpoint, OpenStack\Identity\v2\Models\Entry, OpenStack\Identity\v2\Models\Tenant, OpenStack\Identity\v2\Models\Token, OpenStack\Identity\v3\Models\Assignment, OpenStack\Identity\v3\Models\Catalog, OpenStack\Identity\v3\Models\Credential, OpenStack\Identity\v3\Models\Domain, OpenStack\Identity\v3\Models\Endpoint, OpenStack\Identity\v3\Models\Group, OpenStack\Identity\v3\Models\Policy, OpenStack\Identity\v3\Models\Project, OpenStack\Identity\v3\Models\Role, OpenStack\Identity\v3\Models\Service, OpenStack\Identity\v3\Models\Token, OpenStack\Identity\v3\Models\User, OpenStack\Images\v2\Models\Image, OpenStack\Images\v2\Models\Member, OpenStack\Metric\v1\Gnocchi\Models\Metric, OpenStack\Metric\v1\Gnocchi\Models\Resource, OpenStack\Metric\v1\Gnocchi\Models\ResourceType, OpenStack\Networking\v2\...ayer3\Models\FloatingIp, OpenStack\Networking\v2\...ns\Layer3\Models\Router, OpenStack\Networking\v2\...ps\Models\SecurityGroup, OpenStack\Networking\v2\...odels\SecurityGroupRule, OpenStack\Networking\v2\Models\InterfaceAttachment, OpenStack\Networking\v2\Models\LoadBalancer, OpenStack\Networking\v2\...adBalancerHealthMonitor, OpenStack\Networking\v2\...ls\LoadBalancerListener, OpenStack\Networking\v2\Models\LoadBalancerMember, OpenStack\Networking\v2\Models\LoadBalancerPool, OpenStack\Networking\v2\Models\LoadBalancerStat, OpenStack\Networking\v2\Models\LoadBalancerStatus, OpenStack\Networking\v2\Models\Network, OpenStack\Networking\v2\Models\Port, OpenStack\Networking\v2\Models\Quota, OpenStack\Networking\v2\Models\Subnet, OpenStack\ObjectStore\v1\Models\Account, OpenStack\ObjectStore\v1\Models\Container, OpenStack\ObjectStore\v1\Models\Object.

Let’s take a look at an example:

interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the interface:

    interface User
    {
        /** @return string */
        public function getPassword();
    
        /** @return string */
        public function getDisplayName();
    }
    
Loading history...
511
    }
512
513
514
    /**
515
     * Returns Generator for VolumeAttachment
516
     *
517
     * @return \Generator
518
     */
519
    public function listVolumeAttachments(): \Generator
520
    {
521
        return $this->model(VolumeAttachment::class)->enumerate($this->api->getVolumeAttachments(), ['id' => $this->id]);
0 ignored issues
show
Bug introduced by
It seems like you code against a concrete implementation and not the interface OpenStack\Common\Resource\ResourceInterface as the method enumerate() does only exist in the following implementations of said interface: OpenStack\BlockStorage\v2\Models\QuotaSet, OpenStack\BlockStorage\v2\Models\Snapshot, OpenStack\BlockStorage\v2\Models\Volume, OpenStack\BlockStorage\v2\Models\VolumeAttachment, OpenStack\BlockStorage\v2\Models\VolumeType, OpenStack\Common\Resource\OperatorResource, OpenStack\Compute\v2\Models\AvailabilityZone, OpenStack\Compute\v2\Models\Flavor, OpenStack\Compute\v2\Models\Host, OpenStack\Compute\v2\Models\Hypervisor, OpenStack\Compute\v2\Models\HypervisorStatistic, OpenStack\Compute\v2\Models\Image, OpenStack\Compute\v2\Models\Keypair, OpenStack\Compute\v2\Models\QuotaSet, OpenStack\Compute\v2\Models\Server, OpenStack\Identity\v2\Models\Catalog, OpenStack\Identity\v2\Models\Endpoint, OpenStack\Identity\v2\Models\Entry, OpenStack\Identity\v2\Models\Tenant, OpenStack\Identity\v2\Models\Token, OpenStack\Identity\v3\Models\Assignment, OpenStack\Identity\v3\Models\Catalog, OpenStack\Identity\v3\Models\Credential, OpenStack\Identity\v3\Models\Domain, OpenStack\Identity\v3\Models\Endpoint, OpenStack\Identity\v3\Models\Group, OpenStack\Identity\v3\Models\Policy, OpenStack\Identity\v3\Models\Project, OpenStack\Identity\v3\Models\Role, OpenStack\Identity\v3\Models\Service, OpenStack\Identity\v3\Models\Token, OpenStack\Identity\v3\Models\User, OpenStack\Images\v2\Models\Image, OpenStack\Images\v2\Models\Member, OpenStack\Metric\v1\Gnocchi\Models\Metric, OpenStack\Metric\v1\Gnocchi\Models\Resource, OpenStack\Metric\v1\Gnocchi\Models\ResourceType, OpenStack\Networking\v2\...ayer3\Models\FloatingIp, OpenStack\Networking\v2\...ns\Layer3\Models\Router, OpenStack\Networking\v2\...ps\Models\SecurityGroup, OpenStack\Networking\v2\...odels\SecurityGroupRule, OpenStack\Networking\v2\Models\InterfaceAttachment, OpenStack\Networking\v2\Models\LoadBalancer, OpenStack\Networking\v2\...adBalancerHealthMonitor, OpenStack\Networking\v2\...ls\LoadBalancerListener, OpenStack\Networking\v2\Models\LoadBalancerMember, OpenStack\Networking\v2\Models\LoadBalancerPool, OpenStack\Networking\v2\Models\LoadBalancerStat, OpenStack\Networking\v2\Models\LoadBalancerStatus, OpenStack\Networking\v2\Models\Network, OpenStack\Networking\v2\Models\Port, OpenStack\Networking\v2\Models\Quota, OpenStack\Networking\v2\Models\Subnet, OpenStack\ObjectStore\v1\Models\Account, OpenStack\ObjectStore\v1\Models\Container, OpenStack\ObjectStore\v1\Models\Object.

Let’s take a look at an example:

interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the interface:

    interface User
    {
        /** @return string */
        public function getPassword();
    
        /** @return string */
        public function getDisplayName();
    }
    
Loading history...
522
    }
523
524
    /**
525
     * Attach a volume and returns volume that was attached
526
     *
527
     * @param $volumeId
528
     *
529
     * @return VolumeAttachment
530
     */
531
    public function attachVolume(string $volumeId): VolumeAttachment
532
    {
533
        $response =  $this->execute($this->api->postVolumeAttachments(), ['id' => $this->id, 'volumeId' => $volumeId]);
534
535
        return $this->model(VolumeAttachment::class)->populateFromResponse($response);
536
    }
537
538
    /**
539
     * Detach a volume
540
     *
541
     * @param $attachmentId
542
     *
543
     * @return void
544
     */
545
    public function detachVolume(string $attachmentId)
546
    {
547
        $this->execute($this->api->deleteVolumeAttachments(), ['id' => $this->id, 'attachmentId' => $attachmentId]);
548
    }
549
}
550