GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Completed
Pull Request — master (#145)
by Casper
02:19
created

Server::listVolumeAttachments()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 4
Code Lines 2

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 0
CRAP Score 2

Importance

Changes 0
Metric Value
dl 0
loc 4
c 0
b 0
f 0
rs 10
ccs 0
cts 0
cp 0
cc 1
eloc 2
nc 1
nop 0
crap 2
1
<?php declare(strict_types=1);
2
3
namespace OpenStack\Compute\v2\Models;
4
5
use OpenStack\Common\Resource\HasWaiterTrait;
6
use OpenStack\Common\Resource\Creatable;
7
use OpenStack\Common\Resource\Deletable;
8
use OpenStack\Common\Resource\Listable;
9
use OpenStack\Common\Resource\Retrievable;
10
use OpenStack\Common\Resource\Updateable;
11
use OpenStack\Common\Resource\OperatorResource;
12
use OpenStack\Common\Transport\Utils;
13
use OpenStack\BlockStorage\v2\Models\VolumeAttachment;
14
use OpenStack\Networking\v2\Models\InterfaceAttachment;
15
use OpenStack\Compute\v2\Enum;
16
use OpenStack\Networking\v2\Extensions\SecurityGroups\Models\SecurityGroup;
17
use Psr\Http\Message\ResponseInterface;
18
19
/**
20
 * @property \OpenStack\Compute\v2\Api $api
21
 */
22
class Server extends OperatorResource implements
23
    Creatable,
24
    Updateable,
25
    Deletable,
26
    Retrievable,
27
    Listable
28
{
29
    use HasWaiterTrait;
30
31
    /** @var string */
32
    public $id;
33
34
    /** @var string */
35
    public $ipv4;
36
37
    /** @var string */
38
    public $ipv6;
39
40
    /** @var array */
41
    public $addresses;
42
43
    /** @var \DateTimeImmutable */
44
    public $created;
45
46
    /** @var \DateTimeImmutable */
47
    public $updated;
48
49
    /** @var Flavor */
50
    public $flavor;
51
52
    /** @var string */
53
    public $hostId;
54
55
    /** @var string */
56
    public $hypervisorHostname;
57
58
    /** @var Image */
59
    public $image;
60
61
    /** @var array */
62
    public $links;
63
64
    /** @var array */
65
    public $metadata;
66
67
    /** @var string */
68
    public $name;
69
70
    /** @var string */
71
    public $progress;
72
73
    /** @var string */
74
    public $status;
75
76
    /** @var string */
77
    public $tenantId;
78
79
    /** @var string */
80
    public $userId;
81
82
    /** @var string */
83
    public $adminPass;
84
85
    /** @var string */
86
    public $taskState;
87
88
    protected $resourceKey = 'server';
89
    protected $resourcesKey = 'servers';
90
    protected $markerKey = 'id';
91
92
    protected $aliases = [
93
        'block_device_mapping_v2'             => 'blockDeviceMapping',
94
        'accessIPv4'                          => 'ipv4',
95
        'accessIPv6'                          => 'ipv6',
96
        'tenant_id'                           => 'tenantId',
97
        'user_id'                             => 'userId',
98
        'security_groups'                     => 'securityGroups',
99
        'OS-EXT-STS:task_state'               => 'taskState',
100
        'OS-EXT-SRV-ATTR:hypervisor_hostname' => 'hypervisorHostname',
101 2
    ];
102
103 2
    /**
104 2
     * {@inheritDoc}
105
     *
106
     * @param array $userOptions {@see \OpenStack\Compute\v2\Api::postServer}
107
     */
108
    public function create(array $userOptions): Creatable
109
    {
110 1
        if (!isset($userOptions['imageId']) && !isset($userOptions['blockDeviceMapping'][0]['uuid'])) {
111
            throw new \RuntimeException('imageId or blockDeviceMapping.uuid must be set.');
112 1
        }
113
114 1
        $response = $this->execute($this->api->postServer(), $userOptions);
115
        return $this->populateFromResponse($response);
116
    }
117
118
    /**
119
     * {@inheritDoc}
120 1
     */
121
    public function update()
122 1
    {
123 1
        $response = $this->execute($this->api->putServer(), $this->getAttrs(['id', 'name', 'ipv4', 'ipv6']));
124
        $this->populateFromResponse($response);
125
    }
126
127
    /**
128 1
     * {@inheritDoc}
129
     */
130 1
    public function delete()
131
    {
132 1
        $this->execute($this->api->deleteServer(), $this->getAttrs(['id']));
133
    }
134
135
    /**
136
     * {@inheritDoc}
137
     */
138
    public function retrieve()
139
    {
140 1
        $response = $this->execute($this->api->getServer(), $this->getAttrs(['id']));
141
        $this->populateFromResponse($response);
142 1
    }
143 1
144
    /**
145 1
     * Changes the root password for a server.
146 1
     *
147
     * @param string $newPassword The new root password
148
     */
149
    public function changePassword(string $newPassword)
150
    {
151
        $this->execute($this->api->changeServerPassword(), [
152
            'id'       => $this->id,
153 2
            'password' => $newPassword,
154
        ]);
155 2
    }
156 1
157
    /**
158
     * Reboots the server.
159 1
     *
160 1
     * @param string $type The type of reboot that will be performed. Either SOFT or HARD is supported.
161 1
     */
162 1
    public function reboot(string $type = Enum::REBOOT_SOFT)
163 1
    {
164
        if (!in_array($type, ['SOFT', 'HARD'])) {
165
            throw new \RuntimeException('Reboot type must either be SOFT or HARD');
166
        }
167
168
        $this->execute($this->api->rebootServer(), [
169
            'id'   => $this->id,
170 1
            'type' => $type,
171
        ]);
172 1
    }
173 1
174
    /**
175 1
     * Starts server
176 1
     */
177
    public function start()
178
    {
179
        $this->execute($this->api->startServer(), [
180
            'id' => $this->id,
181
            'os-start' => null
182
        ]);
183
    }
184 1
185
    /**
186 1
     * Stops server
187 1
     */
188 1
    public function stop()
189 1
    {
190
        $this->execute($this->api->stopServer(), [
191 1
            'id' => $this->id,
192 1
            'os-stop' => null
193
        ]);
194
    }
195
196
    /**
197 1
     * Rebuilds the server.
198
     *
199 1
     * @param array $options {@see \OpenStack\Compute\v2\Api::rebuildServer}
200 1
     */
201
    public function rebuild(array $options)
202
    {
203
        $options['id'] = $this->id;
204
        $response = $this->execute($this->api->rebuildServer(), $options);
205 1
206
        $this->populateFromResponse($response);
207 1
    }
208 1
209
    /**
210
     * Resizes the server to a new flavor. Once this operation is complete and server has transitioned
211
     * to an active state, you will either need to call {@see confirmResize()} or {@see revertResize()}.
212
     *
213
     * @param string $flavorId The UUID of the new flavor your server will be based on.
214
     */
215 1
    public function resize(string $flavorId)
216
    {
217 1
        $response = $this->execute($this->api->resizeServer(), [
218 1
            'id'       => $this->id,
219 1
            'flavorId' => $flavorId,
220
        ]);
221
222
        $this->populateFromResponse($response);
223
    }
224
225
    /**
226
     * Confirms a previous resize operation.
227
     */
228 2
    public function confirmResize()
229
    {
230 2
        $this->execute($this->api->confirmServerResize(), ['confirmResize' => null, 'id' => $this->id]);
231
    }
232 2
233 2
    /**
234 2
     * Reverts a previous resize operation.
235
     */
236
    public function revertResize()
237
    {
238
        $this->execute($this->api->revertServerResize(), ['revertResize' => null, 'id' => $this->id]);
239
    }
240
241
    /**
242 1
     * Gets the console output of the server.
243
     *
244 1
     * @param int $length The number of lines, by default all lines will be returned.
245 1
     * @return string
246
     */
247
    public function getConsoleOutput(int $length = -1)
248
    {
249
        $response = $this->execute($this->api->getConsoleOutput(), [
250
            'id' => $this->id,
251
            'length' => $length
252
        ]);
253
254
        return Utils::jsonDecode($response)['output'];
255
    }
256 1
257
    /**
258 1
     * Gets a VNC console for a server.
259 1
     *
260
     * @param  string $type The type of VNC console: novnc|xvpvnc.
261
     *                      Defaults to novnc.
262
     *
263
     * @return array
264
     */
265
    public function getVncConsole($type = Enum::CONSOLE_NOVNC): array
266
    {
267
        $response = $this->execute($this->api->getVncConsole(), ['id' => $this->id, 'type' => $type]);
268
        return Utils::jsonDecode($response)['console'];
269
    }
270
271 1
    /**
272
     * Gets a RDP console for a server.
273 1
     *
274 1
     * @param  string $type The type of VNC console: rdp-html5 (default).
275
     *
276
     * @return array
277
     */
278
    public function getRDPConsole($type = Enum::CONSOLE_RDP_HTML5): array
279
    {
280
        $response = $this->execute($this->api->getRDPConsole(), ['id' => $this->id, 'type' => $type]);
281
        return Utils::jsonDecode($response)['console'];
282
    }
283
284 1
    /**
285
     * Gets a Spice console for a server.
286 1
     *
287 1
     * @param  string $type The type of VNC console: spice-html5.
288
     *
289
     * @return array
290
     */
291
    public function getSpiceConsole($type = Enum::CONSOLE_SPICE_HTML5): array
292
    {
293
        $response = $this->execute($this->api->getSpiceConsole(), ['id' => $this->id, 'type' => $type]);
294
        return Utils::jsonDecode($response)['console'];
295 1
    }
296
297 1
    /**
298 1
     * Gets a serial console for a server.
299
     *
300
     * @param  string $type The type of VNC console: serial.
301
     *
302
     * @return array
303
     */
304
    public function getSerialConsole($type = Enum::CONSOLE_SERIAL): array
305
    {
306
        $response = $this->execute($this->api->getSerialConsole(), ['id' => $this->id, 'type' => $type]);
307
        return Utils::jsonDecode($response)['console'];
308
    }
309
310
    /**
311
     * Creates an image for the current server.
312
     *
313
     * @param array $options {@see \OpenStack\Compute\v2\Api::createServerImage}
314
     */
315
    public function createImage(array $options)
316
    {
317
        $options['id'] = $this->id;
318
        $this->execute($this->api->createServerImage(), $options);
319
    }
320
321
    /**
322
     * Iterates over all the IP addresses for this server.
323
     *
324
     * @param array $options {@see \OpenStack\Compute\v2\Api::getAddressesByNetwork}
325
     *
326
     * @return array An array containing to two keys: "public" and "private"
327
     */
328
    public function listAddresses(array $options = []): array
329
    {
330
        $options['id'] = $this->id;
331
332
        $data = (isset($options['networkLabel'])) ? $this->api->getAddressesByNetwork() : $this->api->getAddresses();
333
        $response = $this->execute($data, $options);
334
        return Utils::jsonDecode($response)['addresses'];
335
    }
336
337
    /**
338
     * Returns Generator for InterfaceAttachment
339
     *
340
     * @return \Generator
341
     */
342
    public function listInterfaceAttachments(array $options = []): \Generator
0 ignored issues
show
Unused Code introduced by
The parameter $options is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
343
    {
344
        return $this->model(InterfaceAttachment::class)->enumerate($this->api->getInterfaceAttachments(), ['id' => $this->id]);
0 ignored issues
show
Bug introduced by
It seems like you code against a concrete implementation and not the interface OpenStack\Common\Resource\ResourceInterface as the method enumerate() does only exist in the following implementations of said interface: OpenStack\BlockStorage\v2\Models\QuotaSet, OpenStack\BlockStorage\v2\Models\Snapshot, OpenStack\BlockStorage\v2\Models\Volume, OpenStack\BlockStorage\v2\Models\VolumeAttachment, OpenStack\BlockStorage\v2\Models\VolumeType, OpenStack\Common\Resource\OperatorResource, OpenStack\Compute\v2\Models\AvailabilityZone, OpenStack\Compute\v2\Models\Flavor, OpenStack\Compute\v2\Models\Host, OpenStack\Compute\v2\Models\Hypervisor, OpenStack\Compute\v2\Models\HypervisorStatistic, OpenStack\Compute\v2\Models\Image, OpenStack\Compute\v2\Models\Keypair, OpenStack\Compute\v2\Models\QuotaSet, OpenStack\Compute\v2\Models\Server, OpenStack\Identity\v2\Models\Catalog, OpenStack\Identity\v2\Models\Endpoint, OpenStack\Identity\v2\Models\Entry, OpenStack\Identity\v2\Models\Tenant, OpenStack\Identity\v2\Models\Token, OpenStack\Identity\v3\Models\Assignment, OpenStack\Identity\v3\Models\Catalog, OpenStack\Identity\v3\Models\Credential, OpenStack\Identity\v3\Models\Domain, OpenStack\Identity\v3\Models\Endpoint, OpenStack\Identity\v3\Models\Group, OpenStack\Identity\v3\Models\Policy, OpenStack\Identity\v3\Models\Project, OpenStack\Identity\v3\Models\Role, OpenStack\Identity\v3\Models\Service, OpenStack\Identity\v3\Models\Token, OpenStack\Identity\v3\Models\User, OpenStack\Images\v2\Models\Image, OpenStack\Images\v2\Models\Member, OpenStack\Metric\v1\Gnocchi\Models\Metric, OpenStack\Metric\v1\Gnocchi\Models\Resource, OpenStack\Metric\v1\Gnocchi\Models\ResourceType, OpenStack\Networking\v2\...ayer3\Models\FloatingIp, OpenStack\Networking\v2\...ns\Layer3\Models\Router, OpenStack\Networking\v2\...ps\Models\SecurityGroup, OpenStack\Networking\v2\...odels\SecurityGroupRule, OpenStack\Networking\v2\Models\InterfaceAttachment, OpenStack\Networking\v2\Models\LoadBalancer, OpenStack\Networking\v2\...adBalancerHealthMonitor, OpenStack\Networking\v2\...ls\LoadBalancerListener, OpenStack\Networking\v2\Models\LoadBalancerMember, OpenStack\Networking\v2\Models\LoadBalancerPool, OpenStack\Networking\v2\Models\LoadBalancerStat, OpenStack\Networking\v2\Models\LoadBalancerStatus, OpenStack\Networking\v2\Models\Network, OpenStack\Networking\v2\Models\Port, OpenStack\Networking\v2\Models\Quota, OpenStack\Networking\v2\Models\Subnet, OpenStack\ObjectStore\v1\Models\Account, OpenStack\ObjectStore\v1\Models\Container, OpenStack\ObjectStore\v1\Models\Object.

Let’s take a look at an example:

interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the interface:

    interface User
    {
        /** @return string */
        public function getPassword();
    
        /** @return string */
        public function getDisplayName();
    }
    
Loading history...
345
    }
346
347
    /**
348
     * Retrieves metadata from the API.
349
     *
350
     * @return array
351
     */
352
    public function getMetadata(): array
353
    {
354
        $response = $this->execute($this->api->getServerMetadata(), ['id' => $this->id]);
355
        return $this->parseMetadata($response);
356
    }
357
358
    /**
359
     * Resets all the metadata for this server with the values provided. All existing metadata keys
360
     * will either be replaced or removed.
361
     *
362
     * @param array $metadata {@see \OpenStack\Compute\v2\Api::putServerMetadata}
363
     */
364
    public function resetMetadata(array $metadata)
365
    {
366
        $response = $this->execute($this->api->putServerMetadata(), ['id' => $this->id, 'metadata' => $metadata]);
367
        $this->metadata = $this->parseMetadata($response);
368
    }
369
370
    /**
371
     * Merges the existing metadata for the server with the values provided. Any existing keys
372
     * referenced in the user options will be replaced with the user's new values. All other
373
     * existing keys will remain unaffected.
374
     *
375
     * @param array $metadata {@see \OpenStack\Compute\v2\Api::postServerMetadata}
376
     *
377
     * @return array
378
     */
379
    public function mergeMetadata(array $metadata)
380
    {
381
        $response = $this->execute($this->api->postServerMetadata(), ['id' => $this->id, 'metadata' => $metadata]);
382
        $this->metadata = $this->parseMetadata($response);
383
    }
384
385
    /**
386
     * Retrieve the value for a specific metadata key.
387
     *
388
     * @param string $key {@see \OpenStack\Compute\v2\Api::getServerMetadataKey}
389
     *
390
     * @return mixed
391
     */
392 View Code Duplication
    public function getMetadataItem(string $key)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
393
    {
394
        $response = $this->execute($this->api->getServerMetadataKey(), ['id' => $this->id, 'key' => $key]);
395
        $value = $this->parseMetadata($response)[$key];
396
        $this->metadata[$key] = $value;
397
        return $value;
398
    }
399
400
    /**
401
     * Remove a specific metadata key.
402
     *
403
     * @param string $key {@see \OpenStack\Compute\v2\Api::deleteServerMetadataKey}
404
     */
405 View Code Duplication
    public function deleteMetadataItem(string $key)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
406
    {
407
        if (isset($this->metadata[$key])) {
408
            unset($this->metadata[$key]);
409
        }
410
411
        $this->execute($this->api->deleteServerMetadataKey(), ['id' => $this->id, 'key' => $key]);
412
    }
413
414
415
    /**
416
     * Add security group to a server (addSecurityGroup action)
417
     *
418
     * @param array $options {@see \OpenStack\Compute\v2\Api::postSecurityGroup}
419
     *
420
     * @return SecurityGroup
421
     */
422
    public function addSecurityGroup(array $options) : SecurityGroup
423
    {
424
        $options['id'] = $this->id;
425
426
        $response = $this->execute($this->api->postSecurityGroup(), $options);
427
428
        return $this->model(SecurityGroup::class)->populateFromResponse($response);
429
    }
430
431
    /**
432
     * Add security group to a server (addSecurityGroup action)
433
     *
434
     * @param array $options {@see \OpenStack\Compute\v2\Api::deleteSecurityGroup}
435
     */
436
    public function removeSecurityGroup(array $options)
437
    {
438
        $options['id'] = $this->id;
439
        $this->execute($this->api->deleteSecurityGroup(), $options);
440
    }
441
442
    public function parseMetadata(ResponseInterface $response): array
443
    {
444
        return Utils::jsonDecode($response)['metadata'];
445
    }
446
447
    /**
448
     * Returns Generator for SecurityGroups
449
     *
450
     * @return \Generator
451
     */
452
    public function listSecurityGroups(): \Generator
453
    {
454
        return $this->model(SecurityGroup::class)->enumerate($this->api->getSecurityGroups(), ['id' => $this->id]);
0 ignored issues
show
Bug introduced by
It seems like you code against a concrete implementation and not the interface OpenStack\Common\Resource\ResourceInterface as the method enumerate() does only exist in the following implementations of said interface: OpenStack\BlockStorage\v2\Models\QuotaSet, OpenStack\BlockStorage\v2\Models\Snapshot, OpenStack\BlockStorage\v2\Models\Volume, OpenStack\BlockStorage\v2\Models\VolumeAttachment, OpenStack\BlockStorage\v2\Models\VolumeType, OpenStack\Common\Resource\OperatorResource, OpenStack\Compute\v2\Models\AvailabilityZone, OpenStack\Compute\v2\Models\Flavor, OpenStack\Compute\v2\Models\Host, OpenStack\Compute\v2\Models\Hypervisor, OpenStack\Compute\v2\Models\HypervisorStatistic, OpenStack\Compute\v2\Models\Image, OpenStack\Compute\v2\Models\Keypair, OpenStack\Compute\v2\Models\QuotaSet, OpenStack\Compute\v2\Models\Server, OpenStack\Identity\v2\Models\Catalog, OpenStack\Identity\v2\Models\Endpoint, OpenStack\Identity\v2\Models\Entry, OpenStack\Identity\v2\Models\Tenant, OpenStack\Identity\v2\Models\Token, OpenStack\Identity\v3\Models\Assignment, OpenStack\Identity\v3\Models\Catalog, OpenStack\Identity\v3\Models\Credential, OpenStack\Identity\v3\Models\Domain, OpenStack\Identity\v3\Models\Endpoint, OpenStack\Identity\v3\Models\Group, OpenStack\Identity\v3\Models\Policy, OpenStack\Identity\v3\Models\Project, OpenStack\Identity\v3\Models\Role, OpenStack\Identity\v3\Models\Service, OpenStack\Identity\v3\Models\Token, OpenStack\Identity\v3\Models\User, OpenStack\Images\v2\Models\Image, OpenStack\Images\v2\Models\Member, OpenStack\Metric\v1\Gnocchi\Models\Metric, OpenStack\Metric\v1\Gnocchi\Models\Resource, OpenStack\Metric\v1\Gnocchi\Models\ResourceType, OpenStack\Networking\v2\...ayer3\Models\FloatingIp, OpenStack\Networking\v2\...ns\Layer3\Models\Router, OpenStack\Networking\v2\...ps\Models\SecurityGroup, OpenStack\Networking\v2\...odels\SecurityGroupRule, OpenStack\Networking\v2\Models\InterfaceAttachment, OpenStack\Networking\v2\Models\LoadBalancer, OpenStack\Networking\v2\...adBalancerHealthMonitor, OpenStack\Networking\v2\...ls\LoadBalancerListener, OpenStack\Networking\v2\Models\LoadBalancerMember, OpenStack\Networking\v2\Models\LoadBalancerPool, OpenStack\Networking\v2\Models\LoadBalancerStat, OpenStack\Networking\v2\Models\LoadBalancerStatus, OpenStack\Networking\v2\Models\Network, OpenStack\Networking\v2\Models\Port, OpenStack\Networking\v2\Models\Quota, OpenStack\Networking\v2\Models\Subnet, OpenStack\ObjectStore\v1\Models\Account, OpenStack\ObjectStore\v1\Models\Container, OpenStack\ObjectStore\v1\Models\Object.

Let’s take a look at an example:

interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the interface:

    interface User
    {
        /** @return string */
        public function getPassword();
    
        /** @return string */
        public function getDisplayName();
    }
    
Loading history...
455
    }
456
457
458
    /**
459
     * Returns Generator for VolumeAttachment
460
     *
461
     * @return \Generator
462
     */
463
    public function listVolumeAttachments(): \Generator
464
    {
465
        return $this->model(VolumeAttachment::class)->enumerate($this->api->getVolumeAttachments(), ['id' => $this->id]);
0 ignored issues
show
Bug introduced by
It seems like you code against a concrete implementation and not the interface OpenStack\Common\Resource\ResourceInterface as the method enumerate() does only exist in the following implementations of said interface: OpenStack\BlockStorage\v2\Models\QuotaSet, OpenStack\BlockStorage\v2\Models\Snapshot, OpenStack\BlockStorage\v2\Models\Volume, OpenStack\BlockStorage\v2\Models\VolumeAttachment, OpenStack\BlockStorage\v2\Models\VolumeType, OpenStack\Common\Resource\OperatorResource, OpenStack\Compute\v2\Models\AvailabilityZone, OpenStack\Compute\v2\Models\Flavor, OpenStack\Compute\v2\Models\Host, OpenStack\Compute\v2\Models\Hypervisor, OpenStack\Compute\v2\Models\HypervisorStatistic, OpenStack\Compute\v2\Models\Image, OpenStack\Compute\v2\Models\Keypair, OpenStack\Compute\v2\Models\QuotaSet, OpenStack\Compute\v2\Models\Server, OpenStack\Identity\v2\Models\Catalog, OpenStack\Identity\v2\Models\Endpoint, OpenStack\Identity\v2\Models\Entry, OpenStack\Identity\v2\Models\Tenant, OpenStack\Identity\v2\Models\Token, OpenStack\Identity\v3\Models\Assignment, OpenStack\Identity\v3\Models\Catalog, OpenStack\Identity\v3\Models\Credential, OpenStack\Identity\v3\Models\Domain, OpenStack\Identity\v3\Models\Endpoint, OpenStack\Identity\v3\Models\Group, OpenStack\Identity\v3\Models\Policy, OpenStack\Identity\v3\Models\Project, OpenStack\Identity\v3\Models\Role, OpenStack\Identity\v3\Models\Service, OpenStack\Identity\v3\Models\Token, OpenStack\Identity\v3\Models\User, OpenStack\Images\v2\Models\Image, OpenStack\Images\v2\Models\Member, OpenStack\Metric\v1\Gnocchi\Models\Metric, OpenStack\Metric\v1\Gnocchi\Models\Resource, OpenStack\Metric\v1\Gnocchi\Models\ResourceType, OpenStack\Networking\v2\...ayer3\Models\FloatingIp, OpenStack\Networking\v2\...ns\Layer3\Models\Router, OpenStack\Networking\v2\...ps\Models\SecurityGroup, OpenStack\Networking\v2\...odels\SecurityGroupRule, OpenStack\Networking\v2\Models\InterfaceAttachment, OpenStack\Networking\v2\Models\LoadBalancer, OpenStack\Networking\v2\...adBalancerHealthMonitor, OpenStack\Networking\v2\...ls\LoadBalancerListener, OpenStack\Networking\v2\Models\LoadBalancerMember, OpenStack\Networking\v2\Models\LoadBalancerPool, OpenStack\Networking\v2\Models\LoadBalancerStat, OpenStack\Networking\v2\Models\LoadBalancerStatus, OpenStack\Networking\v2\Models\Network, OpenStack\Networking\v2\Models\Port, OpenStack\Networking\v2\Models\Quota, OpenStack\Networking\v2\Models\Subnet, OpenStack\ObjectStore\v1\Models\Account, OpenStack\ObjectStore\v1\Models\Container, OpenStack\ObjectStore\v1\Models\Object.

Let’s take a look at an example:

interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the interface:

    interface User
    {
        /** @return string */
        public function getPassword();
    
        /** @return string */
        public function getDisplayName();
    }
    
Loading history...
466
    }
467
468
    /**
469
     * Attach a volume and returns volume that was attached
470
     *
471
     * @param $volumeId
472
     *
473
     * @return VolumeAttachment
474
     */
475
    public function attachVolume(string $volumeId): VolumeAttachment
476
    {
477
        $response =  $this->execute($this->api->postVolumeAttachments(), ['id' => $this->id, 'volumeId' => $volumeId]);
478
479
        return $this->model(VolumeAttachment::class)->populateFromResponse($response);
480
    }
481
482
    /**
483
     * Detach a volume
484
     *
485
     * @param $attachmentId
486
     *
487
     * @return void
488
     */
489
    public function detachVolume(string $attachmentId)
490
    {
491
        $this->execute($this->api->deleteVolumeAttachments(), ['id' => $this->id, 'attachmentId' => $attachmentId]);
492
    }
493
}
494