OpenStack\Common\Transport\Utils

Complexity

Total Complexity

12

Size/Duplication

Total Lines	80
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
B	jsonDecode()	0	27	4
A	flattenJson()	0	4	4
A	normalizeUrl()	0	8	2
A	addPaths()	0	4	1
A	appendPath()	0	4	1

<?php declare(strict_types=1);

namespace OpenStack\Common\Transport;

use function GuzzleHttp\Psr7\uri_for;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\UriInterface;

class Utils
{
    public static function jsonDecode(ResponseInterface $response, bool $assoc = true)
    {
        $jsonErrors = [
            JSON_ERROR_DEPTH => 'JSON_ERROR_DEPTH - Maximum stack depth exceeded',
            JSON_ERROR_STATE_MISMATCH => 'JSON_ERROR_STATE_MISMATCH - Underflow or the modes mismatch',
            JSON_ERROR_CTRL_CHAR => 'JSON_ERROR_CTRL_CHAR - Unexpected control character found',
            JSON_ERROR_SYNTAX => 'JSON_ERROR_SYNTAX - Syntax error, malformed JSON',
            JSON_ERROR_UTF8 => 'JSON_ERROR_UTF8 - Malformed UTF-8 characters, possibly incorrectly encoded'
        ];

        $responseBody = (string) $response->getBody();

        if (strlen($responseBody) === 0) {
            return $responseBody;
        }

        $data = json_decode($responseBody, $assoc);

        if (JSON_ERROR_NONE !== json_last_error()) {
            $last = json_last_error();
            throw new \InvalidArgumentException(
                'Unable to parse JSON data: ' . (isset($jsonErrors[$last]) ? $jsonErrors[$last] : 'Unknown error')
            );
        }

        return $data;
    }

    /**
     * Method for flattening a nested array.
     *
     * @param array $data The nested array
     * @param string  $key  The key to extract
     *
     * @return array
     */
    public static function flattenJson($data, string $key = null)
    {
        return (!empty($data) && $key && isset($data[$key])) ? $data[$key] : $data;

The expression $key of type null|string is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

    }

    /**
     * Method for normalize an URL string.
     *
     * Append the http:// prefix if not present, and add a
     * closing url separator when missing.
     *
     * @param string $url The url representation.
     *
     * @return string
     */
    public static function normalizeUrl(string $url): string
    {
        if (strpos($url, 'http') === false) {
            $url = 'http://' . $url;
        }

        return rtrim($url, '/') . '/';
    }

    /**
     * Add an unlimited list of paths to a given URI.
     *
     * @param UriInterface $uri
     * @param              ...$paths
     *
     * @return UriInterface
     */
    public static function addPaths(UriInterface $uri, ...$paths): UriInterface
    {
        return uri_for(rtrim((string) $uri, '/') . '/' . implode('/', $paths));
    }

    public static function appendPath(UriInterface $uri, $path): UriInterface
    {
        return uri_for(rtrim((string) $uri, '/') . '/' . $path);
    }
}