ReplaceBase64FileExtensionPassTest - Code Metrics - Inspection of "Add support for IvoryBase64FileBundle" - php-lug/lug - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#34)

by Eric

created 2016-05-18 15:52 UTC

ReplaceBase64FileExtensionPassTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	57
Duplicated Lines	43.86 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
wmc	5
c	1
b	0
f	1
lcom	1
cbo	2
dl	25
loc	57
rs	10

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	4	1
B	testProcess()	25	25	2
A	createContainerBuilderMock()	0	4	1
A	createDefinitionMock()	0	4	1

How to fix Duplicated Code

<?php

/*
 * This file is part of the Lug package.
 *
 * (c) Eric GELOEN <[email protected]>
 *
 * For the full copyright and license information, please read the LICENSE
 * file that was distributed with this source code.
 */

namespace Lug\Bundle\ResourceBundle\Tests\DependencyInjection\Compiler;

use Lug\Bundle\ResourceBundle\DependencyInjection\Compiler\ReplaceBase64FileExtensionPass;
use Lug\Bundle\ResourceBundle\Form\Extension\Base64FileExtension;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Definition;
use Symfony\Component\DependencyInjection\Reference;

/**
 * @author GeLo <[email protected]>
 */
class ReplaceBase64FileExtensionPassTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @var ReplaceBase64FileExtensionPass
     */
    private $compiler;

    /**
     * {@inheritdoc}
     */
    protected function setUp()
    {
        $this->compiler = new ReplaceBase64FileExtensionPass();
    }

    public function testProcess()

    {
        $container = $this->createContainerBuilderMock();
        $container
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->expects($this->once())
            ->method('getDefinition')
            ->with($this->identicalTo('ivory.base64_file.form.extension'))
            ->will($this->returnValue($definition = $this->createDefinitionMock()));

        $definition
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->expects($this->once())
            ->method('setClass')
            ->with($this->identicalTo(Base64FileExtension::class))
            ->will($this->returnSelf());

        $definition
            ->expects($this->once())
            ->method('addArgument')
            ->with($this->callback(function ($reference) {
                return $reference instanceof Reference
                    && (string) $reference === 'lug.resource.routing.parameter_resolver';
            }));

        $this->compiler->process($container);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     * @return \PHPUnit_Framework_MockObject_MockObject|ContainerBuilder
     */
    private function createContainerBuilderMock()
    {
        return $this->getMock(ContainerBuilder::class);

    }

    /**
     * @return \PHPUnit_Framework_MockObject_MockObject|Definition
     */
    private function createDefinitionMock()
    {
        return $this->getMock(Definition::class);

    }
}


Pull Request — master (#34)

ReplaceBase64FileExtensionPassTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

1		<?php
2
3		/*
4		* This file is part of the Lug package.
5		*
6		* (c) Eric GELOEN <[email protected]>
7		*
8		* For the full copyright and license information, please read the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Lug\Bundle\ResourceBundle\Tests\DependencyInjection\Compiler;
13
14		use Lug\Bundle\ResourceBundle\DependencyInjection\Compiler\ReplaceBase64FileExtensionPass;
15		use Lug\Bundle\ResourceBundle\Form\Extension\Base64FileExtension;
16		use Symfony\Component\DependencyInjection\ContainerBuilder;
17		use Symfony\Component\DependencyInjection\Definition;
18		use Symfony\Component\DependencyInjection\Reference;
19
20		/**
21		* @author GeLo <[email protected]>
22		*/
23		class ReplaceBase64FileExtensionPassTest extends \PHPUnit_Framework_TestCase
24		{
25		/**
26		* @var ReplaceBase64FileExtensionPass
27		*/
28		private $compiler;
29
30		/**
31		* {@inheritdoc}
32		*/
33		protected function setUp()
34		{
35		$this->compiler = new ReplaceBase64FileExtensionPass();
36		}
37
38	View Code Duplication	public function testProcess()
		0 ignored issues – show Duplication introduced 2016-05-18 16:03 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
39		{
40		$container = $this->createContainerBuilderMock();
41		$container
		0 ignored issues – show Bug introduced 2016-05-18 16:02 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `Symfony\Component\Depend...ection\ContainerBuilder`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
42		->expects($this->once())
43		->method('getDefinition')
44		->with($this->identicalTo('ivory.base64_file.form.extension'))
45		->will($this->returnValue($definition = $this->createDefinitionMock()));
46
47		$definition
		0 ignored issues – show Bug introduced 2016-05-18 16:02 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `Symfony\Component\DependencyInjection\Definition`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
48		->expects($this->once())
49		->method('setClass')
50		->with($this->identicalTo(Base64FileExtension::class))
51		->will($this->returnSelf());
52
53		$definition
54		->expects($this->once())
55		->method('addArgument')
56		->with($this->callback(function ($reference) {
57		return $reference instanceof Reference
58		&& (string) $reference === 'lug.resource.routing.parameter_resolver';
59		}));
60
61		$this->compiler->process($container);
		0 ignored issues – show Bug introduced 2016-05-18 16:02 UTC by Report Bug Copy Issue Report It seems like `$container` defined by `$this->createContainerBuilderMock()` on line `40` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `Lug\Bundle\ResourceBundl...xtensionPass::process()` does only seem to accept `object<Symfony\Component...ction\ContainerBuilder>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
62		}
63
64		/**
65		* @return \PHPUnit_Framework_MockObject_MockObject\|ContainerBuilder
66		*/
67		private function createContainerBuilderMock()
68		{
69		return $this->getMock(ContainerBuilder::class);
		0 ignored issues – show Deprecated Code introduced 2016-05-18 16:02 UTC by Report Bug Copy Issue Report The method `PHPUnit_Framework_TestCase::getMock()` has been deprecated with message: Method deprecated since Release 5.4.0 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
70		}
71
72		/**
73		* @return \PHPUnit_Framework_MockObject_MockObject\|Definition
74		*/
75		private function createDefinitionMock()
76		{
77		return $this->getMock(Definition::class);
		0 ignored issues – show Deprecated Code introduced 2016-05-18 16:02 UTC by Report Bug Copy Issue Report The method `PHPUnit_Framework_TestCase::getMock()` has been deprecated with message: Method deprecated since Release 5.4.0 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
78		}
79		}
80

php-lug / lug

Pull Request — master (#34)

ReplaceBase64FileExtensionPassTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like