Inspection of "Upgrade to Symfony 3 architecture" - php-lug/lug - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#68)

by Eric

created 2016-07-20 15:12 UTC

Status

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -426,7 +426,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|EntityManager
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createEntityManagerMock()
     {
@@ -434,7 +434,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|ClassMetadata
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createClassMetadataMock()
     {
@@ -442,7 +442,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|ResourceInterface
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createResourceMock()
     {
@@ -450,7 +450,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|LocaleContextInterface
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createLocaleContextMock()
     {
@@ -458,7 +458,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|QueryBuilder
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createQueryBuilderMock()
     {
@@ -466,7 +466,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|Expr
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createExprMock()
     {

Please login to merge, or discard this patch.

ResourceBundle/DependencyInjection/Extension/ResourceConfiguration.php 1 patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -201,7 +201,7 @@
 block discarded – undo
     /**
      * @param string        $name
      * @param string        $type
-     * @param mixed         $default
+     * @param string|null         $default
      * @param callable|null $if
      * @param string|null   $then
      *

Please login to merge, or discard this patch.

EventSubscriber/Doctrine/MongoDB/ResolveTargetDocumentSubscriberTest.php 1 patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -61,7 +61,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|LoadClassMetadataEventArgs
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createLoadClassMetadataEventArgsMock()
     {
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|ClassMetadata
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createClassMetadataMock()
     {

Please login to merge, or discard this patch.

Tests/EventSubscriber/Doctrine/MongoDB/ResourceSubscriberTest.php 1 patch

Doc Comments +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -287,7 +287,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|RegistryInterface
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createServiceRegistryMock()
     {
@@ -295,7 +295,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|LoadClassMetadataEventArgs
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createLoadClassMetadataEventArgsMock()
     {
@@ -303,7 +303,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|ObjectManager
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createObjectManagerMock()
     {
@@ -311,7 +311,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|ClassMetadata
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createClassMetadataMock()
     {
@@ -319,7 +319,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|ResourceInterface
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createResourceMock()
     {

Please login to merge, or discard this patch.

src/Component/Grid/Tests/Column/Type/BooleanTypeTest.php 1 patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -112,7 +112,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|PropertyAccessorInterface
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createPropertyAccessorMock()
     {
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|\Twig_Environment
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createTwigEnvironmentMock()
     {
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|ColumnInterface
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createColumnMock()
     {

Please login to merge, or discard this patch.

Tests/Form/Type/Doctrine/MongoDB/AbstractResourceChoiceTypeTest.php 1 patch

Doc Comments +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -171,7 +171,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|ResourceInterface
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createResourceMock()
     {
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|ManagerRegistry
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createManagerRegistryMock()
     {
@@ -187,7 +187,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|DocumentManager
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createDocumentManagerMock()
     {
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|ClassMetadata
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createClassMetadataMock()
     {
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|DocumentRepository
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createRepositoryMock()
     {
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|Query
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createQueryMock()
     {
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|Iterator
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createIteratorMock()
     {

Please login to merge, or discard this patch.

src/Bundle/ResourceBundle/Tests/EventListener/MessageListenerTest.php 1 patch

Doc Comments +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -317,7 +317,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|TranslatorInterface
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createTranslatorMock()
     {
@@ -325,7 +325,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|PropertyAccessorInterface
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createPropertyAccessorMock()
     {
@@ -333,7 +333,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|ParameterResolverInterface
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createParameterResolverMock()
     {
@@ -341,7 +341,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|DomainEvent
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createDomainEventMock()
     {
@@ -349,7 +349,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|ResourceInterface
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createResourceMock()
     {

Please login to merge, or discard this patch.

src/Bundle/ResourceBundle/Tests/Form/Extension/Base64FileExtensionTest.php 1 patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -63,7 +63,7 @@
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|ParameterResolverInterface
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createParameterResolverMock()
     {

Please login to merge, or discard this patch.

Tests/Rest/Action/EventSubscriber/ViewActionSubscriberTest.php 1 patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -177,7 +177,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|ParameterResolverInterface
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createParameterResolverMock()
     {
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|ActionEvent
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createActionEventMock()
     {
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|FormInterface
+     * @return \PHPUnit_Framework_MockObject_MockObject
      */
     private function createFormMock()
     {

Please login to merge, or discard this patch.

		@@ -426,7 +426,7 @@ discard block
		block discarded – undo
426	426	}
427	427
428	428	/**
429		- * @return \PHPUnit_Framework_MockObject_MockObject\|EntityManager
	429	+ * @return \PHPUnit_Framework_MockObject_MockObject
430	430	*/
431	431	private function createEntityManagerMock()
432	432	{
		@@ -434,7 +434,7 @@ discard block
		block discarded – undo
434	434	}
435	435
436	436	/**
437		- * @return \PHPUnit_Framework_MockObject_MockObject\|ClassMetadata
	437	+ * @return \PHPUnit_Framework_MockObject_MockObject
438	438	*/
439	439	private function createClassMetadataMock()
440	440	{
		@@ -442,7 +442,7 @@ discard block
		block discarded – undo
442	442	}
443	443
444	444	/**
445		- * @return \PHPUnit_Framework_MockObject_MockObject\|ResourceInterface
	445	+ * @return \PHPUnit_Framework_MockObject_MockObject
446	446	*/
447	447	private function createResourceMock()
448	448	{
		@@ -450,7 +450,7 @@ discard block
		block discarded – undo
450	450	}
451	451
452	452	/**
453		- * @return \PHPUnit_Framework_MockObject_MockObject\|LocaleContextInterface
	453	+ * @return \PHPUnit_Framework_MockObject_MockObject
454	454	*/
455	455	private function createLocaleContextMock()
456	456	{
		@@ -458,7 +458,7 @@ discard block
		block discarded – undo
458	458	}
459	459
460	460	/**
461		- * @return \PHPUnit_Framework_MockObject_MockObject\|QueryBuilder
	461	+ * @return \PHPUnit_Framework_MockObject_MockObject
462	462	*/
463	463	private function createQueryBuilderMock()
464	464	{
		@@ -466,7 +466,7 @@ discard block
		block discarded – undo
466	466	}
467	467
468	468	/**
469		- * @return \PHPUnit_Framework_MockObject_MockObject\|Expr
	469	+ * @return \PHPUnit_Framework_MockObject_MockObject
470	470	*/
471	471	private function createExprMock()
472	472	{

		@@ -287,7 +287,7 @@ discard block
		block discarded – undo
287	287	}
288	288
289	289	/**
290		- * @return \PHPUnit_Framework_MockObject_MockObject\|RegistryInterface
	290	+ * @return \PHPUnit_Framework_MockObject_MockObject
291	291	*/
292	292	private function createServiceRegistryMock()
293	293	{
		@@ -295,7 +295,7 @@ discard block
		block discarded – undo
295	295	}
296	296
297	297	/**
298		- * @return \PHPUnit_Framework_MockObject_MockObject\|LoadClassMetadataEventArgs
	298	+ * @return \PHPUnit_Framework_MockObject_MockObject
299	299	*/
300	300	private function createLoadClassMetadataEventArgsMock()
301	301	{
		@@ -303,7 +303,7 @@ discard block
		block discarded – undo
303	303	}
304	304
305	305	/**
306		- * @return \PHPUnit_Framework_MockObject_MockObject\|ObjectManager
	306	+ * @return \PHPUnit_Framework_MockObject_MockObject
307	307	*/
308	308	private function createObjectManagerMock()
309	309	{
		@@ -311,7 +311,7 @@ discard block
		block discarded – undo
311	311	}
312	312
313	313	/**
314		- * @return \PHPUnit_Framework_MockObject_MockObject\|ClassMetadata
	314	+ * @return \PHPUnit_Framework_MockObject_MockObject
315	315	*/
316	316	private function createClassMetadataMock()
317	317	{
		@@ -319,7 +319,7 @@ discard block
		block discarded – undo
319	319	}
320	320
321	321	/**
322		- * @return \PHPUnit_Framework_MockObject_MockObject\|ResourceInterface
	322	+ * @return \PHPUnit_Framework_MockObject_MockObject
323	323	*/
324	324	private function createResourceMock()
325	325	{

		@@ -112,7 +112,7 @@ discard block
		block discarded – undo
112	112	}
113	113
114	114	/**
115		- * @return \PHPUnit_Framework_MockObject_MockObject\|PropertyAccessorInterface
	115	+ * @return \PHPUnit_Framework_MockObject_MockObject
116	116	*/
117	117	private function createPropertyAccessorMock()
118	118	{
		@@ -120,7 +120,7 @@ discard block
		block discarded – undo
120	120	}
121	121
122	122	/**
123		- * @return \PHPUnit_Framework_MockObject_MockObject\|\Twig_Environment
	123	+ * @return \PHPUnit_Framework_MockObject_MockObject
124	124	*/
125	125	private function createTwigEnvironmentMock()
126	126	{
		@@ -128,7 +128,7 @@ discard block
		block discarded – undo
128	128	}
129	129
130	130	/**
131		- * @return \PHPUnit_Framework_MockObject_MockObject\|ColumnInterface
	131	+ * @return \PHPUnit_Framework_MockObject_MockObject
132	132	*/
133	133	private function createColumnMock()
134	134	{

		@@ -171,7 +171,7 @@ discard block
		block discarded – undo
171	171	}
172	172
173	173	/**
174		- * @return \PHPUnit_Framework_MockObject_MockObject\|ResourceInterface
	174	+ * @return \PHPUnit_Framework_MockObject_MockObject
175	175	*/
176	176	private function createResourceMock()
177	177	{
		@@ -179,7 +179,7 @@ discard block
		block discarded – undo
179	179	}
180	180
181	181	/**
182		- * @return \PHPUnit_Framework_MockObject_MockObject\|ManagerRegistry
	182	+ * @return \PHPUnit_Framework_MockObject_MockObject
183	183	*/
184	184	private function createManagerRegistryMock()
185	185	{
		@@ -187,7 +187,7 @@ discard block
		block discarded – undo
187	187	}
188	188
189	189	/**
190		- * @return \PHPUnit_Framework_MockObject_MockObject\|DocumentManager
	190	+ * @return \PHPUnit_Framework_MockObject_MockObject
191	191	*/
192	192	private function createDocumentManagerMock()
193	193	{
		@@ -195,7 +195,7 @@ discard block
		block discarded – undo
195	195	}
196	196
197	197	/**
198		- * @return \PHPUnit_Framework_MockObject_MockObject\|ClassMetadata
	198	+ * @return \PHPUnit_Framework_MockObject_MockObject
199	199	*/
200	200	private function createClassMetadataMock()
201	201	{
		@@ -203,7 +203,7 @@ discard block
		block discarded – undo
203	203	}
204	204
205	205	/**
206		- * @return \PHPUnit_Framework_MockObject_MockObject\|DocumentRepository
	206	+ * @return \PHPUnit_Framework_MockObject_MockObject
207	207	*/
208	208	private function createRepositoryMock()
209	209	{
		@@ -223,7 +223,7 @@ discard block
		block discarded – undo
223	223	}
224	224
225	225	/**
226		- * @return \PHPUnit_Framework_MockObject_MockObject\|Query
	226	+ * @return \PHPUnit_Framework_MockObject_MockObject
227	227	*/
228	228	private function createQueryMock()
229	229	{
		@@ -231,7 +231,7 @@ discard block
		block discarded – undo
231	231	}
232	232
233	233	/**
234		- * @return \PHPUnit_Framework_MockObject_MockObject\|Iterator
	234	+ * @return \PHPUnit_Framework_MockObject_MockObject
235	235	*/
236	236	private function createIteratorMock()
237	237	{

		@@ -317,7 +317,7 @@ discard block
		block discarded – undo
317	317	}
318	318
319	319	/**
320		- * @return \PHPUnit_Framework_MockObject_MockObject\|TranslatorInterface
	320	+ * @return \PHPUnit_Framework_MockObject_MockObject
321	321	*/
322	322	private function createTranslatorMock()
323	323	{
		@@ -325,7 +325,7 @@ discard block
		block discarded – undo
325	325	}
326	326
327	327	/**
328		- * @return \PHPUnit_Framework_MockObject_MockObject\|PropertyAccessorInterface
	328	+ * @return \PHPUnit_Framework_MockObject_MockObject
329	329	*/
330	330	private function createPropertyAccessorMock()
331	331	{
		@@ -333,7 +333,7 @@ discard block
		block discarded – undo
333	333	}
334	334
335	335	/**
336		- * @return \PHPUnit_Framework_MockObject_MockObject\|ParameterResolverInterface
	336	+ * @return \PHPUnit_Framework_MockObject_MockObject
337	337	*/
338	338	private function createParameterResolverMock()
339	339	{
		@@ -341,7 +341,7 @@ discard block
		block discarded – undo
341	341	}
342	342
343	343	/**
344		- * @return \PHPUnit_Framework_MockObject_MockObject\|DomainEvent
	344	+ * @return \PHPUnit_Framework_MockObject_MockObject
345	345	*/
346	346	private function createDomainEventMock()
347	347	{
		@@ -349,7 +349,7 @@ discard block
		block discarded – undo
349	349	}
350	350
351	351	/**
352		- * @return \PHPUnit_Framework_MockObject_MockObject\|ResourceInterface
	352	+ * @return \PHPUnit_Framework_MockObject_MockObject
353	353	*/
354	354	private function createResourceMock()
355	355	{

		@@ -201,7 +201,7 @@
		block discarded – undo
201	201	/**
202	202	* @param string $name
203	203	* @param string $type
204		- * @param mixed $default
	204	+ * @param string\|null $default
205	205	* @param callable\|null $if
206	206	* @param string\|null $then
207	207	*

		@@ -61,7 +61,7 @@ discard block
		block discarded – undo
61	61	}
62	62
63	63	/**
64		- * @return \PHPUnit_Framework_MockObject_MockObject\|LoadClassMetadataEventArgs
	64	+ * @return \PHPUnit_Framework_MockObject_MockObject
65	65	*/
66	66	private function createLoadClassMetadataEventArgsMock()
67	67	{
		@@ -69,7 +69,7 @@ discard block
		block discarded – undo
69	69	}
70	70
71	71	/**
72		- * @return \PHPUnit_Framework_MockObject_MockObject\|ClassMetadata
	72	+ * @return \PHPUnit_Framework_MockObject_MockObject
73	73	*/
74	74	private function createClassMetadataMock()
75	75	{

		@@ -63,7 +63,7 @@
		block discarded – undo
63	63	}
64	64
65	65	/**
66		- * @return \PHPUnit_Framework_MockObject_MockObject\|ParameterResolverInterface
	66	+ * @return \PHPUnit_Framework_MockObject_MockObject
67	67	*/
68	68	private function createParameterResolverMock()
69	69	{

		@@ -177,7 +177,7 @@ discard block
		block discarded – undo
177	177	}
178	178
179	179	/**
180		- * @return \PHPUnit_Framework_MockObject_MockObject\|ParameterResolverInterface
	180	+ * @return \PHPUnit_Framework_MockObject_MockObject
181	181	*/
182	182	private function createParameterResolverMock()
183	183	{
		@@ -185,7 +185,7 @@ discard block
		block discarded – undo
185	185	}
186	186
187	187	/**
188		- * @return \PHPUnit_Framework_MockObject_MockObject\|ActionEvent
	188	+ * @return \PHPUnit_Framework_MockObject_MockObject
189	189	*/
190	190	private function createActionEventMock()
191	191	{
		@@ -193,7 +193,7 @@ discard block
		block discarded – undo
193	193	}
194	194
195	195	/**
196		- * @return \PHPUnit_Framework_MockObject_MockObject\|FormInterface
	196	+ * @return \PHPUnit_Framework_MockObject_MockObject
197	197	*/
198	198	private function createFormMock()
199	199	{

php-lug / lug

Pull Request — master (#68)

Status

Category

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

Doc Comments +5 added lines, -5 removed lines patch added patch discarded remove patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

Doc Comments +7 added lines, -7 removed lines patch added patch discarded remove patch

Doc Comments +5 added lines, -5 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch