Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 27 | trait TranslatableRepositoryTrait |
||
| 28 | { |
||
| 29 | use RepositoryTrait { |
||
| 30 | __construct as private constructFromRepositoryTrait; |
||
| 31 | createQueryBuilder as private createQueryBuilderFromRepositoryTrait; |
||
| 32 | getProperty as private getPropertyFromRepositoryTrait; |
||
| 33 | } |
||
| 34 | |||
| 35 | /** |
||
| 36 | * @var LocaleContextInterface |
||
| 37 | */ |
||
| 38 | private $localeContext; |
||
| 39 | |||
| 40 | /** |
||
| 41 | * @var string[] |
||
| 42 | */ |
||
| 43 | private $cache; |
||
| 44 | |||
| 45 | /** |
||
| 46 | * @param EntityManager $em |
||
| 47 | * @param ClassMetadata $class |
||
| 48 | * @param ResourceInterface $resource |
||
| 49 | * @param LocaleContextInterface $localeContext |
||
| 50 | */ |
||
| 51 | 5 | public function __construct( |
|
| 52 | $em, |
||
| 53 | ClassMetadata $class, |
||
| 54 | ResourceInterface $resource, |
||
| 55 | LocaleContextInterface $localeContext |
||
| 56 | ) { |
||
| 57 | 5 | $this->constructFromRepositoryTrait($em, $class, $resource); |
|
|
|
|||
| 58 | |||
| 59 | 5 | $this->localeContext = $localeContext; |
|
| 60 | 5 | } |
|
| 61 | |||
| 62 | /** |
||
| 63 | * {@inheritdoc} |
||
| 64 | */ |
||
| 65 | 2 | public function createQueryBuilder($alias = null, $indexBy = null) |
|
| 66 | { |
||
| 67 | 2 | $queryBuilder = $this->createQueryBuilderFromRepositoryTrait($alias, $indexBy); |
|
| 68 | $queryBuilder |
||
| 69 | 2 | ->addSelect($alias = $this->getTranslationAlias($queryBuilder)) |
|
| 70 | 2 | ->leftJoin($this->getProperty('translations', $queryBuilder), $alias); |
|
| 71 | |||
| 72 | 2 | return $queryBuilder; |
|
| 73 | } |
||
| 74 | |||
| 75 | /** |
||
| 76 | * {@inheritdoc} |
||
| 77 | */ |
||
| 78 | 1 | public function createQueryBuilderForCollection($alias = null, $indexBy = null) |
|
| 92 | |||
| 93 | /** |
||
| 94 | * {@inheritdoc} |
||
| 95 | */ |
||
| 96 | 3 | View Code Duplication | public function getProperty($property, $root = null) |
| 97 | { |
||
| 98 | 3 | if ($this->cache === null) { |
|
| 99 | 3 | $translatableFields = $this->getClassMetadata()->getFieldNames(); |
|
| 100 | 3 | $translationFields = $this->getEntityManager() |
|
| 101 | 3 | ->getClassMetadata($this->getClassMetadata()->getAssociationMapping('translations')['targetEntity']) |
|
| 102 | 3 | ->getFieldNames(); |
|
| 103 | |||
| 104 | 3 | $this->cache = array_diff($translationFields, $translatableFields); |
|
| 105 | 3 | } |
|
| 106 | |||
| 107 | 3 | if (in_array($property, $this->cache, true)) { |
|
| 108 | 1 | $root = $this->getTranslationAlias($root); |
|
| 109 | 1 | } |
|
| 110 | |||
| 111 | 3 | return $this->getPropertyFromRepositoryTrait($property, $root); |
|
| 112 | } |
||
| 113 | |||
| 114 | /** |
||
| 115 | * @param QueryBuilder|string|null $root |
||
| 116 | * |
||
| 117 | * @return string |
||
| 118 | */ |
||
| 119 | 3 | private function getTranslationAlias($root) |
|
| 123 | |||
| 124 | /** |
||
| 125 | * @param QueryBuilder|string|null $root |
||
| 126 | * |
||
| 127 | * @return string |
||
| 128 | */ |
||
| 129 | 3 | private function getRootAlias($root) |
|
| 137 | |||
| 138 | /** |
||
| 139 | * @return string[] |
||
| 140 | */ |
||
| 141 | 1 | View Code Duplication | private function getLocales() |
| 151 | } |
||
| 152 |
This check looks for methods that are used by a trait but not required by it.
To illustrate, let’s look at the following code example
The trait
Idableprovides a methodequalsIdthat in turn relies on the methodgetId(). If this method does not exist on a class mixing in this trait, the method will fail.Adding the
getId()as an abstract method to the trait will make sure it is available.