CachedParameterResolverTest::testResolveCriteria() - Code Metrics - Inspection of "Merge pull request #33 from php-lug/security-voter" - php-lug/lug - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c114e4...0fa665 )

by Eric

created 2016-05-14 15:47 UTC

CachedParameterResolverTest::testResolveCriteria() A

↳ Parent: CachedParameterResolverTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	8

Duplication

Lines	11
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	11
loc	11
rs	9.4285
cc	1
eloc	8
nc	1
nop	0

<?php

/*
 * This file is part of the Lug package.
 *
 * (c) Eric GELOEN <[email protected]>
 *
 * For the full copyright and license information, please read the LICENSE
 * file that was distributed with this source code.
 */

namespace Lug\Bundle\ResourceBundle\Tests\Routing;

use Lug\Bundle\ResourceBundle\Routing\CachedParameterResolver;
use Lug\Bundle\ResourceBundle\Routing\ParameterResolverInterface;
use Lug\Component\Resource\Model\ResourceInterface;

/**
 * @author GeLo <[email protected]>
 */
class CachedParameterResolverTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @var CachedParameterResolver
     */
    private $cachedParameterResolver;

    /**
     * @var \PHPUnit_Framework_MockObject_MockObject|ParameterResolverInterface
     */
    private $parameterResolver;

    /**
     * {@inheritdoc}
     */
    protected function setUp()
    {
        $this->parameterResolver = $this->createParameterResolverMock();
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $this->cachedParameterResolver = new CachedParameterResolver($this->parameterResolver);
    }

    public function testInheritance()
    {
        $this->assertInstanceOf(ParameterResolverInterface::class, $this->cachedParameterResolver);
    }

    public function testResolveApi()

    {
        $this->parameterResolver
            ->expects($this->once())
            ->method('resolveApi')
            ->will($this->returnValue(true));

        $this->assertTrue($this->cachedParameterResolver->resolveApi());
        $this->assertTrue($this->cachedParameterResolver->resolveApi());
    }

    public function testResolveCriteria()

    {
        $this->parameterResolver
            ->expects($this->once())
            ->method('resolveCriteria')
            ->with($this->identicalTo($mandatory = false))
            ->will($this->returnValue($criteria = ['criteria']));

        $this->assertSame($criteria, $this->cachedParameterResolver->resolveCriteria($mandatory));
        $this->assertSame($criteria, $this->cachedParameterResolver->resolveCriteria($mandatory));
    }

    public function testResolveCriteriaMissing()
    {
        $this->parameterResolver
            ->expects($this->at(0))
            ->method('resolveCriteria')
            ->with($this->identicalTo($firstMandatory = false))
            ->will($this->returnValue($criteria = []));

        $this->parameterResolver
            ->expects($this->at(1))
            ->method('resolveCriteria')
            ->with($this->identicalTo($secondMandatory = true))
            ->will($this->throwException($exception = new \Exception()));

        $this->assertSame($criteria, $this->cachedParameterResolver->resolveCriteria($firstMandatory));

        try {
            $this->cachedParameterResolver->resolveCriteria($secondMandatory);
        } catch (\Exception $e) {
            $this->assertSame($exception, $e);
        }
    }

    public function testResolveCurrentPage()

    {
        $this->parameterResolver
            ->expects($this->once())
            ->method('resolveCurrentPage')
            ->will($this->returnValue($currentPage = 2));

        $this->assertSame($currentPage, $this->cachedParameterResolver->resolveCurrentPage());
        $this->assertSame($currentPage, $this->cachedParameterResolver->resolveCurrentPage());
    }

    public function testResolveForm()

    {
        $this->parameterResolver
            ->expects($this->once())
            ->method('resolveForm')
            ->with($this->identicalTo($resource = $this->createResourceMock()))
            ->will($this->returnValue($form = 'form'));

        $this->assertSame($form, $this->cachedParameterResolver->resolveForm($resource));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->assertSame($form, $this->cachedParameterResolver->resolveForm($resource));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    public function testResolveGrid()

    {
        $this->parameterResolver
            ->expects($this->once())
            ->method('resolveGrid')
            ->with($this->identicalTo($resource = $this->createResourceMock()))
            ->will($this->returnValue($grid = 'grid'));

        $this->assertSame($grid, $this->cachedParameterResolver->resolveGrid($resource));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->assertSame($grid, $this->cachedParameterResolver->resolveGrid($resource));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    public function testResolveHateoas()

    {
        $this->parameterResolver
            ->expects($this->once())
            ->method('resolveHateoas')
            ->will($this->returnValue(true));

        $this->assertTrue($this->cachedParameterResolver->resolveHateoas());
        $this->assertTrue($this->cachedParameterResolver->resolveHateoas());
    }

    public function testResolveLocationRoute()

    {
        $this->parameterResolver
            ->expects($this->once())
            ->method('resolveLocationRoute')
            ->will($this->returnValue($locationRoute = 'location_route'));

        $this->assertSame($locationRoute, $this->cachedParameterResolver->resolveLocationRoute());
        $this->assertSame($locationRoute, $this->cachedParameterResolver->resolveLocationRoute());
    }

    public function testResolveLocationRouteParameters()

    {
        $this->parameterResolver
            ->expects($this->once())
            ->method('resolveLocationRouteParameters')
            ->with($this->identicalTo($object = new \stdClass()))
            ->will($this->returnValue($locationRouteParameters = ['location_route_param']));

        $this->assertSame(
            $locationRouteParameters,
            $this->cachedParameterResolver->resolveLocationRouteParameters($object)
        );

        $this->assertSame(
            $locationRouteParameters,
            $this->cachedParameterResolver->resolveLocationRouteParameters($object)
        );
    }

    public function testResolveMaxPerPage()

    {
        $this->parameterResolver
            ->expects($this->once())
            ->method('resolveMaxPerPage')
            ->will($this->returnValue($maxPerPage = 5));

        $this->assertSame($maxPerPage, $this->cachedParameterResolver->resolveMaxPerPage());
        $this->assertSame($maxPerPage, $this->cachedParameterResolver->resolveMaxPerPage());
    }

    public function testResolveRedirectRoute()

    {
        $this->parameterResolver
            ->expects($this->once())
            ->method('resolveRedirectRoute')
            ->will($this->returnValue($redirectRoute = 'redirect_route'));

        $this->assertSame($redirectRoute, $this->cachedParameterResolver->resolveRedirectRoute());
        $this->assertSame($redirectRoute, $this->cachedParameterResolver->resolveRedirectRoute());
    }

    public function testResolveRedirectRouteParameters()
    {
        $this->parameterResolver
            ->expects($this->once())
            ->method('resolveRedirectRouteParameters')
            ->with(
                $this->identicalTo($object = new \stdClass()),
                $this->identicalTo($forwardParameters = true)
            )
            ->will($this->returnValue($redirectRouteParameters = ['redirect_route_param']));

        $this->assertSame(
            $redirectRouteParameters,
            $this->cachedParameterResolver->resolveRedirectRouteParameters($object, $forwardParameters)
        );

        $this->assertSame(
            $redirectRouteParameters,
            $this->cachedParameterResolver->resolveRedirectRouteParameters($object, $forwardParameters)
        );
    }

    public function testResolveRedirectRouteParametersForward()

    {
        $this->parameterResolver
            ->expects($this->once())
            ->method('resolveRedirectRouteParametersForward')
            ->will($this->returnValue(true));

        $this->assertTrue($this->cachedParameterResolver->resolveRedirectRouteParametersForward());
        $this->assertTrue($this->cachedParameterResolver->resolveRedirectRouteParametersForward());
    }

    public function testResolveRepositoryMethod()

    {
        $this->parameterResolver
            ->expects($this->once())
            ->method('resolveRepositoryMethod')
            ->with($this->identicalTo($action = 'action'))
            ->will($this->returnValue($repositoryMethod = 'repository_method'));

        $this->assertSame($repositoryMethod, $this->cachedParameterResolver->resolveRepositoryMethod($action));
        $this->assertSame($repositoryMethod, $this->cachedParameterResolver->resolveRepositoryMethod($action));
    }

    public function testResolveSerializerGroups()

    {
        $this->parameterResolver
            ->expects($this->once())
            ->method('resolveSerializerGroups')
            ->will($this->returnValue($groups = ['group']));

        $this->assertSame($groups, $this->cachedParameterResolver->resolveSerializerGroups());
        $this->assertSame($groups, $this->cachedParameterResolver->resolveSerializerGroups());
    }

    public function testResolveSerializerNull()

    {
        $this->parameterResolver
            ->expects($this->once())
            ->method('resolveSerializerNull')
            ->will($this->returnValue(true));

        $this->assertTrue($this->cachedParameterResolver->resolveSerializerNull());
        $this->assertTrue($this->cachedParameterResolver->resolveSerializerNull());
    }

    public function testResolveSorting()

    {
        $this->parameterResolver
            ->expects($this->once())
            ->method('resolveSorting')
            ->will($this->returnValue($sorting = ['sorting']));

        $this->assertSame($sorting, $this->cachedParameterResolver->resolveSorting());
        $this->assertSame($sorting, $this->cachedParameterResolver->resolveSorting());
    }

    public function testResolveTemplate()

    {
        $this->parameterResolver
            ->expects($this->once())
            ->method('resolveTemplate')
            ->will($this->returnValue($template = 'template'));

        $this->assertSame($template, $this->cachedParameterResolver->resolveTemplate());
        $this->assertSame($template, $this->cachedParameterResolver->resolveTemplate());
    }

    public function testResolveThemes()

    {
        $this->parameterResolver
            ->expects($this->once())
            ->method('resolveThemes')
            ->will($this->returnValue($themes = ['theme']));

        $this->assertSame($themes, $this->cachedParameterResolver->resolveThemes());
        $this->assertSame($themes, $this->cachedParameterResolver->resolveThemes());
    }

    public function testResolveTranslationDomain()

    {
        $this->parameterResolver
            ->expects($this->once())
            ->method('resolveTranslationDomain')
            ->will($this->returnValue($translationDomain = 'translation_domain'));

        $this->assertSame($translationDomain, $this->cachedParameterResolver->resolveTranslationDomain());
        $this->assertSame($translationDomain, $this->cachedParameterResolver->resolveTranslationDomain());
    }

    public function testResolveValidationGroups()

    {
        $this->parameterResolver
            ->expects($this->once())
            ->method('resolveValidationGroups')
            ->will($this->returnValue($groups = ['group']));

        $this->assertSame($groups, $this->cachedParameterResolver->resolveValidationGroups());
        $this->assertSame($groups, $this->cachedParameterResolver->resolveValidationGroups());
    }

    public function testResolveVoter()

    {
        $this->parameterResolver
            ->expects($this->once())
            ->method('resolveVoter')
            ->will($this->returnValue(true));

        $this->assertTrue($this->cachedParameterResolver->resolveVoter());
        $this->assertTrue($this->cachedParameterResolver->resolveVoter());
    }

    /**
     * @return \PHPUnit_Framework_MockObject_MockObject|ParameterResolverInterface
     */
    private function createParameterResolverMock()
    {
        return $this->getMock(ParameterResolverInterface::class);

    }

    /**
     * @return \PHPUnit_Framework_MockObject_MockObject|ResourceInterface
     */
    private function createResourceMock()
    {
        return $this->getMock(ResourceInterface::class);

    }
}


1			<?php
2
3			/*
4			* This file is part of the Lug package.
5			*
6			* (c) Eric GELOEN <[email protected]>
7			*
8			* For the full copyright and license information, please read the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Lug\Bundle\ResourceBundle\Tests\Routing;
13
14			use Lug\Bundle\ResourceBundle\Routing\CachedParameterResolver;
15			use Lug\Bundle\ResourceBundle\Routing\ParameterResolverInterface;
16			use Lug\Component\Resource\Model\ResourceInterface;
17
18			/**
19			* @author GeLo <[email protected]>
20			*/
21			class CachedParameterResolverTest extends \PHPUnit_Framework_TestCase
22			{
23			/**
24			* @var CachedParameterResolver
25			*/
26			private $cachedParameterResolver;
27
28			/**
29			* @var \PHPUnit_Framework_MockObject_MockObject\|ParameterResolverInterface
30			*/
31			private $parameterResolver;
32
33			/**
34			* {@inheritdoc}
35			*/
36			protected function setUp()
37			{
38			$this->parameterResolver = $this->createParameterResolverMock();
			0 ignored issues – show Documentation Bug introduced 2016-01-19 20:19 UTC by Report Bug Copy Issue Report It seems like `$this->createParameterResolverMock()` can also be of type `object<Lug\Bundle\Resour...meterResolverInterface>`. However, the property `$parameterResolver` is declared as type `object<PHPUnit_Framework_MockObject_MockObject>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
39			$this->cachedParameterResolver = new CachedParameterResolver($this->parameterResolver);

php-lug / lug

Push — master ( c114e4...0fa665 )

CachedParameterResolverTest::testResolveCriteria() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like