Lug\Component\Translation\Repository\Doctrine\ORM\TranslatableRepository

Complexity

Total Complexity

11

Size/Duplication

Total Lines	119
Duplicated Lines	22.69 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	10	1
A	createQueryBuilder()	0	9	1
A	createQueryBuilderForCollection()	0	14	1
A	getProperty()	17	17	3
A	getTranslationAlias()	0	4	1
A	getRootAlias()	0	8	2
A	getLocales()	10	10	2

<?php

/*
 * This file is part of the Lug package.
 *
 * (c) Eric GELOEN <geloen.eric@gmail.com>
 *
 * For the full copyright and license information, please read the LICENSE
 * file that was distributed with this source code.
 */

namespace Lug\Component\Translation\Repository\Doctrine\ORM;

use Doctrine\ORM\EntityManager;
use Doctrine\ORM\Mapping\ClassMetadata;
use Doctrine\ORM\Query\Expr\Join;
use Doctrine\ORM\QueryBuilder;
use Lug\Component\Resource\Model\ResourceInterface;
use Lug\Component\Resource\Repository\Doctrine\ORM\Repository;
use Lug\Component\Translation\Context\LocaleContextInterface;

/**
 * @author GeLo <geloen.eric@gmail.com>
 */
class TranslatableRepository extends Repository
{
    /**
     * @var LocaleContextInterface
     */
    private $localeContext;

    /**
     * @var string[]
     */
    private $cache;

    /**
     * @param EntityManager          $em
     * @param ClassMetadata          $class
     * @param ResourceInterface      $resource
     * @param LocaleContextInterface $localeContext
     */
    public function __construct(
        $em,
        ClassMetadata $class,
        ResourceInterface $resource,
        LocaleContextInterface $localeContext
    ) {
        parent::__construct($em, $class, $resource);

        $this->localeContext = $localeContext;
    }

    /**
     * {@inheritdoc}
     */
    public function createQueryBuilder($alias = null, $indexBy = null)
    {
        $queryBuilder = parent::createQueryBuilder($alias, $indexBy);
        $queryBuilder
            ->addSelect($alias = $this->getTranslationAlias($queryBuilder))
            ->leftJoin($this->getProperty('translations', $queryBuilder), $alias);

        return $queryBuilder;
    }

    /**
     * {@inheritdoc}
     */
    public function createQueryBuilderForCollection($alias = null, $indexBy = null)
    {
        $queryBuilder = parent::createQueryBuilder($alias, $indexBy);

It seems like you call parent on a different method (createQueryBuilder() instead of createQueryBuilderForCollection()). Are you sure this is correct? If so, you might want to change this to $this->createQueryBuilder().

        $queryBuilder
            ->addSelect($alias = $this->getTranslationAlias($queryBuilder))
            ->innerJoin(
                $this->getProperty('translations', $queryBuilder),
                $alias,
                Join::WITH,
                $queryBuilder->expr()->in($this->getProperty('locale', $queryBuilder), $this->getLocales())
            );

        return $queryBuilder;
    }

    /**
     * {@inheritdoc}
     */
    public function getProperty($property, $root = null)

This method seems to be duplicated in your project.

    {
        if ($this->cache === null) {
            $translatableFields = $this->getClassMetadata()->getFieldNames();
            $translationFields = $this->getEntityManager()
                ->getClassMetadata($this->getClassMetadata()->getAssociationMapping('translations')['targetEntity'])
                ->getFieldNames();

            $this->cache = array_diff($translationFields, $translatableFields);

It seems like array_diff($translationFields, $translatableFields) of type array<integer,integer|string> is incompatible with the declared type array<integer,string> of property $cache.

        }

        if (in_array($property, $this->cache, true)) {
            $root = $this->getTranslationAlias($root);
        }

        return parent::getProperty($property, $root);
    }

    /**
     * @param QueryBuilder|string|null $root
     *
     * @return string
     */
    private function getTranslationAlias($root)
    {
        return $this->getRootAlias($root).'_translation';
    }

    /**
     * @param QueryBuilder|string|null $root
     *
     * @return string
     */
    private function getRootAlias($root)

Consider using a different method name as you override a private method of the parent class.

    {
        if ($root instanceof QueryBuilder) {
            $root = $root->getRootAliases()[0];
        }

        return (string) $root;
    }

    /**
     * @return string[]
     */
    private function getLocales()

This method seems to be duplicated in your project.

    {
        $locales = $this->localeContext->getLocales();

        if (($fallbackLocale = $this->localeContext->getFallbackLocale()) !== null) {
            $locales[] = $fallbackLocale;
        }

        return $locales;
    }
}