RepositoryTest - Code Metrics - Inspection of "Move more code from bundles to components" - php-lug/lug - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 74c3c7...591b88 )

by Eric

created 2016-02-27 11:48 UTC

RepositoryTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	381
Duplicated Lines	27.56 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	28
c	1
b	0
f	0
lcom	1
cbo	6
dl	105
loc	381
rs	10

24 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	9	1
A	testInheritance()	0	5	1
A	testCreateDataSourceBuilder()	0	7	1
A	testCreateQueryBuilder()	0	6	1
A	testCreateQueryBuilderWithAlias()	0	6	1
A	testCreateQueryBuilderWithIndexBy()	0	6	1
A	testCreateQueryForCollectionBuilder()	0	6	1
A	testCreateQueryBuilderForCollectionWithAlias()	0	6	1
A	testCreateQueryBuilderForCollectionWithIndexBy()	0	6	1
A	testFindOneByWithNullValue()	16	16	1
A	testFindOneByWithScalarValue()	16	16	1
A	testFindOneByWithArrayValue()	16	16	1
B	testFindBy()	0	28	1
A	testFindForIndex()	9	9	1
A	testFindForShow()	16	16	1
A	testFindForUpdate()	16	16	1
A	testFindForDelete()	16	16	1
B	setUpQueryBuilder()	0	82	5
A	createEntityManagerMock()	0	6	1
A	createClassMetadataMock()	0	6	1
A	createResourceMock()	0	4	1
A	createQueryBuilderMock()	0	6	1
A	createExprMock()	0	4	1
A	createQueryMock()	0	4	1

How to fix Duplicated Code

<?php

/*
 * This file is part of the Lug package.
 *
 * (c) Eric GELOEN <[email protected]>
 *
 * For the full copyright and license information, please read the LICENSE
 * file that was distributed with this source code.
 */

namespace Lug\Component\Resource\Tests\Repository\Doctrine\ORM;

use Doctrine\ORM\EntityManager;
use Doctrine\ORM\EntityRepository;
use Doctrine\ORM\Mapping\ClassMetadata;
use Doctrine\ORM\Query;
use Doctrine\ORM\Query\Expr;
use Doctrine\ORM\QueryBuilder;
use Lug\Component\Grid\DataSource\Doctrine\ORM\DataSourceBuilder;
use Lug\Component\Resource\Model\ResourceInterface;
use Lug\Component\Resource\Repository\Doctrine\ORM\Repository;
use Lug\Component\Resource\Repository\RepositoryInterface;
use Pagerfanta\Adapter\DoctrineORMAdapter;
use Pagerfanta\Pagerfanta;

/**
 * @author GeLo <[email protected]>
 */
class RepositoryTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @var Repository
     */
    private $repository;

    /**
     * @var \PHPUnit_Framework_MockObject_MockObject|EntityManager
     */
    private $entityManager;

    /**
     * @var \PHPUnit_Framework_MockObject_MockObject|ClassMetadata
     */
    private $classMetadata;

    /**
     * @var \PHPUnit_Framework_MockObject_MockObject|ResourceInterface
     */
    private $resource;

    /**
     * @var string
     */
    private $class;

    /**
     * {@inheritdoc}
     */
    protected function setUp()
    {
        $this->entityManager = $this->createEntityManagerMock();
        $this->classMetadata = $this->createClassMetadataMock();
        $this->resource = $this->createResourceMock();
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $this->class = $this->classMetadata->name = \stdClass::class;

        $this->repository = new Repository($this->entityManager, $this->classMetadata, $this->resource);
    }

    public function testInheritance()
    {
        $this->assertInstanceOf(RepositoryInterface::class, $this->repository);
        $this->assertInstanceOf(EntityRepository::class, $this->repository);
    }

    public function testCreateDataSourceBuilder()
    {
        $this->setUpQueryBuilder();
        $dataSourceBuilder = $this->repository->createDataSourceBuilder();

        $this->assertInstanceOf(DataSourceBuilder::class, $dataSourceBuilder);
    }

    public function testCreateQueryBuilder()
    {
        $queryBuilder = $this->setUpQueryBuilder();

        $this->assertSame($queryBuilder, $this->repository->createQueryBuilder());
    }

    public function testCreateQueryBuilderWithAlias()
    {
        $queryBuilder = $this->setUpQueryBuilder(false, $alias = 'foo');

        $this->assertSame($queryBuilder, $this->repository->createQueryBuilder($alias));
    }

    public function testCreateQueryBuilderWithIndexBy()
    {
        $queryBuilder = $this->setUpQueryBuilder(false, null, $indexBy = 'index');

        $this->assertSame($queryBuilder, $this->repository->createQueryBuilder(null, $indexBy));
    }

    public function testCreateQueryForCollectionBuilder()
    {
        $queryBuilder = $this->setUpQueryBuilder();

        $this->assertSame($queryBuilder, $this->repository->createQueryBuilderForCollection());
    }

    public function testCreateQueryBuilderForCollectionWithAlias()
    {
        $queryBuilder = $this->setUpQueryBuilder(false, $alias = 'foo');

        $this->assertSame($queryBuilder, $this->repository->createQueryBuilderForCollection($alias));
    }

    public function testCreateQueryBuilderForCollectionWithIndexBy()
    {
        $queryBuilder = $this->setUpQueryBuilder(false, null, $indexBy = 'index');

        $this->assertSame($queryBuilder, $this->repository->createQueryBuilderForCollection(null, $indexBy));
    }

    public function testFindOneByWithNullValue()

    {
        $queryBuilder = $this->setUpQueryBuilder($value = null);

        $queryBuilder
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->expects($this->once())
            ->method('getQuery')
            ->will($this->returnValue($query = $this->createQueryMock()));

        $query
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->expects($this->once())
            ->method('getOneOrNullResult')
            ->will($this->returnValue($result = 'result'));

        $this->assertSame($result, $this->repository->findOneBy(['foo' => $value], ['baz' => 'ASC']));
    }

    public function testFindOneByWithScalarValue()

    {
        $queryBuilder = $this->setUpQueryBuilder($value = 'bar');

        $queryBuilder
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->expects($this->once())
            ->method('getQuery')
            ->will($this->returnValue($query = $this->createQueryMock()));

        $query
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->expects($this->once())
            ->method('getOneOrNullResult')
            ->will($this->returnValue($result = 'result'));

        $this->assertSame($result, $this->repository->findOneBy(['foo' => $value], ['baz' => 'ASC']));
    }

    public function testFindOneByWithArrayValue()

    {
        $queryBuilder = $this->setUpQueryBuilder($value = ['bar']);

        $queryBuilder
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->expects($this->once())
            ->method('getQuery')
            ->will($this->returnValue($query = $this->createQueryMock()));

        $query
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->expects($this->once())
            ->method('getOneOrNullResult')
            ->will($this->returnValue($result = 'result'));

        $this->assertSame($result, $this->repository->findOneBy(['foo' => $value], ['baz' => 'ASC']));
    }

    public function testFindBy()
    {
        $queryBuilder = $this->setUpQueryBuilder($value = 'bar');

        $queryBuilder
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->expects($this->once())
            ->method('setMaxResults')
            ->with($this->identicalTo($limit = 5))
            ->will($this->returnSelf());

        $queryBuilder
            ->expects($this->once())
            ->method('setFirstResult')
            ->with($this->identicalTo($offset = 10))
            ->will($this->returnSelf());

        $queryBuilder
            ->expects($this->once())
            ->method('getQuery')
            ->will($this->returnValue($query = $this->createQueryMock()));

        $query
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->expects($this->once())
            ->method('getResult')
            ->will($this->returnValue($result = ['result']));

        $this->assertSame($result, $this->repository->findBy(['foo' => $value], ['baz' => 'ASC'], $limit, $offset));
    }

    public function testFindForIndex()

    {
        $this->setUpQueryBuilder($value = 'bar');

        $pager = $this->repository->findForIndex(['foo' => $value], ['baz' => 'ASC']);

        $this->assertInstanceOf(Pagerfanta::class, $pager);
        $this->assertInstanceOf(DoctrineORMAdapter::class, $pager->getAdapter());
    }

    public function testFindForShow()

    {
        $queryBuilder = $this->setUpQueryBuilder($value = 'bar');

        $queryBuilder
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->expects($this->once())
            ->method('getQuery')
            ->will($this->returnValue($query = $this->createQueryMock()));

        $query
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->expects($this->once())
            ->method('getOneOrNullResult')
            ->will($this->returnValue($result = 'result'));

        $this->assertSame($result, $this->repository->findForShow(['foo' => $value], ['baz' => 'ASC']));
    }

    public function testFindForUpdate()

    {
        $queryBuilder = $this->setUpQueryBuilder($value = 'bar');

        $queryBuilder
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->expects($this->once())
            ->method('getQuery')
            ->will($this->returnValue($query = $this->createQueryMock()));

        $query
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->expects($this->once())
            ->method('getOneOrNullResult')
            ->will($this->returnValue($result = 'result'));

        $this->assertSame($result, $this->repository->findForUpdate(['foo' => $value], ['baz' => 'ASC']));
    }

    public function testFindForDelete()

    {
        $queryBuilder = $this->setUpQueryBuilder($value = 'bar');

        $queryBuilder
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->expects($this->once())
            ->method('getQuery')
            ->will($this->returnValue($query = $this->createQueryMock()));

        $query
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->expects($this->once())
            ->method('getOneOrNullResult')
            ->will($this->returnValue($result = 'result'));

        $this->assertSame($result, $this->repository->findForDelete(['foo' => $value], ['baz' => 'ASC']));
    }

    /**
     * @param mixed       $value
     * @param string|null $alias
     * @param string|null $indexBy
     *
     * @return \PHPUnit_Framework_MockObject_MockObject|QueryBuilder
     */
    private function setUpQueryBuilder($value = false, $alias = null, $indexBy = null)
    {
        if ($alias === null) {
            $this->resource
                ->expects($this->once())
                ->method('getName')
                ->will($this->returnValue($resource = 'resource'));
        } else {
            $resource = $alias;
        }

        $this->entityManager
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->expects($this->once())
            ->method('createQueryBuilder')
            ->will($this->returnValue($queryBuilder = $this->createQueryBuilderMock()));

        $queryBuilder
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->expects($this->once())
            ->method('select')
            ->with($this->identicalTo($resource))
            ->will($this->returnSelf());

        $queryBuilder
            ->expects($this->once())
            ->method('from')
            ->with($this->identicalTo($this->class), $this->identicalTo($resource), $this->identicalTo($indexBy))
            ->will($this->returnSelf());

        $queryBuilder
            ->expects($this->any())
            ->method('getRootAliases')
            ->will($this->returnValue([$resource]));

        if ($value === false) {
            return $queryBuilder;
        }

        $queryBuilder
            ->expects($this->once())
            ->method('expr')
            ->will($this->returnValue($expr = $this->createExprMock()));

        if ($value === null) {
            $expr
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                ->expects($this->once())
                ->method('isNull')
                ->with($this->identicalTo($resource.'.'.($property = 'foo')))
                ->will($this->returnValue($expression = 'expression'));
        } else {
            $expr
                ->expects($this->once())
                ->method(is_string($value) ? 'eq' : 'in')
                ->with(
                    $this->identicalTo($resource.'.'.($property = 'foo')),
                    $this->matchesRegularExpression('/:'.$resource.'_'.$property.'_[a-z0-9]{22}/')
                )
                ->will($this->returnValue($expression = 'expression'));

            $queryBuilder
                ->expects($this->once())
                ->method('setParameter')
                ->with(
                    $this->matchesRegularExpression('/'.$resource.'_'.$property.'_[a-z0-9]{22}/'),
                    $this->identicalTo($value)
                )
                ->will($this->returnSelf());
        }

        $queryBuilder
            ->expects($this->once())
            ->method('andWhere')
            ->with($this->identicalTo($expression))
            ->will($this->returnSelf());

        $queryBuilder
            ->expects($this->once())
            ->method('addOrderBy')
            ->with($this->identicalTo($resource.'.'.($order = 'baz')), $this->identicalTo($sort = 'ASC'))
            ->will($this->returnSelf());

        return $queryBuilder;
    }

    /**
     * @return \PHPUnit_Framework_MockObject_MockObject|EntityManager
     */
    private function createEntityManagerMock()
    {
        return $this->getMockBuilder(EntityManager::class)
            ->disableOriginalConstructor()
            ->getMock();
    }

    /**
     * @return \PHPUnit_Framework_MockObject_MockObject|ClassMetadata
     */
    private function createClassMetadataMock()
    {
        return $this->getMockBuilder(ClassMetadata::class)
            ->disableOriginalConstructor()
            ->getMock();
    }

    /**
     * @return \PHPUnit_Framework_MockObject_MockObject|ResourceInterface
     */
    private function createResourceMock()
    {
        return $this->getMock(ResourceInterface::class);
    }

    /**
     * @return \PHPUnit_Framework_MockObject_MockObject|QueryBuilder
     */
    private function createQueryBuilderMock()
    {
        return $this->getMockBuilder(QueryBuilder::class)
            ->disableOriginalConstructor()
            ->getMock();
    }

    /**
     * @return \PHPUnit_Framework_MockObject_MockObject|Expr
     */
    private function createExprMock()
    {
        return $this->getMock(Expr::class);
    }

    /**
     * @return \PHPUnit_Framework_MockObject_MockObject|Query
     */
    private function createQueryMock()
    {
        return $this->getMock(\stdClass::class, ['getOneOrNullResult', 'getResult']);
    }
}


Push — master ( 74c3c7...591b88 )

RepositoryTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

24 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

php-lug / lug

Push — master ( 74c3c7...591b88 )

RepositoryTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

24 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like