View GitHub Repository lug

Schedule Inspection
Subscribe
Completed
Pull Request — master (#54)
by Eric
43:00 queued 34:26
created
Status
Category
Toggle Patches
src/Bundle/UiBundle/Tests/Menu/MenuBuilderTest.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -75,7 +75,7 @@
 
 block discarded – undo
75 75 
             ->method('dispatch')
76 76 
             ->with(
77 77 
                 $this->identicalTo(MenuBuilderEvents::BUILD),
78 
-                $this->callback(function (MenuBuilderEvent $event) use ($item) {
78 
+                $this->callback(function(MenuBuilderEvent $event) use ($item) {
79 79 
                     return $event->getFactory() === $this->factory
80 80 
                         && $event->getItem() === $item;
81 81 
                 })
Please login to merge, or discard this patch.
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -85,7 +85,7 @@  discard block
 
 block discarded – undo
85 85 
     }
86 86
87 87 
     /**
88 
-     * @return \PHPUnit_Framework_MockObject_MockObject|FactoryInterface
88 
+     * @return \PHPUnit_Framework_MockObject_MockObject
89 89 
      */
90 90 
     private function createFactoryMock()
91 91 
     {
 
@@ -93,7 +93,7 @@  discard block
 
 block discarded – undo
93 93 
     }
94 94
95 95 
     /**
96 
-     * @return \PHPUnit_Framework_MockObject_MockObject|EventDispatcherInterface
96 
+     * @return \PHPUnit_Framework_MockObject_MockObject
97 97 
      */
98 98 
     private function createEventDispatcherMock()
99 99 
     {
 
@@ -101,7 +101,7 @@  discard block
 
 block discarded – undo
101 101 
     }
102 102
103 103 
     /**
104 
-     * @return \PHPUnit_Framework_MockObject_MockObject|ItemInterface
104 
+     * @return \PHPUnit_Framework_MockObject_MockObject
105 105 
      */
106 106 
     private function createItemMock()
107 107 
     {
Please login to merge, or discard this patch.
src/Component/Grid/Tests/Filter/FiltererTest.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -100,7 +100,7 @@
 
 block discarded – undo
100 100 
         $sortType
101 101 
             ->expects($this->once())
102 102 
             ->method('configureOptions')
103 
-            ->with($this->callback(function (OptionsResolver $resolver) use ($options) {
103 
+            ->with($this->callback(function(OptionsResolver $resolver) use ($options) {
104 104 
                 $resolver->setDefined(array_merge(['builder', 'sort', 'grid'], array_keys($options)));
105 105
106 106 
                 return true;
Please login to merge, or discard this patch.
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch 
@@ -127,7 +127,7 @@  discard block
 
 block discarded – undo
127 127 
     }
128 128
129 129 
     /**
130 
-     * @return \PHPUnit_Framework_MockObject_MockObject|RegistryInterface
130 
+     * @return \PHPUnit_Framework_MockObject_MockObject
131 131 
      */
132 132 
     private function createServiceRegistryMock()
133 133 
     {
 
@@ -135,7 +135,7 @@  discard block
 
 block discarded – undo
135 135 
     }
136 136
137 137 
     /**
138 
-     * @return \PHPUnit_Framework_MockObject_MockObject|DataSourceBuilderInterface
138 
+     * @return \PHPUnit_Framework_MockObject_MockObject
139 139 
      */
140 140 
     private function createDataSourceBuilderMock()
141 141 
     {
 
@@ -143,7 +143,7 @@  discard block
 
 block discarded – undo
143 143 
     }
144 144
145 145 
     /**
146 
-     * @return \PHPUnit_Framework_MockObject_MockObject|GridInterface
146 
+     * @return \PHPUnit_Framework_MockObject_MockObject
147 147 
      */
148 148 
     private function createGridMock()
149 149 
     {
 
@@ -151,7 +151,7 @@  discard block
 
 block discarded – undo
151 151 
     }
152 152
153 153 
     /**
154 
-     * @return \PHPUnit_Framework_MockObject_MockObject|FilterInterface
154 
+     * @return \PHPUnit_Framework_MockObject_MockObject
155 155 
      */
156 156 
     private function createFilterMock()
157 157 
     {
 
@@ -159,7 +159,7 @@  discard block
 
 block discarded – undo
159 159 
     }
160 160
161 161 
     /**
162 
-     * @return \PHPUnit_Framework_MockObject_MockObject|TypeInterface
162 
+     * @return \PHPUnit_Framework_MockObject_MockObject
163 163 
      */
164 164 
     private function createFilterTypeMock()
165 165 
     {
Please login to merge, or discard this patch.
src/Component/Grid/Tests/Batch/BatcherTest.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -100,7 +100,7 @@
 
 block discarded – undo
100 100 
         $sortType
101 101 
             ->expects($this->once())
102 102 
             ->method('configureOptions')
103 
-            ->with($this->callback(function (OptionsResolver $resolver) use ($options) {
103 
+            ->with($this->callback(function(OptionsResolver $resolver) use ($options) {
104 104 
                 $resolver->setDefined(array_merge(['builder', 'sort', 'grid'], array_keys($options)));
105 105
106 106 
                 return true;
Please login to merge, or discard this patch.
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -114,7 +114,7 @@  discard block
 
 block discarded – undo
114 114 
     }
115 115
116 116 
     /**
117 
-     * @return \PHPUnit_Framework_MockObject_MockObject|RegistryInterface
117 
+     * @return \PHPUnit_Framework_MockObject_MockObject
118 118 
      */
119 119 
     private function createServiceRegistryMock()
120 120 
     {
 
@@ -122,7 +122,7 @@  discard block
 
 block discarded – undo
122 122 
     }
123 123
124 124 
     /**
125 
-     * @return \PHPUnit_Framework_MockObject_MockObject|GridInterface
125 
+     * @return \PHPUnit_Framework_MockObject_MockObject
126 126 
      */
127 127 
     private function createGridMock()
128 128 
     {
 
@@ -130,7 +130,7 @@  discard block
 
 block discarded – undo
130 130 
     }
131 131
132 132 
     /**
133 
-     * @return \PHPUnit_Framework_MockObject_MockObject|BatchInterface
133 
+     * @return \PHPUnit_Framework_MockObject_MockObject
134 134 
      */
135 135 
     private function createBatchMock()
136 136 
     {
 
@@ -138,7 +138,7 @@  discard block
 
 block discarded – undo
138 138 
     }
139 139
140 140 
     /**
141 
-     * @return \PHPUnit_Framework_MockObject_MockObject|TypeInterface
141 
+     * @return \PHPUnit_Framework_MockObject_MockObject
142 142 
      */
143 143 
     private function createBatchTypeMock()
144 144 
     {
Please login to merge, or discard this patch.
src/Component/Grid/Tests/Column/ColumnRendererTest.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -100,7 +100,7 @@
 
 block discarded – undo
100 100 
         $sortType
101 101 
             ->expects($this->once())
102 102 
             ->method('configureOptions')
103 
-            ->with($this->callback(function (OptionsResolver $resolver) use ($options) {
103 
+            ->with($this->callback(function(OptionsResolver $resolver) use ($options) {
104 104 
                 $resolver->setDefined(array_merge(['builder', 'sort', 'grid'], array_keys($options)));
105 105
106 106 
                 return true;
Please login to merge, or discard this patch.
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -109,7 +109,7 @@  discard block
 
 block discarded – undo
109 109 
     }
110 110
111 111 
     /**
112 
-     * @return \PHPUnit_Framework_MockObject_MockObject|RegistryInterface
112 
+     * @return \PHPUnit_Framework_MockObject_MockObject
113 113 
      */
114 114 
     private function createServiceRegistryMock()
115 115 
     {
 
@@ -117,7 +117,7 @@  discard block
 
 block discarded – undo
117 117 
     }
118 118
119 119 
     /**
120 
-     * @return \PHPUnit_Framework_MockObject_MockObject|GridViewInterface
120 
+     * @return \PHPUnit_Framework_MockObject_MockObject
121 121 
      */
122 122 
     private function createGridViewMock()
123 123 
     {
 
@@ -125,7 +125,7 @@  discard block
 
 block discarded – undo
125 125 
     }
126 126
127 127 
     /**
128 
-     * @return \PHPUnit_Framework_MockObject_MockObject|ColumnInterface
128 
+     * @return \PHPUnit_Framework_MockObject_MockObject
129 129 
      */
130 130 
     private function createColumnMock()
131 131 
     {
 
@@ -133,7 +133,7 @@  discard block
 
 block discarded – undo
133 133 
     }
134 134
135 135 
     /**
136 
-     * @return \PHPUnit_Framework_MockObject_MockObject|TypeInterface
136 
+     * @return \PHPUnit_Framework_MockObject_MockObject
137 137 
      */
138 138 
     private function createColumnTypeMock()
139 139 
     {
Please login to merge, or discard this patch.
src/Component/Grid/Tests/Action/ActionRendererTest.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -100,7 +100,7 @@
 
 block discarded – undo
100 100 
         $sortType
101 101 
             ->expects($this->once())
102 102 
             ->method('configureOptions')
103 
-            ->with($this->callback(function (OptionsResolver $resolver) use ($options) {
103 
+            ->with($this->callback(function(OptionsResolver $resolver) use ($options) {
104 104 
                 $resolver->setDefined(array_merge(['builder', 'sort', 'grid'], array_keys($options)));
105 105
106 106 
                 return true;
Please login to merge, or discard this patch.
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -109,7 +109,7 @@  discard block
 
 block discarded – undo
109 109 
     }
110 110
111 111 
     /**
112 
-     * @return \PHPUnit_Framework_MockObject_MockObject|RegistryInterface
112 
+     * @return \PHPUnit_Framework_MockObject_MockObject
113 113 
      */
114 114 
     private function createServiceRegistryMock()
115 115 
     {
 
@@ -117,7 +117,7 @@  discard block
 
 block discarded – undo
117 117 
     }
118 118
119 119 
     /**
120 
-     * @return \PHPUnit_Framework_MockObject_MockObject|GridViewInterface
120 
+     * @return \PHPUnit_Framework_MockObject_MockObject
121 121 
      */
122 122 
     private function createGridViewMock()
123 123 
     {
 
@@ -125,7 +125,7 @@  discard block
 
 block discarded – undo
125 125 
     }
126 126
127 127 
     /**
128 
-     * @return \PHPUnit_Framework_MockObject_MockObject|ActionInterface
128 
+     * @return \PHPUnit_Framework_MockObject_MockObject
129 129 
      */
130 130 
     private function createActionMock()
131 131 
     {
 
@@ -133,7 +133,7 @@  discard block
 
 block discarded – undo
133 133 
     }
134 134
135 135 
     /**
136 
-     * @return \PHPUnit_Framework_MockObject_MockObject|TypeInterface
136 
+     * @return \PHPUnit_Framework_MockObject_MockObject
137 137 
      */
138 138 
     private function createActionTypeMock()
139 139 
     {
Please login to merge, or discard this patch.
src/Component/Grid/Filter/Type/ResourceType.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -70,7 +70,7 @@
 
 block discarded – undo
70 70 
         $resolver
71 71 
             ->setRequired('resource')
72 72 
             ->setAllowedTypes('resource', ['string', ResourceInterface::class])
73 
-            ->setNormalizer('resource', function (Options $options, $resource) {
73 
+            ->setNormalizer('resource', function(Options $options, $resource) {
74 74 
                 return is_string($resource) ? $this->resourceRegistry[$resource] : $resource;
75 75 
             });
76 76 
     }
Please login to merge, or discard this patch.
src/Bundle/GridBundle/Form/Type/Filter/NumberFilterType.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -43,7 +43,7 @@
 
 block discarded – undo
43 43 
         $builder
44 44 
             ->add($builder->create('type', ChoiceType::class, [
45 45 
                 'choices' => array_combine(
46 
-                    array_map(function ($choice) use ($options) {
46 
+                    array_map(function($choice) use ($options) {
47 47 
                         return $options['label_prefix'].'.type.'.$choice;
48 48 
                     }, $choices = DateTimeType::getTypes()),
49 49 
                     $choices
Please login to merge, or discard this patch.
src/Bundle/GridBundle/Form/Type/Filter/TextFilterType.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -43,7 +43,7 @@
 
 block discarded – undo
43 43 
         $builder
44 44 
             ->add($builder->create('type', ChoiceType::class, [
45 45 
                 'choices' => array_combine(
46 
-                    array_map(function ($choice) use ($options) {
46 
+                    array_map(function($choice) use ($options) {
47 47 
                         return $options['label_prefix'].'.type.'.$choice;
48 48 
                     }, $choices = DateTimeType::getTypes()),
49 49 
                     $choices
Please login to merge, or discard this patch.
src/Bundle/GridBundle/Form/Type/Filter/ResourceFilterType.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -43,7 +43,7 @@
 
 block discarded – undo
43 43 
         $builder
44 44 
             ->add($builder->create('type', ChoiceType::class, [
45 45 
                 'choices' => array_combine(
46 
-                    array_map(function ($choice) use ($options) {
46 
+                    array_map(function($choice) use ($options) {
47 47 
                         return $options['label_prefix'].'.type.'.$choice;
48 48 
                     }, $choices = DateTimeType::getTypes()),
49 49 
                     $choices
Please login to merge, or discard this patch.