Client::sendRequest() - Code Metrics - Inspection of "Merge pull request #45 from shulard/chore/psr18" - php-http/react-adapter - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f895fe...230702 )

by Stéphane

created 2020-12-17 15:34 UTC

Client::sendRequest() A

↳ Parent: Client

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
eloc	2
c	0
b	0
f	0
dl	0
loc	5
ccs	3
cts	3
cp	1
rs	10
cc	1
nc	1
nop	1
crap	1

<?php

namespace Http\Adapter\React;

use Http\Client\HttpClient;
use Http\Client\HttpAsyncClient;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;
use React\EventLoop\LoopInterface;
use React\Http\Browser as ReactBrowser;

/**
 * Client for the React promise implementation.
 *
 * @author Stéphane Hulard <[email protected]>
 */
class Client implements HttpClient, HttpAsyncClient
{
    /**
     * React HTTP client.
     *
     * @var ReactBrowser
     */
    private $client;

    /**
     * React event loop.
     *
     * @var LoopInterface
     */
    private $loop;

    /**
     * Initialize the React client.
     */
    public function __construct(
        LoopInterface $loop = null,
        ReactBrowser $client = null
    ) {
        if (null !== $client && null === $loop) {
            throw new \RuntimeException('You must give a LoopInterface instance with the Client');
        }

        $this->loop = $loop ?: ReactFactory::buildEventLoop();
        $this->client = $client ?: ReactFactory::buildHttpClient($this->loop);
    }

    /**
     * {@inheritdoc}
     */
    public function sendRequest(RequestInterface $request): ResponseInterface
    {
        $promise = $this->sendAsyncRequest($request);

        return $promise->wait();

    }

    /**
     * {@inheritdoc}
     */
    public function sendAsyncRequest(RequestInterface $request)
    {
        $promise = new Promise(
            $this->client->request(
                $request->getMethod(),
                $request->getUri(),
                $request->getHeaders(),
                $request->getBody()
            ),
            $this->loop,
            $request
        );

        return $promise;
    }
}


1		<?php
2
3		namespace Http\Adapter\React;
4
5		use Http\Client\HttpClient;
6		use Http\Client\HttpAsyncClient;
7		use Psr\Http\Message\RequestInterface;
8		use Psr\Http\Message\ResponseInterface;
9		use React\EventLoop\LoopInterface;
10		use React\Http\Browser as ReactBrowser;
11
12		/**
13		* Client for the React promise implementation.
14		*
15		* @author Stéphane Hulard <[email protected]>
16		*/
17		class Client implements HttpClient, HttpAsyncClient
18		{
19		/**
20		* React HTTP client.
21		*
22		* @var ReactBrowser
23		*/
24		private $client;
25
26		/**
27		* React event loop.
28		*
29		* @var LoopInterface
30		*/
31		private $loop;
32
33		/**
34		* Initialize the React client.
35		*/
36	104	public function __construct(
37		LoopInterface $loop = null,
38		ReactBrowser $client = null
39		) {
40	104	if (null !== $client && null === $loop) {
41		throw new \RuntimeException('You must give a LoopInterface instance with the Client');
42		}
43
44	104	$this->loop = $loop ?: ReactFactory::buildEventLoop();
45	104	$this->client = $client ?: ReactFactory::buildHttpClient($this->loop);
46	104	}
47
48		/**
49		* {@inheritdoc}
50		*/
51	51	public function sendRequest(RequestInterface $request): ResponseInterface
52		{
53	51	$promise = $this->sendAsyncRequest($request);
54
55	51	return $promise->wait();
		0 ignored issues – show Bug Best Practice introduced 2020-12-16 12:07 UTC by Report Bug Copy Issue Report The expression `return $promise->wait()` could return the type `null` which is incompatible with the type-hinted return `Psr\Http\Message\ResponseInterface`. Consider adding an additional type-check to rule them out. Loading history...
56		}
57
58		/**
59		* {@inheritdoc}
60		*/
61	104	public function sendAsyncRequest(RequestInterface $request)
62		{
63	104	$promise = new Promise(
64	104	$this->client->request(
65	104	$request->getMethod(),
66	104	$request->getUri(),
67	104	$request->getHeaders(),
68	104	$request->getBody()
69		),
70	104	$this->loop,
71	104	$request
72		);
73
74	104	return $promise;
75		}
76		}
77

php-http / react-adapter

Push — master ( f895fe...230702 )

Client::sendRequest() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like