Client::buildReactRequest() - Code Metrics - Inspection of "Upgrade to react/http instead of react/http-client..." - php-http/react-adapter - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#42)

by Stéphane

created 2020-12-16 15:36 UTC

Client::buildReactRequest() A

↳ Parent: Project

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	17
ccs	10
cts	10
cp	1
rs	9.7
c	0
b	0
f	0
cc	3
nc	3
nop	1
crap	3

<?php

namespace Http\Adapter\React;

use Http\Client\HttpClient;
use Http\Client\HttpAsyncClient;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;
use React\EventLoop\LoopInterface;
use React\Http\Browser as ReactBrowser;

/**
 * Client for the React promise implementation.
 *
 * @author Stéphane Hulard <[email protected]>
 */
class Client implements HttpClient, HttpAsyncClient
{
    /**
     * React HTTP client.
     *
     * @var ReactBrowser
     */
    private $client;

    /**
     * React event loop.
     *
     * @var LoopInterface
     */
    private $loop;

    /**
     * Initialize the React client.
     */
    public function __construct(
        LoopInterface $loop = null,
        ReactBrowser $client = null
    ) {
        if (null !== $client && null === $loop) {
            throw new \RuntimeException(
                'You must give a LoopInterface instance with the Client'
            );
        }

        $this->loop = $loop     ?: ReactFactory::buildEventLoop();
        $this->client = $client ?: ReactFactory::buildHttpClient($this->loop);
    }

    /**
     * {@inheritdoc}
     */
    public function sendRequest(RequestInterface $request): ResponseInterface
    {
        $promise = $this->sendAsyncRequest($request);

        return $promise->wait();

    }

    /**
     * {@inheritdoc}
     */
    public function sendAsyncRequest(RequestInterface $request)
    {
        $promise = new Promise(
            $this->client->request(
                $request->getMethod(),
                $request->getUri(),
                $request->getHeaders(),
                $request->getBody()
            ),
            $this->loop,
            $request
        );

        return $promise;
    }
}


1		<?php
2
3		namespace Http\Adapter\React;
4
5		use Http\Client\HttpClient;
6		use Http\Client\HttpAsyncClient;
7		use Psr\Http\Message\RequestInterface;
8		use Psr\Http\Message\ResponseInterface;
9		use React\EventLoop\LoopInterface;
10		use React\Http\Browser as ReactBrowser;
11
12		/**
13		* Client for the React promise implementation.
14		*
15		* @author Stéphane Hulard <[email protected]>
16		*/
17		class Client implements HttpClient, HttpAsyncClient
18		{
19		/**
20		* React HTTP client.
21		*
22		* @var ReactBrowser
23		*/
24		private $client;
25
26		/**
27		* React event loop.
28		*
29		* @var LoopInterface
30		*/
31		private $loop;
32
33		/**
34		* Initialize the React client.
35		*/
36	104	public function __construct(
37		LoopInterface $loop = null,
38		ReactBrowser $client = null
39		) {
40	104	if (null !== $client && null === $loop) {
41		throw new \RuntimeException(
42		'You must give a LoopInterface instance with the Client'
43		);
44		}
45
46	104	$this->loop = $loop ?: ReactFactory::buildEventLoop();
47	104	$this->client = $client ?: ReactFactory::buildHttpClient($this->loop);
48	104	}
49
50		/**
51		* {@inheritdoc}
52		*/
53	51	public function sendRequest(RequestInterface $request): ResponseInterface
54		{
55	51	$promise = $this->sendAsyncRequest($request);
56
57	51	return $promise->wait();
		0 ignored issues – show Bug Best Practice introduced 2020-12-16 12:07 UTC by Report Bug Copy Issue Report The expression `return $promise->wait()` could return the type `null` which is incompatible with the type-hinted return `Psr\Http\Message\ResponseInterface`. Consider adding an additional type-check to rule them out. Loading history...
58		}
59
60		/**
61		* {@inheritdoc}
62		*/
63	104	public function sendAsyncRequest(RequestInterface $request)
64		{
65	104	$promise = new Promise(
66	104	$this->client->request(
67	104	$request->getMethod(),
68	104	$request->getUri(),
69	104	$request->getHeaders(),
70	104	$request->getBody()
71		),
72	104	$this->loop,
73	104	$request
74		);
75
76	104	return $promise;
77		}
78		}
79

php-http / react-adapter

Pull Request — master (#42)

Client::buildReactRequest() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like