Http\Adapter\React\Client

Complexity

Total Complexity

7

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Test Coverage

Coverage

94.74%

Importance

Changes	4
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	sendRequest()	0	5	1
A	sendAsyncRequest()	0	14	1
A	__construct()	0	10	5

<?php

namespace Http\Adapter\React;

use Http\Client\HttpAsyncClient;
use Http\Client\HttpClient;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;
use React\EventLoop\LoopInterface;
use React\Http\Browser as ReactBrowser;

/**
 * Client for the React promise implementation.
 *
 * @author Stéphane Hulard <s.hulard@chstudio.fr>
 */
class Client implements HttpClient, HttpAsyncClient
{
    /**
     * React HTTP client.
     *
     * @var ReactBrowser
     */
    private $client;

    /**
     * React event loop.
     *
     * @var LoopInterface
     */
    private $loop;

    /**
     * Initialize the React client.
     */
    public function __construct(
        LoopInterface $loop = null,
        ReactBrowser $client = null
    ) {
        if (null !== $client && null === $loop) {
            throw new \RuntimeException('You must give a LoopInterface instance with the Client');
        }

        $this->loop = $loop ?: ReactFactory::buildEventLoop();
        $this->client = $client ?: ReactFactory::buildHttpClient($this->loop);
    }

    /**
     * {@inheritdoc}
     */
    public function sendRequest(RequestInterface $request): ResponseInterface
    {
        $promise = $this->sendAsyncRequest($request);

        return $promise->wait();

The expression return $promise->wait() could return the type null which is incompatible with the type-hinted return Psr\Http\Message\ResponseInterface. Consider adding an additional type-check to rule them out.

    }

    /**
     * {@inheritdoc}
     */
    public function sendAsyncRequest(RequestInterface $request)
    {
        $promise = new Promise(
            $this->client->request(
                $request->getMethod(),
                $request->getUri(),
                $request->getHeaders(),
                $request->getBody()
            ),
            $this->loop,
            $request
        );

        return $promise;
    }
}