FulfilledPromise::__construct() - Code Metrics - Inspection of "Add some more tests" - php-http/promise - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cd9351...1bb790 )

by Márk

created 2016-01-11 21:26 UTC

FulfilledPromise::__construct() A

↳ Parent: FulfilledPromise

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	4
Ratio	100 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	4
loc	4
ccs	3
cts	3
cp	1
rs	10
cc	1
eloc	2
nc	1
nop	1
crap	1

<?php

namespace Http\Promise;

use Psr\Http\Message\ResponseInterface;

/**
 * A promise already fulfilled.
 *
 * @author Joel Wurtz <[email protected]>
 */
final class FulfilledPromise implements Promise

{
    /**
     * @var ResponseInterface
     */
    private $response;

    /**
     * @param ResponseInterface $response
     */
    public function __construct(ResponseInterface $response)
    {
        $this->response = $response;
    }

    /**
     * {@inheritdoc}
     */
    public function then(callable $onFulfilled = null, callable $onRejected = null)
    {
        if (null === $onFulfilled) {
            return $this;
        }

        try {
            return new self($onFulfilled($this->response));
        } catch (\Exception $e) {
            return new RejectedPromise($e);
        }
    }

    /**
     * {@inheritdoc}
     */
    public function getState()
    {
        return Promise::FULFILLED;
    }

    /**
     * {@inheritdoc}
     */
    public function wait($unwrap = true)
    {
        if ($unwrap) {
            return $this->response;
        }
    }
}


1			<?php
2
3			namespace Http\Promise;
4
5			use Psr\Http\Message\ResponseInterface;
6
7			/**
8			* A promise already fulfilled.
9			*
10			* @author Joel Wurtz <[email protected]>
11			*/
12		View Code Duplication	final class FulfilledPromise implements Promise
			0 ignored issues – show Duplication introduced 2016-01-11 21:15 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
13			{
14			/**
15			* @var ResponseInterface
16			*/
17			private $response;
18
19			/**
20			* @param ResponseInterface $response
21			*/
22	9		public function __construct(ResponseInterface $response)
23			{
24	9		$this->response = $response;
25	9		}
26
27			/**
28			* {@inheritdoc}
29			*/
30	3		public function then(callable $onFulfilled = null, callable $onRejected = null)
31	1		{
32	3		if (null === $onFulfilled) {
33	1		return $this;
34			}
35
36			try {
37	2		return new self($onFulfilled($this->response));
38	1		} catch (\Exception $e) {
39	1		return new RejectedPromise($e);
40			}
41			}
42
43			/**
44			* {@inheritdoc}
45			*/
46	3		public function getState()
47			{
48	3		return Promise::FULFILLED;
49			}
50
51			/**
52			* {@inheritdoc}
53			*/
54	4		public function wait($unwrap = true)
55			{
56	4		if ($unwrap) {
57	3		return $this->response;
58			}
59	1		}
60			}
61

php-http / promise

Push — master ( cd9351...1bb790 )

FulfilledPromise::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like