ErrorPlugin::transformResponseToException() - Code Metrics - php-http/plugins - Measure and Improve Code Quality continuously with Scrutinizer

ErrorPlugin::transformResponseToException() A
last analyzed 2019-06-05 09:03 UTC

↳ Parent: ErrorPlugin

Complexity

Conditions	5
Paths	3

Size

Total Lines

Duplication

Lines	6
Ratio	50 %

Code Coverage

Tests	6
CRAP Score	5

Importance

Changes

Metric	Value
dl	6
loc	12
ccs	6
cts	6
cp	1
rs	9.5555
c	0
b	0
f	0
cc	5
nc	3
nop	2
crap	5

<?php

namespace Http\Client\Plugin;

@trigger_error('The '.__NAMESPACE__.'\ErrorPlugin class is deprecated since version 1.1 and will be removed in 2.0. Use Http\Client\Common\Plugin\ErrorPlugin instead.', E_USER_DEPRECATED);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

use Http\Client\Plugin\Exception\ClientErrorException;
use Http\Client\Plugin\Exception\ServerErrorException;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;

/**
 * Throw exception when the response of a request is not acceptable.
 *
 * By default an exception will be thrown for all status codes from 400 to 599.
 *
 * @author Joel Wurtz <[email protected]>
 *
 * @deprecated since since version 1.1, and will be removed in 2.0. Use {@link \Http\Client\Common\Plugin\ErrorPlugin} instead.
 */
class ErrorPlugin implements Plugin

{
    /**
     * {@inheritdoc}
     */
    public function handleRequest(RequestInterface $request, callable $next, callable $first)
    {
        $promise = $next($request);

        return $promise->then(function (ResponseInterface $response) use ($request) {
            return $this->transformResponseToException($request, $response);
        });
    }

    /**
     * Transform response to an error if possible.
     *
     * @param RequestInterface  $request  Request of the call
     * @param ResponseInterface $response Response of the call
     *
     * @throws ClientErrorException If response status code is a 4xx
     * @throws ServerErrorException If response status code is a 5xx
     *
     * @return ResponseInterface If status code is not in 4xx or 5xx return response
     */
    protected function transformResponseToException(RequestInterface $request, ResponseInterface $response)
    {
        if ($response->getStatusCode() >= 400 && $response->getStatusCode() < 500) {

            throw new ClientErrorException($response->getReasonPhrase(), $request, $response);

        }

        if ($response->getStatusCode() >= 500 && $response->getStatusCode() < 600) {

            throw new ServerErrorException($response->getReasonPhrase(), $request, $response);

        }

        return $response;
    }
}


1			<?php
2
3			namespace Http\Client\Plugin;
4
5	1		@trigger_error('The '.__NAMESPACE__.'\ErrorPlugin class is deprecated since version 1.1 and will be removed in 2.0. Use Http\Client\Common\Plugin\ErrorPlugin instead.', E_USER_DEPRECATED);
			0 ignored issues – show Security Best Practice introduced 2016-05-04 07:47 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
6
7			use Http\Client\Plugin\Exception\ClientErrorException;
8			use Http\Client\Plugin\Exception\ServerErrorException;
9			use Psr\Http\Message\RequestInterface;
10			use Psr\Http\Message\ResponseInterface;
11
12			/**
13			* Throw exception when the response of a request is not acceptable.
14			*
15			* By default an exception will be thrown for all status codes from 400 to 599.
16			*
17			* @author Joel Wurtz <[email protected]>
18			*
19			* @deprecated since since version 1.1, and will be removed in 2.0. Use {@link \Http\Client\Common\Plugin\ErrorPlugin} instead.
20			*/
21			class ErrorPlugin implements Plugin
			0 ignored issues – show Deprecated Code introduced 2016-05-04 06:48 UTC by Report Bug Copy Issue Report The interface `Http\Client\Plugin\Plugin` has been deprecated with message: since since version 1.1, and will be removed in 2.0. Use {@link \Http\Client\Common\Plugin} instead. This class, trait or interface has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the type will be removed from the class and what other constant to use instead. Loading history...
22			{
23			/**
24			* {@inheritdoc}
25			*/
26	3		public function handleRequest(RequestInterface $request, callable $next, callable $first)
27			{
28	3		$promise = $next($request);
29
30	3		return $promise->then(function (ResponseInterface $response) use ($request) {
31	3		return $this->transformResponseToException($request, $response);
32	3		});
33			}
34
35			/**
36			* Transform response to an error if possible.
37			*
38			* @param RequestInterface $request Request of the call
39			* @param ResponseInterface $response Response of the call
40			*
41			* @throws ClientErrorException If response status code is a 4xx
42			* @throws ServerErrorException If response status code is a 5xx
43			*
44			* @return ResponseInterface If status code is not in 4xx or 5xx return response
45			*/
46	3		protected function transformResponseToException(RequestInterface $request, ResponseInterface $response)
47			{
48	3	View Code Duplication	if ($response->getStatusCode() >= 400 && $response->getStatusCode() < 500) {
			0 ignored issues – show Duplication introduced 2015-12-25 21:58 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
49	1		throw new ClientErrorException($response->getReasonPhrase(), $request, $response);
			0 ignored issues – show Deprecated Code introduced 2016-05-04 06:48 UTC by Report Bug Copy Issue Report The class `Http\Client\Plugin\Exception\ClientErrorException` has been deprecated with message: since since version 1.1, and will be removed in 2.0. Use {@link \Http\Client\Common\Exception\ClientErrorException} instead. This class, trait or interface has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the type will be removed from the class and what other constant to use instead. Loading history...
50			}
51
52	2	View Code Duplication	if ($response->getStatusCode() >= 500 && $response->getStatusCode() < 600) {
			0 ignored issues – show Duplication introduced 2015-12-25 21:58 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
53	1		throw new ServerErrorException($response->getReasonPhrase(), $request, $response);
			0 ignored issues – show Deprecated Code introduced 2016-05-04 06:48 UTC by Report Bug Copy Issue Report The class `Http\Client\Plugin\Exception\ServerErrorException` has been deprecated with message: since since version 1.1, and will be removed in 2.0. Use {@link \Http\Client\Common\Exception\ServerErrorException} instead. This class, trait or interface has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the type will be removed from the class and what other constant to use instead. Loading history...
54			}
55
56	1		return $response;
57			}
58			}
59

php-http / plugins

ErrorPlugin::transformResponseToException() A last analyzed 2019-06-05 09:03 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

ErrorPlugin::transformResponseToException() A
last analyzed 2019-06-05 09:03 UTC